[Ryu-devel] Bug Fix - OFPSetAsync Call

2014-03-18 Thread Sriram
Hi, When OFPSetAsync is called, I noticed that appropriate bits are not set correctly. Each type should be left shifted to set the correct type and receive corresponding async messages from the switch. Attached is a patch that addresses this bug. Sriram SetAsync_Config.patch Description: Binar

[Ryu-devel] [PATCH v5 1/5] Allow messages inside messages

2014-03-18 Thread Simon Horman
Bundle Add Message and Request Forward Message, which is part of OpenFlow 1.4, encapsulates an OpenFlow message in side an OpenFlow message. This patch prepares for this by adding a MsgInMsgBase class, a subclass of MsgBase which allows its subclasses to include subclasses of either MsgInMsgBase o

[Ryu-devel] [PATCH v5 5/5] Add request forward message unit test

2014-03-18 Thread Simon Horman
Signed-off-by: Simon Horman --- v4 - v5 * No change v3 * Fix sequence number in filenames: Rename 5-70* => 5-71 v2 * First post --- .../of14/5-71-ofp_requestforward.packet| Bin 0 -> 56 bytes ryu/tests/packet_data_generator/src/x5.erl | 22 ++- .../json/of14/5-

[Ryu-devel] [PATCH v5 3/5] of14: Add bundle add message unit test

2014-03-18 Thread Simon Horman
Signed-off-by: Simon Horman --- v4 - v5 * No change v3 * Update Data to use bytes rather than arrays of words * Correct sequence number in filenames: 5-69* => 5-70* v2 * Update JSON using normalize_json.py --- .../of14/5-70-ofp_bundle_add_msg.packet| Bin 0 -> 80 bytes ryu/tests/pa

[Ryu-devel] [PATCH v5 0/5] of1.4: Increased message coverage

2014-03-18 Thread Simon Horman
Hi, The aim of this series is to add an implementation of and tests for the following messages: * Bundle add message + Now present in the v5 branch of of_protocol * Request forward message + Now present in the v5 branch of of_protocol + Was pull request 70 https://github.com/FlowForward

[Ryu-devel] [PATCH v5 4/5] Add request forward message support

2014-03-18 Thread Simon Horman
Signed-off-by: Simon Horman --- v5 * No change v4 * Inherit MsgInMsgBase instead of MsgBase - This is a new mechanism to allow messages inside messages v3 * No change v2 * First post --- ryu/ofproto/ofproto_v1_4_parser.py | 48 ++ 1 file changed, 48 inser

[Ryu-devel] [PATCH v5 2/5] of14: Add bundle add message support

2014-03-18 Thread Simon Horman
--- v5 * As suggested by YAMAMOTO Takashi - Only add padding if there are properties present - Don't assign tail_buf twice - xid of inner and outer messages should be the same v4 * Inherit MsgInMsgBase instead of MsgBase - This is a new mechanism to allow messages inside messages v2 - v3

Re: [Ryu-devel] [PATCH v3 14/18] [RFC] of14: Add bundle add message support

2014-03-18 Thread Simon Horman
On Wed, Mar 19, 2014 at 02:54:18PM +0900, YAMAMOTO Takashi wrote: > > Hi Yamamoto-san, > > > > thanks for your feedback and sorry for not addressing it in v4, > > it slipped my mind. > > > > On Thu, Mar 13, 2014 at 02:46:41PM +0900, YAMAMOTO Takashi wrote: > >> > --- > >> > v2 - v3 > >> > * No ch

Re: [Ryu-devel] [PATCH v3 14/18] [RFC] of14: Add bundle add message support

2014-03-18 Thread YAMAMOTO Takashi
> Hi Yamamoto-san, > > thanks for your feedback and sorry for not addressing it in v4, > it slipped my mind. > > On Thu, Mar 13, 2014 at 02:46:41PM +0900, YAMAMOTO Takashi wrote: >> > --- >> > v2 - v3 >> > * No change >> > --- >> > ryu/ofproto/ofproto_v1_4.py| 5 +++- >> > ryu/ofproto/o

Re: [Ryu-devel] [PATCH v3 14/18] [RFC] of14: Add bundle add message support

2014-03-18 Thread Simon Horman
Hi Yamamoto-san, thanks for your feedback and sorry for not addressing it in v4, it slipped my mind. On Thu, Mar 13, 2014 at 02:46:41PM +0900, YAMAMOTO Takashi wrote: > > --- > > v2 - v3 > > * No change > > --- > > ryu/ofproto/ofproto_v1_4.py| 5 +++- > > ryu/ofproto/ofproto_v1_4_parser

[Ryu-devel] [PATCH 1/2] enable multistage @set_ev_cls or @set_ev_handler

2014-03-18 Thread ISHIDA Wataru
Signed-off-by: ISHIDA Wataru --- ryu/base/app_manager.py | 32 ++-- ryu/controller/controller.py |3 ++- ryu/controller/handler.py| 40 ++-- 3 files changed, 46 insertions(+), 29 deletions(-) diff --git a/ryu/base/

Re: [Ryu-devel] [PATCH] enable multistage @set_ev_cls or @set_ev_handler

2014-03-18 Thread ISHIDA Wataru
Sorry for the malformed patch, I’ll resend it soon. Before resend the patch, let me describe about it. Now @set_ev_cls can’t be multi-staged, so we have to write redundant codes when different events are handled by a single handler(see app/ofctl_rest.py l.525-) The patch enables multistage @set_e

[Ryu-devel] [PATCH 2/2] ofctl_rest: use multistage @set_ev_cls

2014-03-18 Thread ISHIDA Wataru
Signed-off-by: ISHIDA Wataru --- ryu/app/ofctl_rest.py | 51 ++--- 1 file changed, 10 insertions(+), 41 deletions(-) diff --git a/ryu/app/ofctl_rest.py b/ryu/app/ofctl_rest.py index 9fbce30..5967d69 100644 --- a/ryu/app/ofctl_rest.py +++ b/ryu/app/o

Re: [Ryu-devel] [PATCH v4] ofctl_v1_2/3: IP arbitrary bitmask support

2014-03-18 Thread FUJITA Tomonori
On Tue, 18 Mar 2014 11:08:49 +0800 Wei-Li Tang wrote: > Openflow 1.1 and later versions allow the use of IP address with > arbitrary bitmask in match fields. This adds arbitrary bitmask > support to related functions. > > After applying this patch, it's no longer compatible with ACL > hybrid CID

Re: [Ryu-devel] [PATCH] ofp_event: fix a typo

2014-03-18 Thread FUJITA Tomonori
On Tue, 18 Mar 2014 13:21:29 +0900 YAMAMOTO Takashi wrote: > Signed-off-by: YAMAMOTO Takashi > --- > ryu/controller/ofp_event.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. -- Learn Graph

Re: [Ryu-devel] Multiple application on Ryu and topo discovery service

2014-03-18 Thread FUJITA Tomonori
On Tue, 18 Mar 2014 00:10:26 +0800 Dong Mo wrote: > Is there any good tutorial, docs or talks for the Ryu controller's software > architecture? Some of the information might be outdated though: http://www.slideshare.net/yamahata/ryu-sdnframeworkupload --