Re: [Ryu-devel] [PATCH 1/3] of12: set default attributes for group-related classes

2014-04-15 Thread FUJITA Tomonori
On Wed, 16 Apr 2014 10:37:37 +0900 Yuichi Ito wrote: > Signed-off-by: Yuichi Ito > --- > ryu/ofproto/ofproto_v1_2_parser.py |8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) Thanks, applied all three patches. ---

[Ryu-devel] [PATCH 1/3] bgp: add stuff for integration with bgp speaker

2014-04-15 Thread ISHIDA Wataru
Signed-off-by: ISHIDA Wataru --- ryu/lib/packet/bgp.py | 726 + 1 file changed, 675 insertions(+), 51 deletions(-) diff --git a/ryu/lib/packet/bgp.py b/ryu/lib/packet/bgp.py index 2d71917..974967d 100644 --- a/ryu/lib/packet/bgp.py +++ b/ryu/lib/

Re: [Ryu-devel] [PATCH 0/7] use Ryu bgp packet library instead of original one

2014-04-15 Thread ISHIDA Wataru
Thanks for the comments. I fixed the unit test error and pep8 warning. I’ll resend it soon. And I gave up to split the bgp packet library file, because stringify.py assumes all the attributes which in the object to be decoded are defined in one file. I created a directory just for the debug purpo

Re: [Ryu-devel] [PATCH 3/3] of14: set default attributes for group-related classes

2014-04-15 Thread Simon Horman
On Wed, Apr 16, 2014 at 10:38:09AM +0900, Yuichi Ito wrote: > Signed-off-by: Yuichi Ito Reviewed-by: Simon Horman > --- > ryu/ofproto/ofproto_v1_4_parser.py |8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/ryu/ofproto/ofproto_v1_4_parser.py > b/ryu/ofproto/

[Ryu-devel] [PATCH 1/3] of12: set default attributes for group-related classes

2014-04-15 Thread Yuichi Ito
Signed-off-by: Yuichi Ito --- ryu/ofproto/ofproto_v1_2_parser.py |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/ryu/ofproto/ofproto_v1_2_parser.py b/ryu/ofproto/ofproto_v1_2_parser.py index 08b3ae8..2b2d48f 100644 --- a/ryu/ofproto/ofproto_v1_2_parser.py +++ b/ryu

[Ryu-devel] [PATCH 3/3] of14: set default attributes for group-related classes

2014-04-15 Thread Yuichi Ito
Signed-off-by: Yuichi Ito --- ryu/ofproto/ofproto_v1_4_parser.py |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/ryu/ofproto/ofproto_v1_4_parser.py b/ryu/ofproto/ofproto_v1_4_parser.py index 230ac9e..618b676 100644 --- a/ryu/ofproto/ofproto_v1_4_parser.py +++ b/ryu

[Ryu-devel] [PATCH 2/3] of13: set default attributes for group-related classes

2014-04-15 Thread Yuichi Ito
Signed-off-by: Yuichi Ito --- ryu/ofproto/ofproto_v1_3_parser.py |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/ryu/ofproto/ofproto_v1_3_parser.py b/ryu/ofproto/ofproto_v1_3_parser.py index 38eeb1f..13bf385 100644 --- a/ryu/ofproto/ofproto_v1_3_parser.py +++ b/ryu

Re: [Ryu-devel] difference between ofp_event and event in RYU

2014-04-15 Thread FUJITA Tomonori
On Wed, 16 Apr 2014 10:04:24 +1200 Karthik Sharma wrote: > 1) If I were to attempt to build a database backed controller where the > database stores >1) topology information >2) flow table information > I could use the cached information to store the topology? Is m

Re: [Ryu-devel] difference between ofp_event and event in RYU

2014-04-15 Thread Karthik Sharma
Excellent!. 1) If I were to attempt to build a database backed controller where the database stores 1) topology information 2) flow table information I could use the cached information to store the topology? Is my understanding correct? 2) Can you point me to the dat

Re: [Ryu-devel] difference between ofp_event and event in RYU

2014-04-15 Thread FUJITA Tomonori
On Wed, 16 Apr 2014 09:45:48 +1200 Karthik Sharma wrote: > O.K.From where does topology application get the switch and link > information? > Does topology application inturn poll the switches via OpenFlow control > channel to get that information? > > Or does it pre-compute and store it (somewhe

Re: [Ryu-devel] difference between ofp_event and event in RYU

2014-04-15 Thread Karthik Sharma
O.K.From where does topology application get the switch and link information? Does topology application inturn poll the switches via OpenFlow control channel to get that information? Or does it pre-compute and store it (somewhere) if I run the application with $ sudo ryu-manager --observe-links r

Re: [Ryu-devel] difference between ofp_event and event in RYU

2014-04-15 Thread FUJITA Tomonori
Hey, On Wed, 16 Apr 2014 09:24:15 +1200 Karthik Sharma wrote: > I was looking at the RYU source code I came across two structures or > classes. > > 1) ofp_event which contains events such as > > - EventOFPHello > ​ - EventOFPSwitchFeatures >

[Ryu-devel] difference between ofp_event and event in RYU

2014-04-15 Thread Karthik Sharma
​Hi, I was looking at the RYU source code I came across two structures or classes. 1) ofp_event which contains events such as - EventOFPHello ​ - EventOFPSwitchFeatures - EventOFPPortDescStatsReply - EventOFPEchoRequest

[Ryu-devel] [PATCH] Rename to CONTRIBUTING.rst

2014-04-15 Thread FUJITA Tomonori
This makes the GitHub interface aware of the contribution guidelines, so it will be displayed to contributors when they submit issues or pull requests. Signed-off-by: FUJITA Tomonori --- CONTRIBUTING.rst | 88 +++ SubmittingPatches.rst | 88 --

Re: [Ryu-devel] [PATCH 0/7] use Ryu bgp packet library instead of original one

2014-04-15 Thread FUJITA Tomonori
On Tue, 15 Apr 2014 22:42:11 +0900 FUJITA Tomonori wrote: > On Tue, 15 Apr 2014 10:36:48 + > ISHIDA Wataru wrote: > >> ISHIDA Wataru (7): >> create bgp directory >> bgp: add IPv6 NLRI, VPNv6 NLRI and Route Target Membership NLRI for >> MPBGP >> bgp: improved packet lib for integra

Re: [Ryu-devel] [PATCH 0/7] use Ryu bgp packet library instead of original one

2014-04-15 Thread FUJITA Tomonori
On Tue, 15 Apr 2014 10:36:48 + ISHIDA Wataru wrote: > ISHIDA Wataru (7): > create bgp directory > bgp: add IPv6 NLRI, VPNv6 NLRI and Route Target Membership NLRI for > MPBGP > bgp: improved packet lib for integration with bgp speaker > bgp: add bgp exception class > bgp: use ryu

[Ryu-devel] [PATCH 7/7] bgp: fix pep8

2014-04-15 Thread ISHIDA Wataru
Signed-off-by: ISHIDA Wataru --- ryu/lib/packet/bgp/__init__.py | 40 ryu/lib/packet/bgp/exceptions.py | 29 +++--- ryu/services/protocols/bgp/api/core.py |4 +- ryu/services/protocols/bgp/api/rtconf.py

[Ryu-devel] [PATCH 2/7] bgp: add IPv6 NLRI, VPNv6 NLRI and Route Target Membership NLRI for MPBGP

2014-04-15 Thread ISHIDA Wataru
Signed-off-by: ISHIDA Wataru --- ryu/lib/packet/bgp/__init__.py | 146 ++-- 1 file changed, 139 insertions(+), 7 deletions(-) diff --git a/ryu/lib/packet/bgp/__init__.py b/ryu/lib/packet/bgp/__init__.py index 2d71917..50c9571 100644 --- a/ryu/lib/packet/bgp/_

[Ryu-devel] [PATCH 4/7] bgp: add bgp exception class

2014-04-15 Thread ISHIDA Wataru
Signed-off-by: ISHIDA Wataru --- ryu/lib/packet/bgp/__init__.py | 49 + ryu/lib/packet/bgp/exceptions.py | 417 ++ 2 files changed, 418 insertions(+), 48 deletions(-) create mode 100644 ryu/lib/packet/bgp/exceptions.py diff --git a/ryu/lib/packet/bg

[Ryu-devel] [PATCH 3/7] bgp: improved packet lib for integration with bgp speaker

2014-04-15 Thread ISHIDA Wataru
Signed-off-by: ISHIDA Wataru --- ryu/lib/packet/bgp/__init__.py | 131 +++- 1 file changed, 130 insertions(+), 1 deletion(-) diff --git a/ryu/lib/packet/bgp/__init__.py b/ryu/lib/packet/bgp/__init__.py index 50c9571..8a5907b 100644 --- a/ryu/lib/packet/bgp/__

[Ryu-devel] [PATCH 0/7] use Ryu bgp packet library instead of original one

2014-04-15 Thread ISHIDA Wataru
Subsequent patches remove dependencies on the bgp-speaker original packet library. Instead of the original packet library, now bgp-speaker uses Ryu bgp packet library. Though I've added some stuff to the Ryu bgp packet library in order to work with bgp-speaker, it’s API hasn't changed. ISHIDA Wa

Re: [Ryu-devel] Regarding the modification of header in controller messages.

2014-04-15 Thread Sarath Allaka
hi guys, actions=[] actions.append( OFPActionSetField(eth_dst="00:00:00:00:00:05")) actions.append(OFPActionSetField(ip_dst="10.0.0.2")) actions.append(datapath.ofproto_parser.OFPActionOutput(out_port)) hub: uncaught exception: Traceback (most recent call last): File "/home/ubuntu/ryu/ry

Re: [Ryu-devel] ryu.topology.api.get_all_switch(self) and ryu.topology.api.get_all_link(self) list - meaningful human readable display.

2014-04-15 Thread Karthik Sharma
Thanks.That worked. Is there another event (which gets messages when links are added or deleted ) where I can print this ? or read the topology? Also another question is that when I run $ sudo ryu-manager --observe-links ryu/app/simple_switch.py Does it calculate topology information on the fly?

Re: [Ryu-devel] ryu.topology.api.get_all_switch(self) and ryu.topology.api.get_all_link(self) list - meaningful human readable display.

2014-04-15 Thread YAMAMOTO Takashi
> I am running simple_switch.py in ryu/app/ folder with slight modification > and the output is given below.(The first occourance of output has been > expanded to make it more readable.) I want to make the contents of sw_list > and link_list more "human readable".Is there some nice display function

[Ryu-devel] ryu.topology.api.get_all_switch(self) and ryu.topology.api.get_all_link(self) list - meaningful human readable display.

2014-04-15 Thread Karthik Sharma
I am running simple_switch.py in ryu/app/ folder with slight modification and the output is given below.(The first occourance of output has been expanded to make it more readable.) I want to make the contents of sw_list and link_list more "human readable".Is there some nice display function that is

Re: [Ryu-devel] [PATCH 1/3] sw test tool: Fix to compare OFPMatch ignoring masks that are all one bits

2014-04-15 Thread FUJITA Tomonori
On Tue, 15 Apr 2014 14:52:39 +0900 Yuichi Ito wrote: > OF 1.3.3 spec (7.2.3.5 Flow Match Field Masking) says: > > An all-zero-bits oxm_mask is equivalent to omitting the OXM TLV entirely. > An all-one-bits oxm_mask > is equivalent to specifying 0 for oxm_hasmask and omitting oxm_mask. >