[Ryu-devel] [PATCH 0/9] tests/integrated: Update OF1.2 action tests

2014-04-24 Thread Simon Horman
Hi, while testing the "make check-ryu" target provided by Open vSwitch I observed that some action tests seem to fail because of enforcement of portions of the OpenFlow1.2 specification by Open vSwitch. I also noticed that several tests that are disabled may be enabled, in some cases after minor

[Ryu-devel] [PATCH 4/9] tests/integrated: Match on IP dl_type for flows with set NW TTL actions

2014-04-24 Thread Simon Horman
OpenFlow 1.2 section 6.7 describes inconsistent action in a flow as an action whose operation is inconsistent with the flows match. In terms of the above the set NW TTL action is inconsistent if it the flow does not match on the IPv4 or IPv6 dl_type because the action manipulates either the IPv4 T

[Ryu-devel] [PATCH 6/9] tests/integrated: Match on IP dl_type for flows with set IPv6 addresses

2014-04-24 Thread Simon Horman
OpenFlow 1.2 section 6.7 describes inconsistent action in a flow as an action whose operation is inconsistent with the flows match. In terms of the above the set-field actions for IPv6 addresses are inconsistent if it the flow does not match on the IPv6 dl_type. This patch add such a match for th

[Ryu-devel] [PATCH 7/9] tests/integrated: Match on MPLS dl_type for flows with pop MPLS actions

2014-04-24 Thread Simon Horman
OpenFlow 1.2 section 6.7 describes inconsistent action in a flow as an action whose operation is inconsistent with the flows match. In terms of the above pop MPLS actions are inconsistent if the flow does not match on one of the MPLS dl_types. This patch add such a match for the flow that has a p

[Ryu-devel] [PATCH 5/9] tests/integrated: Enable ARP tests

2014-04-24 Thread Simon Horman
Enable ARP tests, they appear to be supported by Open vSwitch. I noticed this when using Open vSwitch's "make ryu-check" as Open vSwitch enforces action consistency for the set NW TTL action. Signed-off-by: Simon Horman --- ryu/tests/integrated/test_add_flow_v12_actions.py | 1 - 1 file changed

[Ryu-devel] [PATCH 9/9] tests/integrated: Enable MPLS set-field and push MPLS tests

2014-04-24 Thread Simon Horman
Enable disabled MPLS tests, they appear to be supported by Open vSwitch. I noticed this when using Open vSwitch's "make ryu-check" as Open vSwitch enforces action consistency for the set NW TTL action. Signed-off-by: Simon Horman --- ryu/tests/integrated/test_add_flow_v12_actions.py | 5 +

[Ryu-devel] [PATCH 2/9] tests/integrated: Match on VLAN tag for flows with pop VLAN TTL actions

2014-04-24 Thread Simon Horman
OpenFlow 1.2 section 6.7 describes inconsistent action in a flow as an action whose operation is inconsistent with the flows match. In terms of the above the pop ttl action is considered inconsistent if it the flow does not match on a VLAN tag. This patch add such a match for the flow that has a

[Ryu-devel] [PATCH 3/9] tests/integrated: Match on VLAN tag for flows which set VLAN tags

2014-04-24 Thread Simon Horman
OpenFlow 1.2 section 6.7 describes inconsistent action in a flow as an action whose operation is inconsistent with the flows match. In terms of the above a set-field action for a VLAN tag is considered inconsistent if it the flow does not match on a VLAN tag. This patch add such a match for the f

[Ryu-devel] [PATCH 1/9] tests/integrated: Match on IP dl_type for flows with dec NW TTL actions

2014-04-24 Thread Simon Horman
OpenFlow 1.2 section 6.7 describes inconsistent action in a flow as an action whose operation is inconsistent with the flows match. In terms of the above the dec NW TTL action is inconsistent if it the flow does not match on the IPv4 or IPv6 dl_type because the action manipulates either the IPv4 T

[Ryu-devel] [PATCH 8/9] tests/integrated: Match on MPLS dl_type for flows with MPLS TTL actions

2014-04-24 Thread Simon Horman
OpenFlow 1.2 section 6.7 describes inconsistent action in a flow as an action whose operation is inconsistent with the flows match. In terms of the above MPLS TTL actions are inconsistent if the flow does not match on one of the MPLS dl_types. This patch add such a match for the flows that have M

Re: [Ryu-devel] [PATCH v2] tests/integrated: Use max_len=OFPCML_NO_BUFFER to prevent buffer allocation

2014-04-24 Thread Simon Horman
On Thu, Apr 24, 2014 at 05:37:45PM +0900, YAMAMOTO Takashi wrote: > > If the buffer_id of a message received by a controller is -1 (0x) > > then no buffer is used by that message. In this case the controller may > > allocate a buffer for use by resulting packet_in messages unless the > > m

[Ryu-devel] [PATCH] tests/integrated: Do not verify buffer_id of packet_in resulting from packet_out

2014-04-24 Thread Simon Horman
When a packet_in message results from a packet_out message there is no particular relationship between the buffer_ids of the two messages. I noticed this when using Open vSwitch's "make ryu-check". YAMAMOTO Takashi Signed-off-by: Simon Horman --- Thanks to Yamamoto-san to suggesting a simple

Re: [Ryu-devel] Topology representation in RYU controller

2014-04-24 Thread Karthik Sharma
Thanks for the explanation.I have one more query I have added the following code to the packet_in event handler of simple_switch.py to print out the topology (The new code is highlighted in red.) to get the topology information from RYU.

Re: [Ryu-devel] How to contribute

2014-04-24 Thread Lorenzo Mainardi
I already know this article and I think it's very interesting. It could be a good point to start to play with. There is some code to start reading? 2014-04-24 23:09 GMT+02:00 FUJITA Tomonori : > On Thu, 24 Apr 2014 23:10:03 +0200 > Lorenzo Mainardi wrote: > >> For security I thought to make some

Re: [Ryu-devel] How to contribute

2014-04-24 Thread FUJITA Tomonori
On Thu, 24 Apr 2014 23:10:03 +0200 Lorenzo Mainardi wrote: > For security I thought to make some portscanner detector can could > also "blackhole" for limited time the traffic. Yeah, detecting some malicious activity and handling such dynamically sounds a nice SDN use case. The following was ve

Re: [Ryu-devel] How to contribute

2014-04-24 Thread Lorenzo Mainardi
For security I thought to make some portscanner detector can could also "blackhole" for limited time the traffic. For QoS maybe something like shaping (maybe for a group VLAN like Cisco 3600ME does). Do you have any other ideas or open issue? 2014-04-24 23:00 GMT+02:00 FUJITA Tomonori : > Hi, > >

Re: [Ryu-devel] How to contribute

2014-04-24 Thread FUJITA Tomonori
Hi, On Mon, 21 Apr 2014 15:05:22 +0200 Lorenzo Mainardi wrote: > Hi Fujita, I'm interested on something QoS related or some about security. I think that both areas have seveal SDN use cases. Do you have a specific use case in your mind? -

[Ryu-devel] set nw_tos field and use it for flow rules

2014-04-24 Thread Windhya Rankothge
Hi all, I want to set nw_tos field of pakcets coming from a specific host. I am using Ryu REST API and is there something similar to "actions":[{' + '"type":"SET_VLAN_VID","vlan_vid": 1"}] to do this ? Best Regards, Windhya Rankothge, Universitat Pompeu Fabra, Barcelona. ---

Re: [Ryu-devel] Regarding the modification of header in controller messages.

2014-04-24 Thread Sarath Allaka
I am using OF1.3 then I am geetting the following error : actions=[] actions.append( OFPActionSetField(eth_dst="00:00:00:00:00:05")) actions.append(OFPActionSetField(ip_dst="10.0.0.2")) File "/home/ubuntu/ryu/ryu/lib/hub.py", line 48, in _launch func(*args, **kwargs) File "/home/ubuntu/ryu/

Re: [Ryu-devel] [PATCH] sw test tool: Modify lengths of pad fields for ARP

2014-04-24 Thread FUJITA Tomonori
On Thu, 24 Apr 2014 16:41:56 +0900 Yuichi Ito wrote: > Wireshark may misunderstand a MAC frame (including ARP) whose length is 64 > bytes or more, as a frame with the FCS field. > This patch fixes the issue by modifying lengths of pad fields for ARP. > > Reported-by: Arne Goetje > Signed-off-b

Re: [Ryu-devel] [PATCH 0/2] tests/integrated: Adjust tests to follow OpenFlow1.2

2014-04-24 Thread FUJITA Tomonori
On Thu, 24 Apr 2014 09:39:31 +0900 Simon Horman wrote: > Hi, > > while testing the "make check-ryu" target provided by Open vSwtich > I observed that some tests seem to fail because of enforcement > of portions of the OpenFlow1.2 specification by Open vSwtich. > > This short series attempts to

Re: [Ryu-devel] [PATCH] sw test tool: Fix MAC addresses used in tests

2014-04-24 Thread FUJITA Tomonori
On Thu, 24 Apr 2014 10:45:08 +0900 Yuichi Ito wrote: > IEEE 802.3-2012 (3.2.3 Address fields) says: > > b) The first bit (LSB) shall be used in the Destination Address field as an > address type designation bit > to identify the Destination Address either as an individual or as a group >

Re: [Ryu-devel] [PATCH] packet lib: ipv6: support Routing header (type3)

2014-04-24 Thread FUJITA Tomonori
On Thu, 24 Apr 2014 15:35:18 +0900 "takahashi.minoru" wrote: > Signed-off-by: TAKAHASHI Minoru > --- > ryu/lib/packet/ipv6.py | 159 +- > ryu/tests/unit/packet/test_ipv6.py | 319 > > 2 files changed, 476 insertions(+), 2 delet

Re: [Ryu-devel] [PATCH v2] tests/integrated: Use max_len=OFPCML_NO_BUFFER to prevent buffer allocation

2014-04-24 Thread YAMAMOTO Takashi
> If the buffer_id of a message received by a controller is -1 (0x) > then no buffer is used by that message. In this case the controller may > allocate a buffer for use by resulting packet_in messages unless the > max_len of output action that causes the packet_in message is > OFPCML_NO_B

[Ryu-devel] [PATCH v2] tests/integrated: Use max_len=OFPCML_NO_BUFFER to prevent buffer allocation

2014-04-24 Thread Simon Horman
If the buffer_id of a message received by a controller is -1 (0x) then no buffer is used by that message. In this case the controller may allocate a buffer for use by resulting packet_in messages unless the max_len of output action that causes the packet_in message is OFPCML_NO_BUFFER (0xf

[Ryu-devel] [PATCH] sw test tool: Fix test files

2014-04-24 Thread Yuichi Ito
This patch is after Fixing-MAC-addresses patch. Yuichi Ito (1): sw test tool: Modify lengths of pad fields for ARP ryu/tests/switch/of13/action/00_OUTPUT.json|4 +- ryu/tests/switch/of13/action/15_SET_MPLS_TTL.json |4 +- ryu/tests/switch/of13/action/16_DEC_MPLS_TTL.json |