Re: [Ryu-devel] [PATCH 1/2] Implement host discovery in ryu.topology

2015-06-10 Thread Yi Tseng
Hi Sorry that I forgot to remove comment (# this type is used for key value of LinkState) in class Host (I copied class Link and modify it) Should I send a new patch ? 2015-06-11 13:08 GMT+08:00 Yi Tseng : > Hi > > I didn't concern that host can be configured to send lldp packets. > > If a ho

Re: [Ryu-devel] [PATCH 1/2] Implement host discovery in ryu.topology

2015-06-10 Thread Yi Tseng
Hi I think the mac address are unique in computer networks. So I only compare mac address between hosts. 2015-06-11 12:33 GMT+08:00 IWAMOTO Toshihiro : > At Thu, 11 Jun 2015 02:30:40 +0800, > Yi Tseng wrote: > > > > Signed-off-by: Takeshi > > --- > > ryu/topology/api.py | 7 + > >

Re: [Ryu-devel] [PATCH 1/2] Implement host discovery in ryu.topology

2015-06-10 Thread Yi Tseng
Hi I didn't concern that host can be configured to send lldp packets. If a host can be configured to send lldp packet, there will be two situations: 1. Host always send lldp packets : ryu can't discover that host. 2. Host not always send lldp packet, sometimes it send normal packet : ryu can di

Re: [Ryu-devel] [PATCH 1/2] Implement host discovery in ryu.topology

2015-06-10 Thread IWAMOTO Toshihiro
At Thu, 11 Jun 2015 02:30:40 +0800, Yi Tseng wrote: > > Signed-off-by: Takeshi > --- > ryu/topology/api.py | 7 + > ryu/topology/event.py| 23 + > ryu/topology/switches.py | 66 > +++- > 3 files changed, 95 insertions(+),

Re: [Ryu-devel] How does ryu name port in the switch

2015-06-10 Thread Vinllen Chen
Thankyou verymuch! On Thu, Jun 11, 2015 at 8:02 AM, Yusuke Iwase wrote: > Hi, > > On 2015年06月10日 18:03, Vinllen Chen wrote: > > Sorry for ambiguous question. The hardware switch have 8 ports, but only > 4 of them is up which means connect to other hosts or switches. The port > used in the hardwa

Re: [Ryu-devel] How does ryu name port in the switch

2015-06-10 Thread Yusuke Iwase
Hi, On 2015年06月10日 18:03, Vinllen Chen wrote: > Sorry for ambiguous question. The hardware switch have 8 ports, but only 4 of > them is up which means connect to other hosts or switches. The port used in > the hardware switch is 1, 2, 7, my question is which "port id" will the > ryu-controller

Re: [Ryu-devel] [PATCH 1/2] Implement host discovery in ryu.topology

2015-06-10 Thread FUJITA Tomonori
Thanks for the new feature! This assumes that if something sends non lldp packets, then it is a 'host', rigth? One concern is that a host, for example, windows, can be configured to send lldp packets. Thought? Even if the above false identificatoin could happen, I'm ok with the patches. There is

[Ryu-devel] [PATCH 1/2] Implement host discovery in ryu.topology

2015-06-10 Thread Yi Tseng
Signed-off-by: Takeshi --- ryu/topology/api.py | 7 + ryu/topology/event.py| 23 + ryu/topology/switches.py | 66 +++- 3 files changed, 95 insertions(+), 1 deletion(-) diff --git a/ryu/topology/api.py b/ryu/topology/api.py

[Ryu-devel] [PATCH 2/2] Implement "get host" and "list host" RESTful api

2015-06-10 Thread Yi Tseng
Signed-off-by: Takeshi --- ryu/app/rest_topology.py | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/ryu/app/rest_topology.py b/ryu/app/rest_topology.py index 5eed243..9cc2485 100644 --- a/ryu/app/rest_topology.py +++ b/ryu/app/rest_topology.py @@ -19,7 +

Re: [Ryu-devel] How does ryu name port in the switch

2015-06-10 Thread Vinllen Chen
Sorry for ambiguous question. The hardware switch have 8 ports, but only 4 of them is up which means connect to other hosts or switches. The port used in the hardware switch is 1, 2, 7, my question is which "port id" will the ryu-controller get from the mapping from switch port, does it use the fol

Re: [Ryu-devel] How does ryu name port in the switch

2015-06-10 Thread Yusuke Iwase
Hi, On 2015年06月09日 21:57, Vinllen Chen wrote: > Hi, Dear all: > > I have a hardware switch which has eight ports name from g1 g2 g3 ... g8, > i use g1 g3 g7 to connect to other switch or host, and then connect g8 to ryu > controller. My question is which name will the ryu controller mark th