Re: [Ryu-devel] Problem of BGPSpeaker in v3.22

2015-06-29 Thread Toshiki Tsuboi
Hi, Thanks for providing Patch file. After providing Patch, a previous issue has not occurred any more. But, it looks another issue has been observed when "show vrf command” or “show rib vpnv4” has been executed in manual. — Traceback DEBUG 2015-06-28 00:37:22,114 net_ctrl 199 NetworkContr

Re: [Ryu-devel] Learning topology on RYU

2015-06-29 Thread Yusuke Iwase
Hi, On 2015年06月30日 02:24, Mehrdad Moradi wrote: > Hi All, > > I am new to RYU and would like to perform the learn the topology and then > compute multiple non-shortest paths between any switch port pairs. Where is > the best point to start? Are you aware of any example for this? To get the top

Re: [Ryu-devel] [PATCH] python3: Don't use str.encode

2015-06-29 Thread fumihiko kakuma
IWAMOTO, thank you for fix to my patch. On Mon, 29 Jun 2015 20:03:13 +0900 IWAMOTO Toshihiro wrote: > This commit partially reverts b48fedc7295cb0c9c3fe62fc2d2f124b7fc739f8. > This kind of change complicates assertion checks below. > > Signed-off-by: IWAMOTO Toshihiro > --- > ryu/tests/unit/

[Ryu-devel] Learning topology on RYU

2015-06-29 Thread Mehrdad Moradi
Hi All, I am new to RYU and would like to perform the learn the topology and then compute multiple non-shortest paths between any switch port pairs. Where is the best point to start? Are you aware of any example for this? Best Regards, ---Mehrdad Mehrdad Moradi ---

Re: [Ryu-devel] Problem of BGPSpeaker in v3.22

2015-06-29 Thread FUJITA Tomonori
On Sun, 28 Jun 2015 06:12:46 +0900 Toshiki Tsuboi wrote: > Hi > > It looks BGPSpeaker does’t work under the latest version (v3.22). > I guess this issue has produced because of the following patch > > https://github.com/osrg/ryu/commit/c0590ea903d1fbe40a22e04970d5a8a7e489aa44 >

Re: [Ryu-devel] [PATCH 0/3] More python3 stuff

2015-06-29 Thread FUJITA Tomonori
On Mon, 29 Jun 2015 19:51:10 +0900 IWAMOTO Toshihiro wrote: > These should be applied after recent Kakuma's patchset 2, 3 and 4. > > IWAMOTO Toshihiro (3): > python3: More b'str' conversion > python3: Decode return value of b64encode into str > python3: Remove harmful AsciiStringType.{enco

Re: [Ryu-devel] [PATCH] python3: Don't use str.encode

2015-06-29 Thread FUJITA Tomonori
On Mon, 29 Jun 2015 20:03:13 +0900 IWAMOTO Toshihiro wrote: > This commit partially reverts b48fedc7295cb0c9c3fe62fc2d2f124b7fc739f8. > This kind of change complicates assertion checks below. > > Signed-off-by: IWAMOTO Toshihiro > --- > ryu/tests/unit/ofproto/test_parser_v10.py | 4 ++-- > 1 f

Re: [Ryu-devel] [PATCH 0/4] python3: resend my last patches

2015-06-29 Thread FUJITA Tomonori
On Mon, 29 Jun 2015 16:00:55 +0900 fumihiko kakuma wrote: > I modified some codes pointed by iwamoto. > > fumihiko kakuma (4): > python3: fix odd calling of encode() method > python3: Modify a literal argument in a bytes method call to bytes > type > python3: encode from string to byte

[Ryu-devel] [PATCH] python3: Don't use str.encode

2015-06-29 Thread IWAMOTO Toshihiro
This commit partially reverts b48fedc7295cb0c9c3fe62fc2d2f124b7fc739f8. This kind of change complicates assertion checks below. Signed-off-by: IWAMOTO Toshihiro --- ryu/tests/unit/ofproto/test_parser_v10.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ryu/tests/unit/of

[Ryu-devel] [PATCH 3/3] python3: Remove harmful AsciiStringType.{encode, decode}

2015-06-29 Thread IWAMOTO Toshihiro
Signed-off-by: IWAMOTO Toshihiro --- ryu/lib/stringify.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ryu/lib/stringify.py b/ryu/lib/stringify.py index 8a865b7..5d22979 100644 --- a/ryu/lib/stringify.py +++ b/ryu/lib/stringify.py @@ -85,14 +85,14 @@ class NXFlowSpecFie

[Ryu-devel] [PATCH 2/3] python3: Decode return value of b64encode into str

2015-06-29 Thread IWAMOTO Toshihiro
b64encode is mainly used to encode binary data into JSON. As binary_type isn't JSON serializable in python3, it makes more sense to convert to binary_type early. Also, allow text_type to be base64 encoded. Signed-off-by: IWAMOTO Toshihiro --- ryu/lib/stringify.py | 4 ryu/lib/type_desc.py

[Ryu-devel] [PATCH 1/3] python3: More b'str' conversion

2015-06-29 Thread IWAMOTO Toshihiro
Some test data look like human readable strings, but the data that directly appear on-wire should be defined as binary_type from first place. Signed-off-by: IWAMOTO Toshihiro --- ryu/ofproto/ofproto_v1_0_parser.py | 6 +-- ryu/ofproto/ofproto_v1_3_parser.py | 2 +- ryu/tests/

[Ryu-devel] [PATCH 0/3] More python3 stuff

2015-06-29 Thread IWAMOTO Toshihiro
These should be applied after recent Kakuma's patchset 2, 3 and 4. IWAMOTO Toshihiro (3): python3: More b'str' conversion python3: Decode return value of b64encode into str python3: Remove harmful AsciiStringType.{encode,decode} ryu/lib/stringify.py| 8 +++- ryu/li

Re: [Ryu-devel] [PATCH 1/4] python3: fix odd calling of encode() method

2015-06-29 Thread FUJITA Tomonori
On Mon, 29 Jun 2015 19:19:48 +0900 IWAMOTO Toshihiro wrote: > At Mon, 29 Jun 2015 16:00:56 +0900, > fumihiko kakuma wrote: >> >> Signed-off-by: Fumihiko Kakuma >> --- >> ryu/tests/unit/ofproto/test_parser_v10.py | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/r

Re: [Ryu-devel] [PATCH 1/4] python3: fix odd calling of encode() method

2015-06-29 Thread IWAMOTO Toshihiro
At Mon, 29 Jun 2015 16:00:56 +0900, fumihiko kakuma wrote: > > Signed-off-by: Fumihiko Kakuma > --- > ryu/tests/unit/ofproto/test_parser_v10.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/ryu/tests/unit/ofproto/test_parser_v10.py > b/ryu/tests/unit/ofproto/test

Re: [Ryu-devel] [Patch3/4] Add support for the Nicira extension packet mark

2015-06-29 Thread IWAMOTO Toshihiro
At Thu, 18 Jun 2015 06:13:12 -0700, Eran Gampel wrote: > > [1 ] > [1.1 ] > Hi, > Please see attached patch with your comments resolved. > > I think I will need some guidelines on how to add unitest if necessary Yeah, developer docs for adding unit tests is certainly missing. The easiest way is

[Ryu-devel] [PATCH 3/4] python3: encode from string to bytes for s type of pack format

2015-06-29 Thread fumihiko kakuma
Signed-off-by: Fumihiko Kakuma --- ryu/tests/unit/ofproto/test_parser_v12.py | 17 - ryu/tests/unit/packet/test_slow.py| 4 ++-- 2 files changed, 10 insertions(+), 11 deletions(-) diff --git a/ryu/tests/unit/ofproto/test_parser_v12.py b/ryu/tests/unit/ofproto/test_parse

[Ryu-devel] [PATCH 2/4] python3: Modify a literal argument in a bytes method call to bytes type

2015-06-29 Thread fumihiko kakuma
Signed-off-by: Fumihiko Kakuma --- ryu/ofproto/ofproto_v1_2_parser.py| 6 +++--- ryu/tests/unit/ofproto/test_parser_v12.py | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/ryu/ofproto/ofproto_v1_2_parser.py b/ryu/ofproto/ofproto_v1_2_parser.py index 7ecce12..b528181

[Ryu-devel] [PATCH 4/4] python3: Calculate the number of ports as integer

2015-06-29 Thread fumihiko kakuma
Signed-off-by: Fumihiko Kakuma --- ryu/ofproto/ofproto_v1_0_parser.py | 2 +- ryu/ofproto/ofproto_v1_2_parser.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ryu/ofproto/ofproto_v1_0_parser.py b/ryu/ofproto/ofproto_v1_0_parser.py index 1582a69..e077a17 100644 --- a/ryu/

[Ryu-devel] [PATCH 0/4] python3: resend my last patches

2015-06-29 Thread fumihiko kakuma
I modified some codes pointed by iwamoto. fumihiko kakuma (4): python3: fix odd calling of encode() method python3: Modify a literal argument in a bytes method call to bytes type python3: encode from string to bytes for s type of pack format python3: Calculate the number of ports as in

[Ryu-devel] [PATCH 1/4] python3: fix odd calling of encode() method

2015-06-29 Thread fumihiko kakuma
Signed-off-by: Fumihiko Kakuma --- ryu/tests/unit/ofproto/test_parser_v10.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ryu/tests/unit/ofproto/test_parser_v10.py b/ryu/tests/unit/ofproto/test_parser_v10.py index 3d2539b..7326d7e 100644 --- a/ryu/tests/unit/ofproto/te