Re: [Ryu-devel] Heads up, re: OFPFC_ADD...

2016-01-31 Thread IWAMOTO Toshihiro
At Mon, 1 Feb 2016 01:02:48 +, Victor Orlikowski wrote: > > Folks, > > We ran into a fun time debugging an issue w/ one of our switch vendors, and I > wanted to share it, since some of the sample applications make use of the > same functionality. Thanks for a nice heads up. > The control

[Ryu-devel] [PATCH 0/3] Implement conntrack NAT action

2016-01-31 Thread IWAMOTO Toshihiro
The following patches are for NAT action and its tests for the Nicira extension, which has been merged into the ovs repository recently. IWAMOTO Toshihiro (3): Implement NXActionNAT packet_data_generator3: add a couple of conntrack packets test_parser: add conntrack NAT tests ryu/ofproto/n

[Ryu-devel] [PATCH 1/3] Implement NXActionNAT

2016-01-31 Thread IWAMOTO Toshihiro
This action is for the conntrack Nicira extension. Signed-off-by: IWAMOTO Toshihiro --- ryu/ofproto/nicira_ext.py | 9 ryu/ofproto/nx_actions.py | 111 ++ 2 files changed, 120 insertions(+) diff --git a/ryu/ofproto/nicira_ext.py b/ryu/ofproto/n

[Ryu-devel] [PATCH 3/3] test_parser: add conntrack NAT tests

2016-01-31 Thread IWAMOTO Toshihiro
Signed-off-by: IWAMOTO Toshihiro --- .../of13/ovs-ofctl-of13-action_ct_nat.packet | Bin 0 -> 128 bytes .../of13/ovs-ofctl-of13-action_ct_nat_v6.packet| Bin 0 -> 144 bytes .../of13/ovs-ofctl-of13-action_ct_nat.packet.json | 71 + .../ovs-ofctl-of13-action_ct_nat_v

[Ryu-devel] [PATCH 2/3] packet_data_generator3: add a couple of conntrack packets

2016-01-31 Thread IWAMOTO Toshihiro
Signed-off-by: IWAMOTO Toshihiro --- ryu/tests/packet_data_generator3/gen.py | 14 ++ 1 file changed, 14 insertions(+) diff --git a/ryu/tests/packet_data_generator3/gen.py b/ryu/tests/packet_data_generator3/gen.py index 294efee..6a7dd71 100644 --- a/ryu/tests/packet_data_generator3/

[Ryu-devel] [PATCH] Update conntrack test json and binary packets

2016-01-31 Thread IWAMOTO Toshihiro
Ovs has changed the definition of conntrack flags in commit 63bc9fb1c69fa81f3b30c2669d25962da3119d0f, and packet_data_generator3 now generates different test data. Update the data and corresponding json data accordingly. Signed-off-by: IWAMOTO Toshihiro --- .../packet_data/of13/ovs-ofctl-of13-a

Re: [Ryu-devel] Drop Python 2.6 support

2016-01-31 Thread IWAMOTO Toshihiro
At Sat, 30 Jan 2016 22:50:47 +0900 (JST), FUJITA Tomonori wrote: > > Hi, > > I plan to drop python 2.6 support at this March release. This will also enable us to remove some minor python2.6 compatibility stuff and simplify the code, such as commit 79ad56e682b32ccce4755e129da8c8023a3d9bb5. -- IW

[Ryu-devel] Heads up, re: OFPFC_ADD...

2016-01-31 Thread Victor Orlikowski
Folks, We ran into a fun time debugging an issue w/ one of our switch vendors, and I wanted to share it, since some of the sample applications make use of the same functionality. The controller application that we are developing (based off of rest_router) was seeing PacketIn storms related to

Re: [Ryu-devel] [PATCH v3] Ensure that usage of icmp.dest_unreach and icmp.TimeExceeded in rest_router.py complies with RFC 4884

2016-01-31 Thread FUJITA Tomonori
On Sun, 31 Jan 2016 14:36:45 + Victor Orlikowski wrote: > Correcting a PEP8 violation, per Fujita-San's request. > > When using the icmp.dest_unreach and icmp.TimeExceeded classes, we should > ensure that it is in compliance with RFC 4884. > As such, the data_len parameter passed to the con

[Ryu-devel] [PATCH] Stability improvements to the core of Ryu, without requiring user application changes

2016-01-31 Thread Victor Orlikowski
Per Fujita-San's request, the echo request loop is off by default. It is easily enabled by setting the "maximum-unreplied-echo-requests" configuration option to a non-zero value. Signed-off-by: Victor J. Orlikowski diff --git a/ryu/base/app_manager.py b/ryu/base/app_manager.py index 3d5d895..ea

Re: [Ryu-devel] [PATCH] Stability improvements to the core of Ryu, without requiring user application changes

2016-01-31 Thread Victor Orlikowski
On Jan 31, 2016, at 7:33 AM, FUJITA Tomonori wrote: > > I think that implementing echo requests to find a dead datapath is > great. But disabling the feature by default is better (safer). I would > not be so surprised if there are some broken switches which don't > reply to echo requests. My apo

[Ryu-devel] [PATCH v3] Ensure that usage of icmp.dest_unreach and icmp.TimeExceeded in rest_router.py complies with RFC 4884

2016-01-31 Thread Victor Orlikowski
Correcting a PEP8 violation, per Fujita-San's request. When using the icmp.dest_unreach and icmp.TimeExceeded classes, we should ensure that it is in compliance with RFC 4884. As such, the data_len parameter passed to the constructor of each should be interpreted in 32 bit units. Furthermore - a

Re: [Ryu-devel] [PATCH v2] Ensure that usage of icmp.dest_unreach and icmp.TimeExceeded in rest_router.py complies with RFC 4884

2016-01-31 Thread Victor Orlikowski
On Jan 31, 2016, at 9:13 AM, FUJITA Tomonori wrote: > > Thanks, I see. Then only one problem remains, the following pep8 error: > > ./ryu/app/rest_router.py:1547:45: E226 missing whitespace around arithmetic > operator > ERROR: InvocationError: '/home/travis/build/fujita/ryu/.tox/pep8/bin/pep8'

Re: [Ryu-devel] [PATCH v2] Ensure that usage of icmp.dest_unreach and icmp.TimeExceeded in rest_router.py complies with RFC 4884

2016-01-31 Thread FUJITA Tomonori
On Sun, 31 Jan 2016 14:19:45 + Victor Orlikowski wrote: > On Jan 31, 2016, at 7:56 AM, FUJITA Tomonori wrote: >> >> The above behavior works with others (OSes, switches, etc)? As you >> pointed out, the current code looks broken w.r.t. the original >> datagram but it works? > > The IP stac

Re: [Ryu-devel] [PATCH] Stability improvements to the core of Ryu, without requiring user application changes

2016-01-31 Thread Victor Orlikowski
On Jan 31, 2016, at 7:33 AM, FUJITA Tomonori wrote: > > Why we need semaphore for getting from /putting to a queue? I discovered, in testing, that eventlet synchronized queues are broken with respect to synchronization. They have missed wakeup problems that lead to them not consuming events pr

Re: [Ryu-devel] [PATCH v2] Ensure that usage of icmp.dest_unreach and icmp.TimeExceeded in rest_router.py complies with RFC 4884

2016-01-31 Thread Victor Orlikowski
On Jan 31, 2016, at 7:56 AM, FUJITA Tomonori wrote: > > The above behavior works with others (OSes, switches, etc)? As you > pointed out, the current code looks broken w.r.t. the original > datagram but it works? The IP stack on most OSes is liberal in what it will accept. Yes - the current code

Re: [Ryu-devel] [PATCH v2] Ensure that usage of icmp.dest_unreach and icmp.TimeExceeded in rest_router.py complies with RFC 4884

2016-01-31 Thread FUJITA Tomonori
On Sat, 30 Jan 2016 15:50:49 + Victor Orlikowski wrote: > Sigh. Brown paper bag re-submit, to cover an "off-by-one." > > When using the icmp.dest_unreach and icmp.TimeExceeded classes, we should > ensure that it is in compliance with RFC 4884. > As such, the data_len parameter passed to the

Re: [Ryu-devel] [PATCH] Stability improvements to the core of Ryu, without requiring user application changes

2016-01-31 Thread FUJITA Tomonori
On Wed, 27 Jan 2016 05:38:29 + Victor Orlikowski wrote: > Per Iwase-San’s request, here is a re-worked stabilty patch that > does *not* require patching user applications. Make sense, I think. I really want to avoid affecting the existing applications. > Instead, the Datapath class grows a

Re: [Ryu-devel] install ryu in debian 8.0

2016-01-31 Thread FUJITA Tomonori
On Sun, 31 Jan 2016 10:40:38 +0330 "mehran shetabi" wrote: > i want to install ryu from the source code in debian 8.0 , but i got this > error: > error in ryu setup command: Invalid environment marker: (python_version >= > '2.7') > how can i fix it? There are two options: a) update pip versio