Re: [Ryu-devel] Match on ttl

2016-09-28 Thread FUJITA Tomonori
On Tue, 27 Sep 2016 09:12:27 +0900 Iwase Yusuke wrote: > Hi, > > Thank you for submitting your patch. We very welcome your contributing! > You can add your code to Ryu by sending your patch to this mailing list. > > https://github.com/osrg/ryu/blob/master/CONTRIBUTING.rst#submitting-a-change

Re: [Ryu-devel] [PATCH] ofproto/ofproto_v1_5_parser: OFPMultipartReply malformed message offset fix

2016-09-28 Thread FUJITA Tomonori
On Tue, 27 Sep 2016 11:19:21 +0200 Michał Rzepka wrote: > Recently, I discovered major multipart message parser flaw. The issue > was observed while testing Aggregate Flow Statistics message in OpenFlow > 1.5 and Open vSwitch. Similar (and potentially also vulnerable) code > snippets are also

Re: [Ryu-devel] [PATCH] ofproto/ofproto_v1_5_parser: OFPMultipartReply malformed message offset fix

2016-09-28 Thread IWAMOTO Toshihiro
At Tue, 27 Sep 2016 12:43:51 -0400, Victor J. Orlikowski wrote: > > On Tue, Sep 27, 2016, at 05:19 AM, Michał Rzepka > wrote: > > Recently, I discovered major multipart message parser flaw. The issue > > was observed while testing Aggregate Flow Statistics message in OpenFlow > > 1.5 and Open

Re: [Ryu-devel] Match on ttl

2016-09-28 Thread Iwase Yusuke
Hi Fujita-San, Either is fine. Because now we are testing the patch for the other missing OXMs including NXM_NX_IP_TTL. We will post it in a few days. Thanks, Iwase On 2016年09月28日 16:24, FUJITA Tomonori wrote: > On Tue, 27 Sep 2016 09:12:27 +0900 > Iwase Yusuke wrote: > >> Hi, >> >> Thank you

Re: [Ryu-devel] Match on ttl

2016-09-28 Thread Sugrim, Shridatt
Hello All, Thanks for taking the time to look into this. I will submit a patch later today, it's literally a one line change. I was looking into the OF1.3 spec and if I understand this correctly, I can't mix and match oxm and nxm fields because of the experimenter flag at the beginning of the O

Re: [Ryu-devel] [RYU-DEVEL] - Getting flow entries length

2016-09-28 Thread Túlio Pascoal
To who it may concern, The problem was really in the Ryu version I was using (3.6). When I upgraded to version 4.6 I could normally get length of the entries. Regards, -- Túlio Albuquerque Pascoal

Re: [Ryu-devel] Upgrading Ryu

2016-09-28 Thread Túlio Pascoal
To whom it may concern, Yes Iwase, the problem was in the virtual machine you cited and I was using (OpenFlow Tutorial VM images). I installed Ryu by myself in another newer virtual machine and I could upgrade it seamlessly. Regards, -- Túlio Albuquerque Pascoal

Re: [Ryu-devel] Upgrading Ryu

2016-09-28 Thread Victor J. Orlikowski
On Wed, Sep 28, 2016, at 06:58 PM, Túlio Pascoal wrote: > To whom it may concern, > > Yes Iwase, the problem was in the virtual machine you cited and I was using > (OpenFlow Tutorial VM images). > > I installed Ryu by myself in another newer virtual machine and I could > upgrade it seamlessly. >

Re: [Ryu-devel] [PATCH] ofproto/ofproto_v1_5_parser: OFPMultipartReply malformed message offset fix

2016-09-28 Thread IWAMOTO Toshihiro
At Wed, 28 Sep 2016 17:02:30 +0900, IWAMOTO Toshihiro wrote: > > At Tue, 27 Sep 2016 12:43:51 -0400, > Victor J. Orlikowski wrote: > > > > On Tue, Sep 27, 2016, at 05:19 AM, Michał Rzepka > > wrote: > > > Recently, I discovered major multipart message parser flaw. The issue > > > was observed

Re: [Ryu-devel] [PATCH] ofproto/ofproto_v1_5_parser: OFPMultipartReply malformed message offset fix

2016-09-28 Thread Victor J. Orlikowski
On Wed, Sep 28, 2016, at 08:32 PM, IWAMOTO Toshihiro wrote: > Another option is wrap top-level msg_parser functions with > eventlet.timeout.Timeout, which amounts to much less amount of code > but might be ugly and unpopular. > So - depends on how tight the loop is. I looked into using a Timeou

Re: [Ryu-devel] [PATCH] ofproto/ofproto_v1_5_parser: OFPMultipartReply malformed message offset fix

2016-09-28 Thread IWAMOTO Toshihiro
At Wed, 28 Sep 2016 21:15:49 -0400, Victor J. Orlikowski wrote: > > On Wed, Sep 28, 2016, at 08:32 PM, IWAMOTO Toshihiro > wrote: > > Another option is wrap top-level msg_parser functions with > > eventlet.timeout.Timeout, which amounts to much less amount of code > > but might be ugly and unpop

[Ryu-devel] Question about flow installation

2016-09-28 Thread Garegin Grigoryan
Hi, I'm new to RYU controller and I'm trying to install some simple rules. I use Openflow 1.0. Here's my code: addressList = ('10.10.1.1', '10.10.1.2', '10.10.1.3') for address in addressList: actions = [parser.OFPActionOutput(ofproto.OFPP_NORMAL)] match = parser.OFPMatc