Re: [Ryu-devel] [PATCH 0/2] packet: Fix minimum ethernet frame length

2016-07-07 Thread Hiroaki KAWAI
Hi, Iwase-san, Fujita-san Patch set looks good to me. On 2016/07/06 15:26, IWASE Yusuke wrote: > For the discussion with Kawai-San and Fujita-San, this patch > fixes ryu/lib/packet/ethernet.py to fix up the minimum length > of the generated ethernet frames by Ryu's Packet library. > > With this

Re: [Ryu-devel] mark the data packet (Hiroaki KAWAI, tanvir.ulhu...@data61.csiro.au)

2016-07-06 Thread Hiroaki KAWAI
n 2016/07/04 22:54, tanvir.ulhu...@data61.csiro.au wrote: > Hi Hiroaki KAWAI > > Thanks for your prompt response. It helps me a lot :) > > 1. Although I do not have the clear idea about the NXM_NX_PKT_MARK, I have > understood from my reading of the nicira extension that there is a &g

Re: [Ryu-devel] [PATCH] fix tiny packet comparison

2016-07-03 Thread Hiroaki KAWAI
> Hi Kawai-San and Fujita-San, > > > On 2016年07月02日 12:50, FUJITA Tomonori wrote: >> CC'ed Iwase-san, >> >> On Fri, 1 Jul 2016 20:15:10 +0900 >> Hiroaki KAWAI wrote: >> >>> On 2016/07/01 11:36, FUJITA Tomonori wrote: >>>> On We

Re: [Ryu-devel] mark the data packet

2016-07-01 Thread Hiroaki KAWAI
Hi Tanvir, Then, we're talking about Linux specific sk_buf.mark, not a packet marking in general. In ryu library, you can find NXM_NX_PKT_MARK in ryu/ofproto/nicira_ext.py, and it should not be hard to use. https://github.com/osrg/ryu/blob/master/ryu/ofproto/nicira_ext.py#L385 BTW, set_field acti

Re: [Ryu-devel] [PATCH] fix tiny packet comparison

2016-07-01 Thread Hiroaki KAWAI
On 2016/07/01 11:36, FUJITA Tomonori wrote: > On Wed, 29 Jun 2016 00:26:42 -0700 > "Kawai, Hiroaki" wrote: > >> Some system will use padded paackets for ethernet frame that is at >> least 64 bytes long. > > This patch means that the tester sends an ethernet frame that is less > than 64B? I tested

Re: [Ryu-devel] Bad argument in SET_FIELD action (Code=15)

2016-03-19 Thread Hiroaki KAWAI
Hi, Please look into the ovs-vswitchd.log, there should be something logged. If you're using Ubuntu, the file is in /var/log/openvswitch/. BTW, another test is ovs-ofctl, please test following command. # Please rename br0 with your bridge name. sudo ovs-ofctl -O OpenFlow13 add-flow br0 \ ipv6,ip

[Ryu-devel] FYI: Zodiac FX, small openflow hardware switch

2015-07-29 Thread Hiroaki KAWAI
Hi, This is off-topic, but openflow developers would like to know, a project Zodiac FX by Northbound Networks is fundraising at kickstarter now. The project is developing small openflow hardware switch. https://www.kickstarter.com/projects/northboundnetworks/zodiac-fx-the-worlds-smallest-openflow

[Ryu-devel] [PATCH] fix setup.cfg entry

2014-08-14 Thread Hiroaki KAWAI
SubmittingPatches.rst was renamed to CONTRIBUTING.rst. setup.py sdist will check this dependency. --- setup.cfg | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup.cfg b/setup.cfg index ffc239d..6520daa 100644 --- a/setup.cfg +++ b/setup.cfg @@ -38,7 +38,7 @@ Requires = pytho

Re: [Ryu-devel] OXM_OF_VLAN_VID and ofp_packet_in message

2014-07-08 Thread Hiroaki KAWAI
IMHO, OFPVID_PRESENT would be set in ofp_packet_in message if the packet had vlan tags. I agree that it is hard to make sure that the implement is compliant. The description in the spec is as following: "The match field is a set of OXM TLVs containing the pipeline fields associated with a packet"

[Ryu-devel] [PATCH] use Assured Forwarding behavior DSCP value

2014-06-26 Thread Hiroaki KAWAI
OpenFlow spec describes "DSCP values that do not encode a drop precedence are not modified". Diffserv Assured Forwarding described in rfc2597(+rfc3260) has DSCP values which encodes "drop precedence". I think we'd better test OFPMBT_DSCP_REMARK works on AF21 -> AF22 rating, for example. --- .../

[Ryu-devel] [PATCH] use Assured Forwarding behavior DSCP value

2014-06-26 Thread Hiroaki KAWAI
OpenFlow spec describes "DSCP values that do not encode a drop precedence are not modified". Diffserv Assured Forwarding described in rfc2597(+rfc3260) has DSCP values which encodes "drop precedence". I think we'd better test OFPMBT_DSCP_REMARK works on AF21 -> AF22 rating, for example. --- .../

Re: [Ryu-devel] [PATCH] fix pbb itag related tests

2014-04-14 Thread Hiroaki KAWAI
Thanks :-) (2014/04/15 10:50), FUJITA Tomonori wrote: > On Thu, 6 Mar 2014 19:14:56 +0900 > Hiroaki KAWAI wrote: > >> i-tagged packets will have ETH_TYPE=0x88E7. The tests are >> rewritten in the same way with MPLS. > > Really sorry about the delay. I've just

Re: [Ryu-devel] [PATCH] Add ethertype test for OXM_OF_PBB_ISID pre-requisite

2014-03-06 Thread Hiroaki KAWAI
(2014/03/06 0:43), FUJITA Tomonori wrote: > Sorry about the delay, > > On Fri, 21 Feb 2014 18:32:42 +0900 > Hiroaki KAWAI wrote: > >> OXM_OF_PBB_ISID has a pre-requisite of ETH_TYPE=0x88E7, >> by openflow 1.3.3 specification. > > Thanks for the effort to add

[Ryu-devel] [PATCH] Add ethertype test for OXM_OF_PBB_ISID pre-requisite

2014-02-21 Thread Hiroaki KAWAI
OXM_OF_PBB_ISID has a pre-requisite of ETH_TYPE=0x88E7, by openflow 1.3.3 specification. --- ryu/tests/switch/of13/match/05_ETH_TYPE.json | 109 ++ 1 files changed, 109 insertions(+), 0 deletions(-) diff --git a/ryu/tests/switch/of13/match/05_ETH_TYPE.json b/ryu/tests/sw

Re: [Ryu-devel] [PATCH] fix POP_PBB test case

2014-02-19 Thread Hiroaki KAWAI
Hi, (2014/02/19 16:37), FUJITA Tomonori wrote: >> "The Pop PBB header action does not remove the backbone VLAN >> header (B-TAG)" as described in openflow spec 1.3.3. >> The format of I-TAG TCI is pcp,..,I-SID,C-DA,C-SA as in >> 802.1Q-2011 Figure 9-3. > > Thanks a lot! As you pointed out, the ac

[Ryu-devel] [PATCH] fix POP_PBB test case

2014-02-17 Thread Hiroaki KAWAI
"The Pop PBB header action does not remove the backbone VLAN header (B-TAG)" as described in openflow spec 1.3.3. The format of I-TAG TCI is pcp,..,I-SID,C-DA,C-SA as in 802.1Q-2011 Figure 9-3. --- ryu/tests/switch/of13/action/27_POP_PBB.json |3 +++ 1 files changed, 3 insertions(+), 0 deletio