Re: [Ryu-devel] [PATCH] ofproto_v1_4: Add tun_ipv4_src and tun_ipv4_dst NXMs

2014-10-14 Thread Simon Horman
On Tue, Oct 14, 2014 at 03:35:53PM +0900, YAMAMOTO Takashi wrote: > Signed-off-by: YAMAMOTO Takashi Reviewed-by: Simon Horman > --- > ryu/ofproto/ofproto_v1_4.py | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/ryu/ofproto/ofproto_v1_4.py b/ryu/ofproto/ofpro

Re: [Ryu-devel] [PATCH] ofctl: Add default value to type field of OFPGroupMod

2014-09-26 Thread Simon Horman
; > This patch adds default value to type field of OFPGroupMod > at mod_group_entry in order to reflect OpenFlow Specification. > > Signed-off-by: IWASE Yusuke Reviewed-by: Simon Horman > --- > ryu/lib/ofctl_v1_2.py | 2 +- > ryu/lib/ofctl_v1_3.py | 2 +- > 2 file

Re: [Ryu-devel] Malformed Packet: MPLS

2014-09-23 Thread Simon Horman
On Tue, Sep 23, 2014 at 10:02:10AM +0100, Mounir Azizi wrote: > Dear Ryu Experts, > > I'm trying to inject an "echo" mpls packet using ryu, so I created an MPLS > packet using this code : > > f = EchoRyu() > f.timestamp = int(time.time()*1000 - start_time) > eth_MPLS = eth

[Ryu-devel] [PATCH 0/9] tests/integrated: Update OF1.2 action tests

2014-04-24 Thread Simon Horman
fter minor enhancements to follow portions of the OpenFlow1.2 specification enforced by Open vSwitch. With this series in place all the enabled tests in ryu/tests/integrated/test_add_flow_v12_actions.py pass when run using the "make check-ryu" target provided by Open vSwitch. Simon

[Ryu-devel] [PATCH 4/9] tests/integrated: Match on IP dl_type for flows with set NW TTL actions

2014-04-24 Thread Simon Horman
vSwitch's "make ryu-check" as Open vSwitch enforces action consistency for the set NW TTL action. Signed-off-by: Simon Horman --- ryu/tests/integrated/test_add_flow_v12_actions.py | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/ryu/t

[Ryu-devel] [PATCH 6/9] tests/integrated: Match on IP dl_type for flows with set IPv6 addresses

2014-04-24 Thread Simon Horman
those that have set-field actions for IPv6 addresses. Also enable these tests, they appear to be supported by Open vSwitch. I noticed this when using Open vSwitch's "make ryu-check" as Open vSwitch enforces action consistency for the set NW TTL action. Signed-off-by: Simon Horman

[Ryu-devel] [PATCH 7/9] tests/integrated: Match on MPLS dl_type for flows with pop MPLS actions

2014-04-24 Thread Simon Horman
pop MPLS action. Also enable the pop MPLS test, it appears to be supported by Open vSwitch. I noticed this when using Open vSwitch's "make ryu-check" as Open vSwitch enforces action consistency for the set NW TTL action. Signed-off-by: Simon Horman --- ryu/t

[Ryu-devel] [PATCH 5/9] tests/integrated: Enable ARP tests

2014-04-24 Thread Simon Horman
Enable ARP tests, they appear to be supported by Open vSwitch. I noticed this when using Open vSwitch's "make ryu-check" as Open vSwitch enforces action consistency for the set NW TTL action. Signed-off-by: Simon Horman --- ryu/tests/integrated/test_add_flow_v12_actions.p

[Ryu-devel] [PATCH 9/9] tests/integrated: Enable MPLS set-field and push MPLS tests

2014-04-24 Thread Simon Horman
Enable disabled MPLS tests, they appear to be supported by Open vSwitch. I noticed this when using Open vSwitch's "make ryu-check" as Open vSwitch enforces action consistency for the set NW TTL action. Signed-off-by: Simon Horman --- ryu/tests/integrated/test_add_flow_v12

[Ryu-devel] [PATCH 2/9] tests/integrated: Match on VLAN tag for flows with pop VLAN TTL actions

2014-04-24 Thread Simon Horman
pop VLAN action. I noticed this when using Open vSwitch's "make ryu-check" as Open vSwitch enforces action consistency for the pop VLAN TTL action. Signed-off-by: Simon Horman --- ryu/tests/integrated/test_add_flow_v12_actions.py | 4 +++- 1 file changed, 3 insertions(+), 1 de

[Ryu-devel] [PATCH 3/9] tests/integrated: Match on VLAN tag for flows which set VLAN tags

2014-04-24 Thread Simon Horman
flow that has a set-field action for a VLAN tag. I noticed this when using Open vSwitch's "make ryu-check" as Open vSwitch enforces action consistency for set-field actions for VLAN tags. Signed-off-by: Simon Horman --- ryu/tests/integrated/test_add_flow_v12_actions.py | 5 -

[Ryu-devel] [PATCH 1/9] tests/integrated: Match on IP dl_type for flows with dec NW TTL actions

2014-04-24 Thread Simon Horman
istency for the dec NW TTL action. Signed-off-by: Simon Horman --- ryu/tests/integrated/test_add_flow_v12_actions.py | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/ryu/tests/integrated/test_add_flow_v12_actions.py b/ryu/tests/integrated/test_add_flow_v12_a

[Ryu-devel] [PATCH 8/9] tests/integrated: Match on MPLS dl_type for flows with MPLS TTL actions

2014-04-24 Thread Simon Horman
MPLS TTL actions. Also enable these tests, they appear to be supported by Open vSwitch. I noticed this when using Open vSwitch's "make ryu-check" as Open vSwitch enforces action consistency for the set NW TTL action. Signed-off-by: Simon Horman --- ryu/t

Re: [Ryu-devel] [PATCH v2] tests/integrated: Use max_len=OFPCML_NO_BUFFER to prevent buffer allocation

2014-04-24 Thread Simon Horman
acket-in. Sure that is fine by me. Its simple solution to this problem. I have sent a replacement patch "[PATCH] tests/integrated: Do not verify buffer_id of packet_in resulting from packet_out" > > YAMAMOTO Takashi > > > > > I noticed this when using Open vSwi

[Ryu-devel] [PATCH] tests/integrated: Do not verify buffer_id of packet_in resulting from packet_out

2014-04-24 Thread Simon Horman
When a packet_in message results from a packet_out message there is no particular relationship between the buffer_ids of the two messages. I noticed this when using Open vSwitch's "make ryu-check". YAMAMOTO Takashi Signed-off-by: Simon Horman --- Thanks to Yamamoto-san to sugg

[Ryu-devel] [PATCH v2] tests/integrated: Use max_len=OFPCML_NO_BUFFER to prevent buffer allocation

2014-04-24 Thread Simon Horman
controller. I noticed this when using Open vSwitch's "make ryu-check" as Open vSwitch allocates buffers if OFPCML_NO_BUFFER is not in effect. This appears to be compliant with section A.2.5 the OpenFlow 1.2 spec. Signed-off-by: Simon Horman --- v2 * Correct spelling errors ryu/t

[Ryu-devel] [PATCH] tests/integrated: Use max_len=OFPCML_NO_BUFFER to prevent buffer allocation

2014-04-23 Thread Simon Horman
controller. I noticed this when using Open vSwitch's "make ryu-check" as Open vSwitch allocates buffers if OFPCML_NO_BUFFER is not in effect. This appears to be compliant with section A.2.5 the OpenFlow 1.2 spec. Signed-off-by: Simon Horman --- ryu/tests/integrated/test_request_re

[Ryu-devel] [PATCH 2/2] tests/integrated: Use table_id greater than the current table for goto-table instruction

2014-04-23 Thread Simon Horman
For a goto-table instruction use a table_id greater than the table in which a flow will be inserted. OpenFlow 1.2 section 5.6 stipulates that this is required. I noticed this when using Open vSwitch's "make ryu-check" as Open vSwitch enforces the above stipulation. Signed-off-b

[Ryu-devel] [PATCH 1/2] tests/integrated: Specify table_id for flow_mod modify tests

2014-04-23 Thread Simon Horman
Use actual table ids rather than OFPTT_ALL for flow_mod modify tests as OpenFlow 1.2 section A3.4.1 stipulates that OFPTT_ALL is only valid for flow_mod delete requests. I noticed this when using Open vSwitch's "make ryu-check" as Open vSwitch enforces the above stipulation. Signe

[Ryu-devel] [PATCH 0/2] tests/integrated: Adjust tests to follow OpenFlow1.2

2014-04-23 Thread Simon Horman
this area. Simon Horman (2): tests/integrated: Specify table_id for flow_mod modify tests tests/integrated: Use table_id greater than the current table for goto-table instruction ryu/tests/integrated/test_request_reply_v12.py | 19 +++ 1 file changed, 11 insertions(+), 8

Re: [Ryu-devel] [PATCH 3/3] of14: set default attributes for group-related classes

2014-04-15 Thread Simon Horman
On Wed, Apr 16, 2014 at 10:38:09AM +0900, Yuichi Ito wrote: > Signed-off-by: Yuichi Ito Reviewed-by: Simon Horman > --- > ryu/ofproto/ofproto_v1_4_parser.py |8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/ryu/ofproto/ofproto_v1_4_parser.p

Re: [Ryu-devel] [PATCH v5 0/5] of1.4: Increased message coverage

2014-03-21 Thread Simon Horman
2014/03/21 22:56 "FUJITA Tomonori" : > > On Wed, 19 Mar 2014 15:37:38 +0900 > Simon Horman wrote: > > > I have made a wiki page to summarise the status of OF1.4 support in Ryu > > https://github.com/horms/ryu/wiki/OpenFlow-V1.4-Coverage > > Thanks so much!

[Ryu-devel] [PATCH v5 1/5] Allow messages inside messages

2014-03-18 Thread Simon Horman
-by: Simon Horman --- v5 * No change v4 * Rework to add MsgInMsgBase class v3 * No change v2 * Update changelog to refer to Request Forward Message --- ryu/lib/stringify.py | 14 -- ryu/ofproto/ofproto_parser.py | 10 +- 2 files changed, 17 insertions(+), 7

[Ryu-devel] [PATCH v5 5/5] Add request forward message unit test

2014-03-18 Thread Simon Horman
Signed-off-by: Simon Horman --- v4 - v5 * No change v3 * Fix sequence number in filenames: Rename 5-70* => 5-71 v2 * First post --- .../of14/5-71-ofp_requestforward.packet| Bin 0 -> 56 bytes ryu/tests/packet_data_generator/src/x5.erl | 22 ++- .../json/

[Ryu-devel] [PATCH v5 3/5] of14: Add bundle add message unit test

2014-03-18 Thread Simon Horman
Signed-off-by: Simon Horman --- v4 - v5 * No change v3 * Update Data to use bytes rather than arrays of words * Correct sequence number in filenames: 5-69* => 5-70* v2 * Update JSON using normalize_json.py --- .../of14/5-70-ofp_bundle_add_msg.packet| Bin 0 -> 80 bytes ryu

[Ryu-devel] [PATCH v5 0/5] of1.4: Increased message coverage

2014-03-18 Thread Simon Horman
noted in their changelogs. To aid review this series and its dependencies are available at https://github.com/horms/ryu devel/of1.4-messages-v5 I have made a wiki page to summarise the status of OF1.4 support in Ryu https://github.com/horms/ryu/wiki/OpenFlow-V1.4-Coverage Simon Horman (5): Al

[Ryu-devel] [PATCH v5 4/5] Add request forward message support

2014-03-18 Thread Simon Horman
Signed-off-by: Simon Horman --- v5 * No change v4 * Inherit MsgInMsgBase instead of MsgBase - This is a new mechanism to allow messages inside messages v3 * No change v2 * First post --- ryu/ofproto/ofproto_v1_4_parser.py | 48 ++ 1 file changed, 48

[Ryu-devel] [PATCH v5 2/5] of14: Add bundle add message support

2014-03-18 Thread Simon Horman
--- v5 * As suggested by YAMAMOTO Takashi - Only add padding if there are properties present - Don't assign tail_buf twice - xid of inner and outer messages should be the same v4 * Inherit MsgInMsgBase instead of MsgBase - This is a new mechanism to allow messages inside messages v2 - v3

Re: [Ryu-devel] [PATCH v3 14/18] [RFC] of14: Add bundle add message support

2014-03-18 Thread Simon Horman
On Wed, Mar 19, 2014 at 02:54:18PM +0900, YAMAMOTO Takashi wrote: > > Hi Yamamoto-san, > > > > thanks for your feedback and sorry for not addressing it in v4, > > it slipped my mind. > > > > On Thu, Mar 13, 2014 at 02:46:41PM +0900, YAMAMOTO Takashi wrote: > >> > --- > >> > v2 - v3 > >> > * No ch

Re: [Ryu-devel] [PATCH v3 14/18] [RFC] of14: Add bundle add message support

2014-03-18 Thread Simon Horman
Hi Yamamoto-san, thanks for your feedback and sorry for not addressing it in v4, it slipped my mind. On Thu, Mar 13, 2014 at 02:46:41PM +0900, YAMAMOTO Takashi wrote: > > --- > > v2 - v3 > > * No change > > --- > > ryu/ofproto/ofproto_v1_4.py| 5 +++- > > ryu/ofproto/ofproto_v1_4_parser

[Ryu-devel] [PATCH v4 4/5] Add request forward message support

2014-03-17 Thread Simon Horman
Signed-off-by: Simon Horman --- v4 * Inherit MsgInMsgBase instead of MsgBase - This is a new mechanism to allow messages inside messages v3 * No change v2 * First post --- ryu/ofproto/ofproto_v1_4_parser.py | 48 ++ 1 file changed, 48 insertions(+) diff

[Ryu-devel] [PATCH v4 5/5] Add request forward message unit test

2014-03-17 Thread Simon Horman
Signed-off-by: Simon Horman --- v4 * No change v3 * Fix sequence number in filenames: Rename 5-70* => 5-71 v2 * First post --- .../of14/5-71-ofp_requestforward.packet| Bin 0 -> 56 bytes ryu/tests/packet_data_generator/src/x5.erl | 22 ++- .../json/of1

[Ryu-devel] [PATCH v4 2/5] of14: Add bundle add message support

2014-03-17 Thread Simon Horman
--- v4 * Inherit MsgInMsgBase instead of MsgBase - This is a new mechanism to allow messages inside messages v2 - v3 * No change --- ryu/ofproto/ofproto_v1_4.py| 5 ++- ryu/ofproto/ofproto_v1_4_parser.py | 63 +- 2 files changed, 66 insertions(+), 2

[Ryu-devel] [PATCH v4 1/5] Allow messages inside messages

2014-03-17 Thread Simon Horman
-by: Simon Horman --- v4 * Rework to add MsgInMsgBase class v3 * No change v2 * Update changelog to refer to Request Forward Message --- ryu/lib/stringify.py | 14 -- ryu/ofproto/ofproto_parser.py | 10 +- 2 files changed, 17 insertions(+), 7 deletions(-) diff --git

[Ryu-devel] [PATCH v4 3/5] of14: Add bundle add message unit test

2014-03-17 Thread Simon Horman
Signed-off-by: Simon Horman --- v4 * No change v3 * Update Data to use bytes rather than arrays of words * Correct sequence number in filenames: 5-69* => 5-70* v2 * Update JSON using normalize_json.py --- .../of14/5-70-ofp_bundle_add_msg.packet| Bin 0 -> 80 bytes ryu

[Ryu-devel] [PATCH v4 0/5] of1.4: Increased message coverage

2014-03-17 Thread Simon Horman
orms/ryu devel/of1.4-messages-v4 I have made a wiki page to summarise the status of OF1.4 support in Ryu https://github.com/horms/ryu/wiki/OpenFlow-V1.4-Coverage Simon Horman (5): Allow messages inside messages of14: Add bundle add message support of14: Add bundle add message unit test Add req

Re: [Ryu-devel] [PATCH v3 15/18] [RFC] Allow messages inside messages

2014-03-16 Thread Simon Horman
On Mon, Mar 17, 2014 at 03:10:17PM +0900, YAMAMOTO Takashi wrote: > > On Thu, Mar 13, 2014 at 02:46:43PM +0900, YAMAMOTO Takashi wrote: > >> > @@ -230,19 +230,24 @@ class StringifyMixin(object): > >> > return cls._get_default_decoder(decode_string) > >> > > >> > @classmethod > >> >

Re: [Ryu-devel] [PATCH v3 15/18] [RFC] Allow messages inside messages

2014-03-16 Thread Simon Horman
On Thu, Mar 13, 2014 at 02:46:43PM +0900, YAMAMOTO Takashi wrote: > > @@ -230,19 +230,24 @@ class StringifyMixin(object): > > return cls._get_default_decoder(decode_string) > > > > @classmethod > > -def _decode_value(cls, k, json_value, decode_string=base64.b64decode): > > -

Re: [Ryu-devel] [PATCH] fix NX_EXPERIMENTER_ID

2014-03-11 Thread Simon Horman
On Wed, Mar 12, 2014 at 02:24:00PM +0900, YAMAMOTO Takashi wrote: > also, comment registry url. > > Signed-off-by: YAMAMOTO Takashi Reviewed-by: Simon Horman > --- > ryu/ofproto/ofproto_common.py | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >

[Ryu-devel] [PATCH v3 13/18] of14: Add bundle control message unit test

2014-03-10 Thread Simon Horman
Signed-off-by: Simon Horman --- v3 * No change v2 * Rebase - Rename files: 5-69-* -> 5-68-* - Use bytes instead of an array of words for data fields * Update JSON using normalize_json.py --- .../of14/5-69-ofp_bundle_ctrl_msg.packet | Bin 0 -> 72 bytes ryu

[Ryu-devel] [PATCH v3 14/18] [RFC] of14: Add bundle add message support

2014-03-10 Thread Simon Horman
--- v2 - v3 * No change --- ryu/ofproto/ofproto_v1_4.py| 5 +++- ryu/ofproto/ofproto_v1_4_parser.py | 60 ++ 2 files changed, 64 insertions(+), 1 deletion(-) diff --git a/ryu/ofproto/ofproto_v1_4.py b/ryu/ofproto/ofproto_v1_4.py index 8b9431e..0688491

[Ryu-devel] [PATCH v3 08/18] of14: Add table status unit test

2014-03-10 Thread Simon Horman
Signed-off-by: Simon Horman --- v3 * Update changelog: s/of1.4/of14/ v2 * First post --- .../packet_data/of14/5-68-ofp_table_status.packet | Bin 0 -> 96 bytes ryu/tests/packet_data_generator/src/x5.erl | 26 +- .../json/of14/5-68-ofp_table_status.packet.json|

[Ryu-devel] [PATCH v3 17/18] [RFC] Add request forward message support

2014-03-10 Thread Simon Horman
Signed-off-by: Simon Horman --- v3 * No change v2 * First post --- ryu/ofproto/ofproto_v1_4_parser.py | 48 ++ 1 file changed, 48 insertions(+) diff --git a/ryu/ofproto/ofproto_v1_4_parser.py b/ryu/ofproto/ofproto_v1_4_parser.py index c4d2431..5e644dd

[Ryu-devel] [PATCH v3 15/18] [RFC] Allow messages inside messages

2014-03-10 Thread Simon Horman
cases. Signed-off-by: Simon Horman --- v3 * No change v2 * Update changelog to refer to Request Forward Message --- ryu/lib/stringify.py | 20 +--- ryu/ofproto/ofproto_parser.py | 1 - 2 files changed, 13 insertions(+), 8 deletions(-) diff --git a/ryu/lib/stringify.py

[Ryu-devel] [PATCH v3 10/18] of14: Update get async reply and set async implementation to follow spec

2014-03-10 Thread Simon Horman
The current get async reply and get async implementations follows that of of_protocol and OpenFlow 1.3. However, OpenFlow 1.4 defines a rather different format. This patch updates the implementation to follow the OpenFlow 1.4 specification. Signed-off-by: Simon Horman --- v3 * First Post

[Ryu-devel] [PATCH v3 16/18] [RFC] of14: Add bundle add message unit test

2014-03-10 Thread Simon Horman
Signed-off-by: Simon Horman --- v3 * Update Data to use bytes rather than arrays of words * Correct sequence number in filenames: 5-69* => 5-70* v2 * Update JSON using normalize_json.py --- .../of14/5-70-ofp_bundle_add_msg.packet| Bin 0 -> 80 bytes ryu/tests/packet_data_gen

[Ryu-devel] [PATCH v3 18/18] [RFC] Add request forward message unit test

2014-03-10 Thread Simon Horman
Signed-off-by: Simon Horman --- v3 * Fix sequence number in filenames: Rename 5-70* => 5-71 v2 * First post --- .../of14/5-71-ofp_requestforward.packet| Bin 0 -> 56 bytes ryu/tests/packet_data_generator/src/x5.erl | 22 ++- .../json/of1

[Ryu-devel] [PATCH v3 09/18] of14: Add OFPAsyncConfigProp

2014-03-10 Thread Simon Horman
This will be used by a revised implementations of get async request reply and set async Signed-off-by: Simon Horman --- v3 * First Post --- ryu/ofproto/ofproto_v1_4_parser.py | 45 ++ 1 file changed, 45 insertions(+) diff --git a/ryu/ofproto

[Ryu-devel] [PATCH v3 11/18] of14: Remove incorrect OFP_ASYNC_CONFIG_{PACK_STR, SIZE}

2014-03-10 Thread Simon Horman
values are unused so simply remove them. Signed-off-by: Simon Horman --- v3 * First post --- ryu/ofproto/ofproto_v1_4.py | 6 -- 1 file changed, 6 deletions(-) diff --git a/ryu/ofproto/ofproto_v1_4.py b/ryu/ofproto/ofproto_v1_4.py index 200e9b0..8b9431e 100644 --- a/ryu/ofproto/ofproto_v1_4

[Ryu-devel] [PATCH v3 05/18] of14: Add flow monitor request unit test

2014-03-10 Thread Simon Horman
Signed-off-by: Simon Horman --- v3 * No change v2 * Updated JSON using normalize_json.py --- .../of14/5-66-ofp_flow_monitor_request.packet | Bin 0 -> 48 bytes ryu/tests/packet_data_generator/src/x5.erl | 18 +- .../of14/5-66-ofp_flow_monitor_request.packet.json |

[Ryu-devel] [PATCH v3 03/18] of14: Add flow monitor reply support

2014-03-10 Thread Simon Horman
Signed-off-by: Simon Horman --- v2 - v3 * No change --- ryu/ofproto/ofproto_v1_4_parser.py | 50 ++ 1 file changed, 50 insertions(+) diff --git a/ryu/ofproto/ofproto_v1_4_parser.py b/ryu/ofproto/ofproto_v1_4_parser.py index 7cc78e7..f3b0aee 100644 --- a/ryu

[Ryu-devel] [PATCH v3 01/18] of14: Add OFPFlowUpdate

2014-03-10 Thread Simon Horman
This will be used by flow monitor reply messages Signed-off-by: Simon Horman --- v3 * Set defaults for parameters of OFPFlowUpdateHeader::__init__ to cover the case where subclasses do not override this method as is the case for OFPFlowUpdatePaused. v2 * No change --- ryu/ofproto

[Ryu-devel] [PATCH v3 12/18] of14: Add bundle control message support

2014-03-10 Thread Simon Horman
Signed-off-by: Simon Horman --- v3 * Rebase v2 * First post --- ryu/ofproto/ofproto_v1_4_parser.py | 64 ++ 1 file changed, 64 insertions(+) diff --git a/ryu/ofproto/ofproto_v1_4_parser.py b/ryu/ofproto/ofproto_v1_4_parser.py index 1edc9b1..186684a 100644

[Ryu-devel] [PATCH v3 02/18] of14: Add flow monitor request support

2014-03-10 Thread Simon Horman
Signed-off-by: Simon Horman --- v2 - v3 * No change --- ryu/ofproto/ofproto_v1_4.py| 7 +++- ryu/ofproto/ofproto_v1_4_parser.py | 82 ++ 2 files changed, 88 insertions(+), 1 deletion(-) diff --git a/ryu/ofproto/ofproto_v1_4.py b/ryu/ofproto

[Ryu-devel] [PATCH v3 06/18] of14: Add flow monitor reply message unit test

2014-03-10 Thread Simon Horman
Signed-off-by: Simon Horman --- v3 * No change v2 * Updated JSON using normalize_json.py --- .../of14/5-67-ofp_flow_monitor_reply.packet| Bin 0 -> 96 bytes ryu/tests/packet_data_generator/src/x5.erl | 30 +- .../of14/5-67-ofp_flow_monitor_reply.packet.json |

[Ryu-devel] [PATCH v3 07/18] of14: Add table status support

2014-03-10 Thread Simon Horman
Signed-off-by: Simon Horman --- v3 * Update changelog: s/of1.4/of14/ v2 * First post --- ryu/ofproto/ofproto_v1_4.py| 6 - ryu/ofproto/ofproto_v1_4_parser.py | 55 ++ 2 files changed, 60 insertions(+), 1 deletion(-) diff --git a/ryu/ofproto

[Ryu-devel] [PATCH v3 04/18] packet_data_generator: New ofproto dependency for v5 updates

2014-03-10 Thread Simon Horman
Update ofproto dependency to include a merge of the mainline v5 branch which includes: * Bundle messages * Flow monitor messages * Request Forward message * Table Status message * Fix for length of Flow Update Full entry of Flow Monitor reply message Signed-off-by: Simon Horman --- v3 * Update

[Ryu-devel] [PATCH v3 00/18] of1.4: Increased message coverage

2014-03-10 Thread Simon Horman
d in their changelogs. To aid review this series and its dependencies are available at https://github.com/horms/ryu devel/of1.4-messages-v3 I have made a wiki page to summarise the status of OF1.4 support in Ryu https://github.com/horms/ryu/wiki/OpenFlow-V1.4-Coverage Simon Horman (18):

Re: [Ryu-devel] [PATCH v2 00/18] of1.4: Increased message coverage

2014-03-05 Thread Simon Horman
On Thu, Mar 06, 2014 at 09:51:28AM +0900, Simon Horman wrote: > Hi, > > The aim of this series is to add an implementation of and > tests for the following messages: > > * Flow monitor request > + Now present in the v5 branch of of_protocol > + Was pull request 67

[Ryu-devel] [PATCH v2 15/18] [RFC] of14: Add bundle add message unit test

2014-03-05 Thread Simon Horman
Signed-off-by: Simon Horman --- v2 * Update JSON using normalize_json.py --- .../of14/5-69-ofp_bundle_add_msg.packet| Bin 0 -> 80 bytes ryu/tests/packet_data_generator/src/x5.erl | 22 ++ .../json/of14/5-69-ofp_bundle_add_msg.packet.json |

[Ryu-devel] [PATCH v2 10/18] of1.4: Add table status unit test

2014-03-05 Thread Simon Horman
Signed-off-by: Simon Horman --- v2 * First post --- .../packet_data/of14/5-68-ofp_table_status.packet | Bin 0 -> 96 bytes ryu/tests/packet_data_generator/src/x5.erl | 26 +- .../json/of14/5-68-ofp_table_status.packet.json| 57 + ryu/tests/unit/ofpr

[Ryu-devel] [PATCH v2 12/18] of14: Add bundle control message unit test

2014-03-05 Thread Simon Horman
Signed-off-by: Simon Horman --- v2 * Rebase - Rename files: 5-69-* -> 5-68-* - Use bytes instead of an array of words for data fields * Update JSON using normalize_json.py --- .../of14/5-69-ofp_bundle_ctrl_msg.packet | Bin 0 -> 72 bytes ryu/tests/packet_data_generator/src/

[Ryu-devel] [PATCH v2 16/18] [RFC] Add request forward message support

2014-03-05 Thread Simon Horman
Signed-off-by: Simon Horman --- v2 * First post --- ryu/ofproto/ofproto_v1_4_parser.py | 48 ++ 1 file changed, 48 insertions(+) diff --git a/ryu/ofproto/ofproto_v1_4_parser.py b/ryu/ofproto/ofproto_v1_4_parser.py index 1b7a61c..434daf9 100644 --- a/ryu

[Ryu-devel] [PATCH v2 17/18] [RFC] packet_data_generator: Update protocol dependency for v5 request forward

2014-03-05 Thread Simon Horman
Update ofproto dependency to include pull request 70, an implementation of request forward Signed-off-by: Simon Horman --- v2 * First post --- ryu/tests/packet_data_generator/rebar.config | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ryu/tests/packet_data_generator

[Ryu-devel] [PATCH v2 06/18] packet_data_generator: Update ofproto dependency for v5 fix

2014-03-05 Thread Simon Horman
Update ofproto dependency to include a pull request 68, a fix for flow monitor reply messages. Signed-off-by: Simon Horman --- v2 * Update changelog text to refer to pull request 68 --- ryu/tests/packet_data_generator/rebar.config | 9 - 1 file changed, 4 insertions(+), 5 deletions

[Ryu-devel] [PATCH v2 18/18] [RFC] Add request forward message unit test

2014-03-05 Thread Simon Horman
Signed-off-by: Simon Horman --- v2 * First post --- .../of14/5-70-ofp_requestforward.packet| Bin 0 -> 56 bytes ryu/tests/packet_data_generator/src/x5.erl | 22 ++- .../json/of14/5-70-ofp_requestforward.packet.json | 31 + ryu/tests/u

[Ryu-devel] [PATCH v2 09/18] packet_data_generator: Update protocol dependency for v5 table stats

2014-03-05 Thread Simon Horman
Update ofproto dependency to include pull request 69, an implementation of table status Signed-off-by: Simon Horman --- v2 * First post --- ryu/tests/packet_data_generator/rebar.config | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ryu/tests/packet_data_generator

[Ryu-devel] [PATCH v2 05/18] of14: Add flow monitor request unit test

2014-03-05 Thread Simon Horman
Signed-off-by: Simon Horman --- v2 * Updated JSON using normalize_json.py --- .../of14/5-66-ofp_flow_monitor_request.packet | Bin 0 -> 48 bytes ryu/tests/packet_data_generator/src/x5.erl | 18 +- .../of14/5-66-ofp_flow_monitor_request.packet.json |

[Ryu-devel] [PATCH v2 08/18] of1.4: Add table status support

2014-03-05 Thread Simon Horman
Signed-off-by: Simon Horman --- v2 * First post --- ryu/ofproto/ofproto_v1_4.py| 6 - ryu/ofproto/ofproto_v1_4_parser.py | 55 ++ 2 files changed, 60 insertions(+), 1 deletion(-) diff --git a/ryu/ofproto/ofproto_v1_4.py b/ryu/ofproto

[Ryu-devel] [PATCH v2 00/18] of1.4: Increased message coverage

2014-03-05 Thread Simon Horman
i/OpenFlow-V1.4-Coverage Simon Horman (18): of14: Add OFPFlowUpdate of14: Add flow monitor request support of14: Add flow monitor reply support packet_data_generator: New ofproto dependency for v5 updates of14: Add flow monitor request unit test packet_data_generator: Update ofproto depe

[Ryu-devel] [PATCH v2 14/18] [RFC] Allow messages inside messages

2014-03-05 Thread Simon Horman
cases. Signed-off-by: Simon Horman --- v2 * Update changelog to refer to Request Forward Message --- ryu/lib/stringify.py | 20 +--- ryu/ofproto/ofproto_parser.py | 1 - 2 files changed, 13 insertions(+), 8 deletions(-) diff --git a/ryu/lib/stringify.py b/ryu/lib

[Ryu-devel] [PATCH v2 11/18] of14: Add bundle control message support

2014-03-05 Thread Simon Horman
Signed-off-by: Simon Horman --- v2 * First post --- ryu/ofproto/ofproto_v1_4_parser.py | 64 ++ 1 file changed, 64 insertions(+) diff --git a/ryu/ofproto/ofproto_v1_4_parser.py b/ryu/ofproto/ofproto_v1_4_parser.py index 1308852..2d4581a 100644 --- a/ryu

[Ryu-devel] [PATCH v2 13/18] [RFC] of14: Add bundle add message support

2014-03-05 Thread Simon Horman
--- ryu/ofproto/ofproto_v1_4.py| 5 +++- ryu/ofproto/ofproto_v1_4_parser.py | 60 ++ 2 files changed, 64 insertions(+), 1 deletion(-) diff --git a/ryu/ofproto/ofproto_v1_4.py b/ryu/ofproto/ofproto_v1_4.py index 200e9b0..838521f 100644 --- a/ryu/ofproto

[Ryu-devel] [PATCH v2 04/18] packet_data_generator: New ofproto dependency for v5 updates

2014-03-05 Thread Simon Horman
Update ofproto dependency to include a merge of the mainline v5 branch which includes: * Bundle messages * Flow monitor messages Signed-off-by: Simon Horman --- v2 * No change --- ryu/tests/packet_data_generator/rebar.config | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[Ryu-devel] [PATCH v2 02/18] of14: Add flow monitor request support

2014-03-05 Thread Simon Horman
Signed-off-by: Simon Horman --- v2 * No change --- ryu/ofproto/ofproto_v1_4.py| 7 +++- ryu/ofproto/ofproto_v1_4_parser.py | 82 ++ 2 files changed, 88 insertions(+), 1 deletion(-) diff --git a/ryu/ofproto/ofproto_v1_4.py b/ryu/ofproto/ofproto_v1_4

[Ryu-devel] [PATCH v2 07/18] of14: Add flow monitor reply message unit test

2014-03-05 Thread Simon Horman
Signed-off-by: Simon Horman --- v2 * Updated JSON using normalize_json.py --- .../of14/5-67-ofp_flow_monitor_reply.packet| Bin 0 -> 96 bytes ryu/tests/packet_data_generator/src/x5.erl | 30 +- .../of14/5-67-ofp_flow_monitor_reply.packet.json |

[Ryu-devel] [PATCH v2 03/18] of14: Add flow monitor reply support

2014-03-05 Thread Simon Horman
Signed-off-by: Simon Horman --- v2 * No change --- ryu/ofproto/ofproto_v1_4_parser.py | 50 ++ 1 file changed, 50 insertions(+) diff --git a/ryu/ofproto/ofproto_v1_4_parser.py b/ryu/ofproto/ofproto_v1_4_parser.py index c701cfe..109a0cf 100644 --- a/ryu

[Ryu-devel] [PATCH v2 01/18] of14: Add OFPFlowUpdate

2014-03-05 Thread Simon Horman
This will be used by flow monitor reply messages Signed-off-by: Simon Horman --- v2 * No change --- ryu/ofproto/ofproto_v1_4.py| 6 +- ryu/ofproto/ofproto_v1_4_parser.py | 116 + 2 files changed, 121 insertions(+), 1 deletion(-) diff --git a/ryu

Re: [Ryu-devel] experimenter payload type

2014-03-03 Thread Simon Horman
On Tue, Mar 04, 2014 at 04:07:25PM +0900, YAMAMOTO Takashi wrote: > > On Tue, Mar 04, 2014 at 03:29:57PM +0900, FUJITA Tomonori wrote: > >> On Tue, 4 Mar 2014 12:07:36 +0900 (JST) > >> yamam...@valinux.co.jp (YAMAMOTO Takashi) wrote: > >> > >> > OFPPropCommonExperimenter4ByteData takes "data" of

Re: [Ryu-devel] experimenter payload type

2014-03-03 Thread Simon Horman
On Tue, Mar 04, 2014 at 03:29:57PM +0900, FUJITA Tomonori wrote: > On Tue, 4 Mar 2014 12:07:36 +0900 (JST) > yamam...@valinux.co.jp (YAMAMOTO Takashi) wrote: > > > OFPPropCommonExperimenter4ByteData takes "data" of a list of words. > > others like OFPActionExperimenter and OFPErrorExperimenterMsg

[Ryu-devel] [PATCH v2] of14: Correct documentation of table mod flags and properties

2014-03-03 Thread Simon Horman
* Document properties * The valid flags for OpenFlow 1.4 are OFPTC_EVICTION and OFPTC_VACANCY_EVENTS Signed-off-by: Simon Horman --- v2 * Update properties documentation * OFPTC_EVICTION and OFPTC_VACANCY_EVENTS are the valid flags. v1 incorrectly claimed there were no valid flags --- ryu

Re: [Ryu-devel] [PATCH 4/9] of14: Correct documentation of table mod flags

2014-03-03 Thread Simon Horman
On Tue, Mar 04, 2014 at 02:48:59PM +0900, FUJITA Tomonori wrote: > On Tue, 4 Mar 2014 14:08:48 +0900 > Simon Horman wrote: > > > On Tue, Mar 04, 2014 at 01:51:33PM +0900, FUJITA Tomonori wrote: > >> On Mon, 3 Mar 2014 11:38:30 +0900 > >> Simon Horman wrote:

Re: [Ryu-devel] [PATCH 4/9] of14: Correct documentation of table mod flags

2014-03-03 Thread Simon Horman
On Tue, Mar 04, 2014 at 01:51:33PM +0900, FUJITA Tomonori wrote: > On Mon, 3 Mar 2014 11:38:30 +0900 > Simon Horman wrote: > > > * There are no valid flags > > > > Signed-off-by: Simon Horman > > --- > > ryu/ofproto/ofproto_v1_4_parser.py | 3 +--

[Ryu-devel] [PATCH 3/5] [RFC] of14: Add bundle add message support

2014-03-03 Thread Simon Horman
--- ryu/ofproto/ofproto_v1_4.py| 5 +++- ryu/ofproto/ofproto_v1_4_parser.py | 60 ++ 2 files changed, 64 insertions(+), 1 deletion(-) diff --git a/ryu/ofproto/ofproto_v1_4.py b/ryu/ofproto/ofproto_v1_4.py index 5f83e07..0687803 100644 --- a/ryu/ofproto

[Ryu-devel] [PATCH 4/5] [RFC] Allow messages inside messages

2014-03-03 Thread Simon Horman
subclasses. * Gratuitously try to decode JSON without **additional_args and then if that raises an exception fall back to decoding with **additional_args. The assumption is that the first pass will fail for subclasses of MsgBase and the second pass will work such cases. Signed-off-by: Simon

[Ryu-devel] [PATCH 1/5] of14: Add bundle control message support

2014-03-03 Thread Simon Horman
Signed-off-by: Simon Horman --- ryu/ofproto/ofproto_v1_4_parser.py | 64 ++ 1 file changed, 64 insertions(+) diff --git a/ryu/ofproto/ofproto_v1_4_parser.py b/ryu/ofproto/ofproto_v1_4_parser.py index 6120633..b4e0382 100644 --- a/ryu/ofproto

[Ryu-devel] [PATCH 2/5] of14: Add bundle control message unit test

2014-03-03 Thread Simon Horman
Signed-off-by: Simon Horman --- .../of14/5-68-ofp_bundle_ctrl_msg.packet | Bin 0 -> 72 bytes ryu/tests/packet_data_generator/src/x5.erl | 19 ++- .../json/of14/5-68-ofp_bundle_ctrl_msg.packet.json | 36 + ryu/tests/unit/ofproto/test_parser

[Ryu-devel] [PATCH 5/5] [RFC] of14: Add bundle add message unit test

2014-03-03 Thread Simon Horman
Signed-off-by: Simon Horman --- .../of14/5-69-ofp_bundle_add_msg.packet| Bin 0 -> 80 bytes ryu/tests/packet_data_generator/src/x5.erl | 22 +++ .../json/of14/5-69-ofp_bundle_add_msg.packet.json | 41 + ryu/tests/unit/ofproto/test_parser

[Ryu-devel] [PATCH 0/5] of14: Add bundle support

2014-03-03 Thread Simon Horman
.com/horms/ryu devel/of1.4-bundle I have made a wiki page to summarise the status of OF1.4 support in Ryu https://github.com/horms/ryu/wiki/OpenFlow-V1.4-Coverage Simon Horman (5): of14: Add bundle control message support of14: Add bundle control message unit test [RFC] of14: Add bundle

[Ryu-devel] [PATCH 0/7] of14: Add Flow monitor support

2014-03-03 Thread Simon Horman
68 for of_protocol which includes a fix for the length handling of flow monitor reply packets - This fix was created while working on the Ryu implementation - See: https://github.com/FlowForwarding/of_protocol/pull/68 Simon Horman (7): of14: Add OFPFlowUpdate of14: Add flow monitor

[Ryu-devel] [PATCH 2/7] of14: Add flow monitor request support

2014-03-03 Thread Simon Horman
Signed-off-by: Simon Horman --- ryu/ofproto/ofproto_v1_4.py| 7 +++- ryu/ofproto/ofproto_v1_4_parser.py | 82 ++ 2 files changed, 88 insertions(+), 1 deletion(-) diff --git a/ryu/ofproto/ofproto_v1_4.py b/ryu/ofproto/ofproto_v1_4.py index 0d8efb6

[Ryu-devel] [PATCH 6/7] packet_data_generator: Update ofproto dependency for v5 fix

2014-03-03 Thread Simon Horman
Update ofproto dependency to include a fix for flow monitor reply messages. Signed-off-by: Simon Horman --- The fix pull/68 which has been sent to the of_protocol maintainers. --- ryu/tests/packet_data_generator/rebar.config | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff

[Ryu-devel] [PATCH 7/7] of14: Add flow monitor reply message unit test

2014-03-03 Thread Simon Horman
Signed-off-by: Simon Horman --- .../of14/5-67-ofp_flow_monitor_reply.packet| Bin 0 -> 96 bytes ryu/tests/packet_data_generator/src/x5.erl | 30 +- .../of14/5-67-ofp_flow_monitor_reply.packet.json | 66 + 3 files changed, 95 insertions(+)

[Ryu-devel] [PATCH 4/7] packet_data_generator: New ofproto dependency for v5 updates

2014-03-03 Thread Simon Horman
Update ofproto dependency to include a merge of the mainline v5 branch which includes: * Bundle messages * Flow monitor messages Signed-off-by: Simon Horman --- ryu/tests/packet_data_generator/rebar.config | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ryu/tests

[Ryu-devel] [PATCH 1/7] of14: Add OFPFlowUpdate

2014-03-03 Thread Simon Horman
This will be used by flow monitor reply messages Signed-off-by: Simon Horman --- ryu/ofproto/ofproto_v1_4.py| 6 +- ryu/ofproto/ofproto_v1_4_parser.py | 116 + 2 files changed, 121 insertions(+), 1 deletion(-) diff --git a/ryu/ofproto/ofproto_v1_4

[Ryu-devel] [PATCH 5/7] of14: Add flow monitor request unit test

2014-03-03 Thread Simon Horman
Signed-off-by: Simon Horman --- .../of14/5-66-ofp_flow_monitor_request.packet | Bin 0 -> 48 bytes ryu/tests/packet_data_generator/src/x5.erl | 18 +- .../of14/5-66-ofp_flow_monitor_request.packet.json | 27 + 3 files changed, 44 insertions(+)

[Ryu-devel] [PATCH 3/7] of14: Add flow monitor reply support

2014-03-03 Thread Simon Horman
Signed-off-by: Simon Horman --- ryu/ofproto/ofproto_v1_4_parser.py | 50 ++ 1 file changed, 50 insertions(+) diff --git a/ryu/ofproto/ofproto_v1_4_parser.py b/ryu/ofproto/ofproto_v1_4_parser.py index e9d49b0..6120633 100644 --- a/ryu/ofproto

[Ryu-devel] [PATCH 4/9] of14: Correct documentation of table mod flags

2014-03-02 Thread Simon Horman
* There are no valid flags Signed-off-by: Simon Horman --- ryu/ofproto/ofproto_v1_4_parser.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/ryu/ofproto/ofproto_v1_4_parser.py b/ryu/ofproto/ofproto_v1_4_parser.py index ddc1e57..73b803f 100644 --- a/ryu/ofproto

[Ryu-devel] [PATCH 5/9] of14: Correct documentation of flow mod flags

2014-03-02 Thread Simon Horman
* Flags is a bitmap of OFPFF_* values rather than a single OFPFF_* value Signed-off-by: Simon Horman --- ryu/ofproto/ofproto_v1_4_parser.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ryu/ofproto/ofproto_v1_4_parser.py b/ryu/ofproto/ofproto_v1_4_parser.py index

[Ryu-devel] [PATCH 2/9] of14: Correct documentation of set config flags

2014-03-02 Thread Simon Horman
* Flags is a bitmap of OFPC_FRAG_* values rather than a single OFPC_FRAG_* value * OFPC_FRAG_MASK is not a valid bitmap field Signed-off-by: Simon Horman --- ryu/ofproto/ofproto_v1_4_parser.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/ryu/ofproto

  1   2   3   4   5   >