Re: [Ryu-devel] [RFC][PATCH] Raise OFPTruncatedMessage exception on truncated messages

2016-10-03 Thread Takashi YAMAMOTO
On Thu, Sep 29, 2016 at 4:44 PM, IWAMOTO Toshihiro wrote: > OFPT_ERROR_MSG can return truncated messages. Some users want to > see them in human-friendly format [1]. Catch exceptions caused > by such truncated messages and reraise as OFPTruncatedMessage > with incomplete ofpmsg in the exception

Re: [Ryu-devel] [PATCH] ofproto/nicira_ext: Add missing NXMs in OVS v2.6.0

2016-09-29 Thread Takashi YAMAMOTO
On Fri, Sep 30, 2016 at 1:22 PM, Shinpei Muraoka wrote: > Signed-off-by: Shinpei Muraoka > --- > ryu/ofproto/nicira_ext.py | 179 ++ > +++- > 1 file changed, 177 insertions(+), 2 deletions(-) > > diff --git a/ryu/ofproto/nicira_ext.py b/ryu/ofproto/nicira

Re: [Ryu-devel] [PATCH v4 1/2] ofproto/nx_actions: Revert API of NXAction

2016-07-27 Thread Takashi YAMAMOTO
On Wed, Jul 27, 2016 at 7:53 PM, FUJITA Tomonori wrote: > On Wed, 27 Jul 2016 19:29:58 +0900 > Takashi YAMAMOTO wrote: > > > On Wed, Jul 27, 2016 at 11:35 AM, Shinpei Muraoka < > shinpei.mura...@gmail.com > >> wrote: > > > >> This patch will revert

Re: [Ryu-devel] [PATCH v4 1/2] ofproto/nx_actions: Revert API of NXAction

2016-07-27 Thread Takashi YAMAMOTO
On Wed, Jul 27, 2016 at 11:35 AM, Shinpei Muraoka wrote: > This patch will revert the API of NXAction for the following report. > https://bugs.launchpad.net/dragonflow/+bug/1599367 > revert commit id: 3c3896fd77f274ce953dcb78795aa5cc4fde6c65 > > This patch reverts recently introduced start and en

Re: [Ryu-devel] [PATCH 4/7] ofproto/nx_actions: Update arguments to be compatible with ovs-ofctl

2016-07-07 Thread Takashi YAMAMOTO
y (ie. be similar to on-wire) is more important here. you can add start/end as optional arguments and if specified convert them to ofs/nbits. in that way you can keep compatibility. i'm afraid that we need to do so anyway if we want to keep compatibilty with both of ryu 4.4 and older releases.

Re: [Ryu-devel] [PATCH 4/7] ofproto/nx_actions: Update arguments to be compatible with ovs-ofctl

2016-07-07 Thread Takashi YAMAMOTO
On Mon, Jun 6, 2016 at 9:48 AM, Shinpei Muraoka wrote: > This patch, update the methods that are to be specified in the NXM or OXM. > Update the value specified in the bit format to the start and end formats. > Update the following NXAction. > > - NXActionRegLoad > - NXActionOutputReg > - NXAc

Re: [Ryu-devel] [PATCH 4/7] ofproto/nx_actions: Update arguments to be compatible with ovs-ofctl

2016-07-06 Thread Takashi YAMAMOTO
this change broke dragonflow. https://bugs.launchpad.net/dragonflow/+bug/1599367 i thought we aimed to align with on-wire fields rather than ovs-ofctl etc. was the policy changed? On Mon, Jun 6, 2016 at 9:48 AM, Shinpei Muraoka wrote: > This patch, update the methods that are to be specified in

Re: [Ryu-devel] [PATCH] Avoid parallel executions of AppManager.close()

2016-06-30 Thread Takashi YAMAMOTO
On Tue, Jun 28, 2016 at 5:03 PM, IWAMOTO Toshihiro wrote: > At Tue, 28 Jun 2016 16:19:52 +0900, > Takashi YAMAMOTO wrote: > > > > [1 ] > > On Tue, Jun 28, 2016 at 3:16 PM, IWAMOTO Toshihiro < > iwam...@valinux.co.jp> > > wrote: > > > >

Re: [Ryu-devel] [PATCH] Avoid parallel executions of AppManager.close()

2016-06-28 Thread Takashi YAMAMOTO
On Tue, Jun 28, 2016 at 3:16 PM, IWAMOTO Toshihiro wrote: > At Tue, 28 Jun 2016 15:02:52 +0900, > Takashi YAMAMOTO wrote: > > > > On Tue, Jun 28, 2016 at 2:25 PM, IWAMOTO Toshihiro < > iwam...@valinux.co.jp> > > wrote: > > > > > If an AppManager.c

Re: [Ryu-devel] [PATCH] Avoid parallel executions of AppManager.close()

2016-06-27 Thread Takashi YAMAMOTO
On Tue, Jun 28, 2016 at 2:25 PM, IWAMOTO Toshihiro wrote: > If an AppManager.close call is started and all AppManager.services > are stop, AppManager.run_apps starts another close() call, > why joinall in run_apps returns before AppManager.close finish clearing self.applications? > resulting i

Re: [Ryu-devel] [PATCH] Make ovs optional

2016-05-27 Thread Takashi YAMAMOTO
On Fri, May 27, 2016 at 2:55 PM, FUJITA Tomonori wrote: > On Fri, 27 May 2016 14:09:22 +0900 > Takashi YAMAMOTO wrote: > > > any chance to make 4.2.2 for this? > > it's blocking XenServer Neutron CI. > > https://pypi.python.org/pypi/

Re: [Ryu-devel] [PATCH] Make ovs optional

2016-05-26 Thread Takashi YAMAMOTO
any chance to make 4.2.2 for this? it's blocking XenServer Neutron CI. On Fri, May 27, 2016 at 7:11 AM, FUJITA Tomonori wrote: > On Wed, 25 May 2016 16:03:45 +0900 > YAMAMOTO Takashi wrote: > > > Requiring a dev version of ovs here causes version conflict issues > > for projects which don't wan

Re: [Ryu-devel] Potential python 3 incompatibility with Ryu BGP?

2016-05-18 Thread Takashi Yamamoto
On Thu, May 19, 2016 at 12:22 PM, FUJITA Tomonori wrote: > On Thu, 19 May 2016 11:16:54 +0900 > Takashi Yamamoto wrote: > >> On Thu, May 19, 2016 at 9:29 AM, FUJITA Tomonori wrote: >>> On Wed, 18 May 2016 15:03:06 + >>> "Tidwell, Ryan" wrote: &g

Re: [Ryu-devel] Potential python 3 incompatibility with Ryu BGP?

2016-05-18 Thread Takashi Yamamoto
On Thu, May 19, 2016 at 9:29 AM, FUJITA Tomonori wrote: > On Wed, 18 May 2016 15:03:06 + > "Tidwell, Ryan" wrote: > >> Thanks for the link Vikram. Good to know there's a fix out there. > > You need a release on pypi including the fixes for this issue now? yes. > > -

Re: [Ryu-devel] [PATCH v2] Ensure to terminate threads where RyuApp.start() gives a thread object

2015-12-17 Thread Takashi Yamamoto
On Wed, Dec 16, 2015 at 6:13 PM, IWAMOTO Toshihiro wrote: > Otherwise, AppManager.run_apps fails to terminate. > > Signed-off-by: IWAMOTO Toshihiro > --- > ryu/base/app_manager.py | 7 +++ > ryu/controller/ofp_handler.py | 3 ++- > ryu/services/protocols/bgp/app

Re: [Ryu-devel] [PATCH] Ensure to terminate threads where RyuApp.start() gives a thread object

2015-12-14 Thread Takashi Yamamoto
On Mon, Dec 14, 2015 at 5:57 PM, IWAMOTO Toshihiro wrote: > At Mon, 14 Dec 2015 17:38:40 +0900, > Takashi Yamamoto wrote: >> >> On Mon, Dec 14, 2015 at 5:31 PM, IWAMOTO Toshihiro >> wrote: >> > At Mon, 14 Dec 2015 17:19:28 +0900, >> > Takashi Yamamoto wr

Re: [Ryu-devel] [PATCH] Ensure to terminate threads where RyuApp.start() gives a thread object

2015-12-14 Thread Takashi Yamamoto
On Mon, Dec 14, 2015 at 5:00 PM, IWAMOTO Toshihiro wrote: > Otherwise, AppManager.run_apps fails to terminate. run_apps tries to kill threads in "services" by itself. can you explain why it isn't enough? > > Signed-off-by: IWAMOTO Toshihiro > --- > ryu/controller/ofp_handler.py |

Re: [Ryu-devel] [PATCH] Ensure to terminate threads where RyuApp.start() gives a thread object

2015-12-14 Thread Takashi Yamamoto
On Mon, Dec 14, 2015 at 5:31 PM, IWAMOTO Toshihiro wrote: > At Mon, 14 Dec 2015 17:19:28 +0900, > Takashi Yamamoto wrote: >> >> On Mon, Dec 14, 2015 at 5:00 PM, IWAMOTO Toshihiro >> wrote: >> > Otherwise, AppManager.run_apps fails to terminate. >> >>

Re: [Ryu-devel] [PATCH] remove old Ryu OpenStack plugin stuff

2015-09-23 Thread Takashi Yamamoto
iirc rest_qos is not usable without rest_conf_switch. On Mon, Sep 21, 2015 at 9:49 PM, FUJITA Tomonori wrote: > >From be8fec08bb013a567831b201dea2aad9985379b3 Mon Sep 17 00:00:00 2001 > From: FUJITA Tomonori > Date: Mon, 21 Sep 2015 21:46:19 +0900 > Subject: [PATCH] remove old Ryu OpenStack plug

Re: [Ryu-devel] Matching fields

2015-09-23 Thread Takashi Yamamoto
On Thu, Sep 24, 2015 at 10:04 AM, Anees Mohsin Hadi Al-Najjar wrote: > Dear All, > > > > I am writing my first Ryu controller using OpenFlow 1.3. > > > > When I write > > parser.OFPMatch(in_port=1, dl_type=0x806) > > there is an error which is “unknown match field dl_type” > > > > Please, How ca