[Ryu-devel] [PATCH] sw test tool: avoid test termination in initialization

2014-03-13 Thread watanabe.fumitaka
The initialization error of the flow tables causes forced termination of the test, and has become the hindrance of execution of other tests. This patch changes operation of the flow tables initialization error to avoid forced termination of the test. Signed-off-by: WATANABE Fumitaka --- ryu/

[Ryu-devel] [PATCH] sw test tool: fix missing to receive error of PacketOut

2014-02-24 Thread watanabe.fumitaka
Since transaction ID of PacketOut message is not hold, an error message to this PacketOut is not able to be received. This patch fixes it. Signed-off-by: WATANABE Fumitaka --- ryu/tests/switch/tester.py |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ryu/tests/switch/t

[Ryu-devel] [PATCH] sw test tool: add test report output

2014-02-18 Thread watanabe.fumitaka
Add following reports to the output of a switch test tool. This report outputs the test item of each error type, and the number of errors. --- Test report --- Added incorrect flows(3) action: set_field: 06_VLAN_VID ethernet/vlan(vid=100)/ipv4/tcp-->'vlan_vid=100,actions=set_field:2

[Ryu-devel] [PATCH] sw test tool: remove unnecessary debug code

2014-02-06 Thread watanabe.fumitaka
Signed-off-by: WATANABE Fumitaka --- ryu/tests/switch/tester.py |2 -- 1 file changed, 2 deletions(-) diff --git a/ryu/tests/switch/tester.py b/ryu/tests/switch/tester.py index 519a763..8556b52 100644 --- a/ryu/tests/switch/tester.py +++ b/ryu/tests/switch/tester.py @@ -877,8 +877,6 @@ class

[Ryu-devel] [PATCH] sw test tool: correct error message

2014-02-06 Thread watanabe.fumitaka
When test tool receives a malformed packet(length value is unusual, for example), detecting differences between expected and received is a failure. In this case, 'Internal error.' is not suitable as a log message and should notify tool receives a malformed packet. Signed-off-by: WATANABE Fumit

Re: [Ryu-devel] [PATCH] ofctl_v1_3: let action group can be converted to string

2014-02-06 Thread watanabe.fumitaka
Looks good to me. On Fri, 7 Feb 2014 00:06:33 +0800 Wei-Li Tang wrote: > Signed-off-by: Wei-Li Tang > --- > ryu/lib/ofctl_v1_3.py |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ryu/lib/ofctl_v1_3.py b/ryu/lib/ofctl_v1_3.py > index eb9585b..39d1366 100644 > --- a

[Ryu-devel] [PATCH] sw test tool: fix wrong match(ipv6_exthdr) value of test file

2014-02-06 Thread watanabe.fumitaka
The value of match(ipv6_exthdr) of the of13/match/39_IPV6_EXTHDR.json test file is wrong. The correct value matching to a ipv6(ext_hdrs=[hop_opts,auth]) is ipv6_exthdr=001000100=68. This patch corrects it. Signed-off-by: WATANABE Fumitaka --- ryu/tests/switch/of13/match/39_IPV6_EXTHDR.json |

[Ryu-devel] [PATCH] sw test tool: fix wrong instruction(write metadata) value of test files

2014-02-06 Thread watanabe.fumitaka
The value of instruction(write metadata) of the test file is wrong. In the table-miss test of of13/match/02_METADATA* test files, metadata=255 or 240(mask=0xf0) is specified as match. In order to make it table-miss, it needed to write metadata except 255. Signed-off-by: WATANABE Fumitaka --- r

Re: [Ryu-devel] [PATCH 2/2] ofproto_protocol: fix UnboundLocalError

2014-02-05 Thread watanabe.fumitaka
> def set_app_supported_versions(vers): > -_versions &= set(vers) > -assert _versions, 'No OpenFlow version is available' > +global _supported_versions > + > +_supported_versions &= set(vers) > +assert _supported_versions, 'No OpenFlow version is available' Hi, the ne

Re: [Ryu-devel] Queries on implementing rest_router.py

2014-01-19 Thread watanabe.fumitaka
Hi On the topology (1 Switch - 1 controller and 2 hosts), it works following commands and settings. -- * Runnning $ ryu-manager rest_router.py * Settings case switch's DPID=0001, hostA=10.10.10.0/24, hostB=192.168.10.0/24 $ curl -X POST -d '

[Ryu-devel] [PATCH v3] firewall: correct acquisition result of DENY rule

2014-01-06 Thread watanabe.fumitaka
v2 mail had a strange indent again... How is this patch ? And attach patch file to make sure. v2 -> v3 attach patch file. When blocked packet logging is enabled, GET rest command shows DENY rules as 'ALLOW' before. This patch improves it. Signed-off-by: WATANABE Fumitaka --- ryu/app/res

[Ryu-devel] [PATCH v2] firewall: correct acquisition result of DENY rule

2014-01-06 Thread watanabe.fumitaka
Sorry, by certain cause it seems that the indent of mail had shifted. Would you try on this patch? v1 -> v2 correct the indent of the mail When blocked packet logging is enabled, GET rest command shows DENY rules as 'ALLOW' before. This patch improves it. Signed-off-by: WATANABE Fumita

[Ryu-devel] [PATCH 0/2] bpdu: handling based on version and type

2014-01-06 Thread watanabe.fumitaka
In bpdu.py only one version was permitted with one type, before. This patch improves parser so that it may be based on multiple versions and types. WATANABE Fumitaka (2): bpdu: handling based on version and type test_bpdu: add unit test ryu/lib/packet/bpdu.py | 12 +- ryu/te

[Ryu-devel] [PATCH 2/2] test_bpdu: add unit test

2014-01-06 Thread watanabe.fumitaka
Signed-off-by: WATANABE Fumitaka --- ryu/tests/unit/packet/test_bpdu.py | 421 +++- 1 file changed, 418 insertions(+), 3 deletions(-) diff --git a/ryu/tests/unit/packet/test_bpdu.py b/ryu/tests/unit/packet/test_bpdu.py index 1d1ecac..1ef8cf5 100644 --- a/ryu/tes

[Ryu-devel] [PATCH 1/2] bpdu: handling based on version and type

2014-01-06 Thread watanabe.fumitaka
In bpdu.py only one version was permitted with one type, before. This patch improves parser so that it may be based on multiple versions and types. Signed-off-by: WATANABE Fumitaka --- ryu/lib/packet/bpdu.py | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/ryu

Re: [Ryu-devel] BPDU handling

2014-01-05 Thread watanabe.fumitaka
Hi, it should be operated with version and type, as your indication. I will send patch soon. thanks. On Sun, 29 Dec 2013 19:22:02 -0500 Nicholas Bastin wrote: > There seems to be a fundamental flaw in the assumption of how BPDUs can be > handled in packet/bpdu.py (or I'm completely misunders

[Ryu-devel] [PATCH] firewall: correct acquisition result of DENY rule

2014-01-05 Thread watanabe.fumitaka
Owing to the following patches, the acquisition result of the DENY rule became inaccurate. http://www.mail-archive.com/ryu-devel@lists.sourceforge.net/msg05255.html When blocked packet logging is enabled, GET rest command shows DENY rules as 'ALLOW'. This patch improves it. Signed-off-by: W

[Ryu-devel] [PATCH] firewall: packet blocking log for DENY rule

2013-12-26 Thread watanabe.fumitaka
rest_firewall outputs packet blocking log. However it was not output about DENY rules, it outputted only table-miss packets. This patch improves it. Signed-off-by: WATANABE Fumitaka --- ryu/app/rest_firewall.py | 61 +- 1 file changed, 44 insertion

[Ryu-devel] [PATCH v2] ofctl_v1_3: support metadata

2013-12-18 Thread watanabe.fumitaka
v1 -> v2 changes for pep8. Support metadata in FlowMod instructions and match. Please specify mod_flow_entry IF parameter as follows. flow = {'match': {'metadata': '12345/fff'}, 'actions': [ {'type': 'WRITE_METADATA', 'metadata': '12345',

[Ryu-devel] [PATCH] ofctl_v1_3: support metadata

2013-12-17 Thread watanabe.fumitaka
Support metadata in FlowMod instructions and match. Please specify mod_flow_entry IF parameter as follows. flow = {'match': {'metadata': '12345/fff'}, 'actions': [ {'type': 'WRITE_METADATA', 'metadata': '12345', 'metadata_mask': 'fff'}]}

[Ryu-devel] [PATCH] stplib: support OF 1.2/1.3

2013-12-09 Thread watanabe.fumitaka
ryu/lib/stplib.py : Support OpenFlow 1.2/1.3 ryu/app/simple_switch_stp.py : Correspondence to parameter change of stplib.EventPortStateChange Signed-off-by: WATANABE Fumitaka --- ryu/app/simple_switch_stp.py | 10 +-- ryu/lib/stplib.py| 173 --

[Ryu-devel] [PATCH] stplib: Reduction of the number of threads

2013-12-04 Thread watanabe.fumitaka
The number of threads was reduced for the simplification of processing. There was three sending BPDU threads before. - send Config BPDU thread - send TopologyChange BPDU thread - send TopologyChangeNotification BPDU thread They were unified to one thread. - send BPDU thread Signed-off-by:

Re: [Ryu-devel] STP application

2013-11-11 Thread watanabe.fumitaka
, 0 Mbps max OFPT_GET_CONFIG_REPLY (xid=0x4): frags=normal miss_send_len=0 On Tue, 12 Nov 2013 13:45:02 +0800 許珈榮 wrote: > hi~ > mininet> net > s2 <->h1-eth0 s3-eth1 > s3 <->s2-eth2 h4-eth0 > > > 2013/11/12 watanabe.fumitaka <mailto:watanabe.fumita...

Re: [Ryu-devel] STP application

2013-11-11 Thread watanabe.fumitaka
> > > > 2013/11/12 watanabe.fumitaka <mailto:watanabe.fumita...@gmail.com>> > > Hi, > > STP bridge needs one port at least. > Does your sw have a port? > > > thanks. > > > > > On Mon, 11 Nov 2013 18:50

Re: [Ryu-devel] STP application

2013-11-11 Thread watanabe.fumitaka
Hi, STP bridge needs one port at least. Does your sw have a port? thanks. On Mon, 11 Nov 2013 18:50:27 +0800 許珈榮 wrote: > hi guys, >another question. >Now i downloaded the simple_switch_stp.py >i type the command "ryu-manager ryu/app/simple_switch_stp.py" > below is error mes

Re: [Ryu-devel] rest_router.py AssertionError

2013-11-07 Thread watanabe.fumitaka
Hmm, the cause which becomes an AssertionError by dpset.py is not known. If the value of MAX_SUSPENDPACKETS is made low, what will happen? https://github.com/osrg/ryu/blob/master/ryu/app/rest_router.py#L113 MAX_SUSPENDPACKETS controls the number of ARP transmission. thanks. On Thu, 07 Nov 20

Re: [Ryu-devel] Loops in networks

2013-11-07 Thread watanabe.fumitaka
Hi, I have contributed the patch of stp to ryu before. http://sourceforge.net/mailarchive/message.php?msg_id=31438818 It may be helpful to you. However, it has not been merged into ryu yet. Thanks. On Wed, 06 Nov 2013 17:04:31 +0100 Aldas Dise wrote: > Hello, > > I have an OpenFlow network

Re: [Ryu-devel] [PATCH v2] ofproto_v1_3_parser: correct variable name same as spec

2013-10-29 Thread watanabe.fumitaka
00, "duration_sec": 0, "flow_count": 0, - "length": 56, + "len": 56, "meter_id": 100, "packet_in_count": 0 } -- 1.7.10.4 On Tue, 29 Oct 2013 21:49:33 +

[Ryu-devel] [PATCH] rest_router: bug fix of match parameter

2013-10-28 Thread watanabe.fumitaka
It was regarded as the list because of the unnecessary comma. Signed-off-by: WATANABE Fumitaka --- ryu/app/rest_router.py |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ryu/app/rest_router.py b/ryu/app/rest_router.py index 47840e9..ece4508 100644 --- a/ryu/app/rest_r

Re: [Ryu-devel] rest_router.py mac-address

2013-10-28 Thread watanabe.fumitaka
I also checked the patch working correctly. However, it seems that another bug still remains in the case of openflow1.0. I will correct it later as another patch. File "/home/ryu/OFC/src/router/rest_router.py", line 1575, in set_packetin_flow nw_proto=nw_proto, actions=actions) File

Re: [Ryu-devel] rest_router.py mac-address

2013-10-28 Thread watanabe.fumitaka
Hi, yamamoto. Is correction below correct with the new API? If satisfactory now, I will try test. --- a/ryu/app/rest_router.py +++ b/ryu/app/rest_router.py @@ -1764,13 +1764,9 @@ class OfCtl_v1_2(OfCtl): if dec_ttl: actions.append(ofp_parser.OFPActionDecNwTtl())

[Ryu-devel] [PATCH v2] ofproto_v1_3_parser: correct variable name same as spec

2013-10-28 Thread watanabe.fumitaka
v1 -> v2 rebase: patch against the latest git Signed-off-by: WATANABE Fumitaka --- ryu/ofproto/ofproto_v1_3_parser.py|9 + .../ofproto/json/of13/4-50-ofp_meter_stats_reply.packet.json |2 +- 2 files changed, 6 insertions(+), 5 deletions(-) diff --g

[Ryu-devel] [PATCH] ofproto_v1_3_parser: correct variable name according to spec

2013-10-24 Thread watanabe.fumitaka
Signed-off-by: WATANABE Fumitaka --- ryu/ofproto/ofproto_v1_3_parser.py|9 + .../ofproto/json/of13/4-50-ofp_meter_stats_reply.packet.json |2 +- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/ryu/ofproto/ofproto_v1_3_parser.py b/ryu/of

[Ryu-devel] [PATCH v5] add STP application

2013-09-23 Thread watanabe.fumitaka
Changes v4 -> v5 - stplib: Change of the notice method of topology change. An improvement of operation when a thread is started continuously. This application provides the simple example of spanning tree. "stplib" module controls exchange of BPDU packets and each bridge's port status

[Ryu-devel] [PATCH] rest_firewall: improve REST response

2013-09-17 Thread watanabe.fumitaka
Improvement of the REST response for basing more on JSON. example of get rules. before: { "switch_id: 0001": [ { "vlan_id: 634": { "rule_id: 1": { "actions": "ALLOW", "dl_vlan": 634, "dl_type": "ARP", "priority": 1 }

[Ryu-devel] [PATCH v4] add STP application

2013-09-11 Thread watanabe.fumitaka
Changes v3 -> v4 - stplib: bug fix of parameter of Stp._unregister_bridge() This application provides the simple example of spanning tree. "stplib" module controls exchange of BPDU packets and each bridge's port status(relay or block of frames). The module sends "EventTopologyChange" event wh

[Ryu-devel] [PATCH v3] add STP application

2013-09-10 Thread watanabe.fumitaka
Changes v2 -> v3 - Slight change of comment correction etc. This application provides the simple example of spanning tree. "stplib" module controls exchange of BPDU packets and each bridge's port status(relay or block of frames). The module sends "EventTopologyChange" event when the topology(t

[Ryu-devel] [PATCH v2] add STP application

2013-09-09 Thread watanabe.fumitaka
Changes v1 -> v2 - change a variable name into meaningful name. This application provides the simple example of spanning tree. "stplib" module controls exchange of BPDU packets and each bridge's port status(relay or block of frames). The module sends "EventTopologyChange" event when the topolo

[Ryu-devel] [PATCH 3/4] rest_firewall: remove of an unnecessary comma of json response

2013-09-09 Thread watanabe.fumitaka
Signed-off-by: WATANABE Fumitaka --- ryu/app/rest_firewall.py |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ryu/app/rest_firewall.py b/ryu/app/rest_firewall.py index 1ca6cad..13de0ac 100644 --- a/ryu/app/rest_firewall.py +++ b/ryu/app/rest_firewall.py @@ -802,7 +802,8 @

[Ryu-devel] [PATCH 4/4] rest_firewall: remove of unused constant values

2013-09-09 Thread watanabe.fumitaka
Signed-off-by: WATANABE Fumitaka --- ryu/app/rest_firewall.py |2 -- 1 file changed, 2 deletions(-) diff --git a/ryu/app/rest_firewall.py b/ryu/app/rest_firewall.py index 13de0ac..f8e4198 100644 --- a/ryu/app/rest_firewall.py +++ b/ryu/app/rest_firewall.py @@ -130,8 +130,6 @@ from ryu.ofprot

[Ryu-devel] [PATCH 0/4] rest_firewall: bug fix of handling an empty dict and some changes

2013-09-09 Thread watanabe.fumitaka
WATANABE Fumitaka (4): rest_firewall: bug fix of handling an empty dict rest_firewall: remove of a redundant code rest_firewall: remove of an unnecessary comma of json response rest_firewall: remove of unused constant values ryu/app/rest_firewall.py | 47 +++-

[Ryu-devel] [PATCH 2/4] rest_firewall: remove of a redundant code

2013-09-09 Thread watanabe.fumitaka
Signed-off-by: WATANABE Fumitaka --- ryu/app/rest_firewall.py | 40 1 file changed, 4 insertions(+), 36 deletions(-) diff --git a/ryu/app/rest_firewall.py b/ryu/app/rest_firewall.py index 0a23e03..1ca6cad 100644 --- a/ryu/app/rest_firewall.py +++ b/ryu/

[Ryu-devel] [PATCH 1/4] rest_firewall: bug fix of handling an empty dict

2013-09-09 Thread watanabe.fumitaka
Signed-off-by: WATANABE Fumitaka --- ryu/app/rest_firewall.py |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ryu/app/rest_firewall.py b/ryu/app/rest_firewall.py index b8919e9..0a23e03 100644 --- a/ryu/app/rest_firewall.py +++ b/ryu/app/rest_firewall.py @@ -452,7 +452,7 @@

[Ryu-devel] [PATCH] add STP application

2013-09-06 Thread watanabe.fumitaka
This application provides the simple example of spanning tree. "stplib" module controls exchange of BPDU packets and each bridge's port status(relay or block of frames). The module sends "EventTopologyChange" event when the topology(the route which relays frames) changed. "simple_switch_stp" mo

[Ryu-devel] [PATCH 1/2] ofctl v1.0/v1.2: add miss_send_len for packet in

2013-09-03 Thread watanabe.fumitaka
Signed-off-by: WATANABE Fumitaka --- ryu/lib/ofctl_v1_0.py |7 ++- ryu/lib/ofctl_v1_2.py |5 - 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/ryu/lib/ofctl_v1_0.py b/ryu/lib/ofctl_v1_0.py index e68d53e..0fd958c 100644 --- a/ryu/lib/ofctl_v1_0.py +++ b/ryu/lib/ofct

[Ryu-devel] [PATCH 2/2] rest_firewall: blocked packet logging

2013-09-03 Thread watanabe.fumitaka
Signed-off-by: WATANABE Fumitaka --- ryu/app/rest_firewall.py | 176 +- 1 file changed, 158 insertions(+), 18 deletions(-) diff --git a/ryu/app/rest_firewall.py b/ryu/app/rest_firewall.py index c547cb0..b8919e9 100644 --- a/ryu/app/rest_firewall.py ++

[Ryu-devel] [PATCH 0/2] rest_firewall: blocked packet logging

2013-09-03 Thread watanabe.fumitaka
Add blocked packet logging function and related REST API. and, logger format has been improved in relation to this. --- ryu/app/rest_firewall.py | 176 +- ryu/lib/ofctl_v1_0.py|7 +- ryu/lib/ofctl_v1_2.py|5 +- 3 files changed, 168 inse

[Ryu-devel] [PATCH] bpdu.py: add some constant values

2013-09-02 Thread watanabe.fumitaka
Signed-off-by: WATANABE Fumitaka --- ryu/lib/packet/bpdu.py |9 + 1 file changed, 9 insertions(+) diff --git a/ryu/lib/packet/bpdu.py b/ryu/lib/packet/bpdu.py index 0c293cd..91aefa2 100644 --- a/ryu/lib/packet/bpdu.py +++ b/ryu/lib/packet/bpdu.py @@ -145,6 +145,15 @@ TYPE_TOPOLOGY_CH

[Ryu-devel] [PATCH] rest_firewall: bug fix of dict keyError

2013-09-02 Thread watanabe.fumitaka
Signed-off-by: WATANABE Fumitaka --- ryu/app/rest_firewall.py |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ryu/app/rest_firewall.py b/ryu/app/rest_firewall.py index ef4136a..c547cb0 100644 --- a/ryu/app/rest_firewall.py +++ b/ryu/app/rest_firewall.py @@ -629,7 +629,7

[Ryu-devel] [PATCH] bpdu.py: use text address

2013-08-28 Thread watanabe.fumitaka
Signed-off-by: WATANABE Fumitaka --- ryu/lib/packet/bpdu.py |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ryu/lib/packet/bpdu.py b/ryu/lib/packet/bpdu.py index ee2940b..0c293cd 100644 --- a/ryu/lib/packet/bpdu.py +++ b/ryu/lib/packet/bpdu.py @@ -134,7 +134,7 @@ from ryu.l

[Ryu-devel] [PATCH] llc.py: correct a variable name

2013-08-28 Thread watanabe.fumitaka
Signed-off-by: WATANABE Fumitaka --- ryu/lib/packet/llc.py|4 ++-- ryu/tests/unit/packet/test_packet.py | 10 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/ryu/lib/packet/llc.py b/ryu/lib/packet/llc.py index 2a0926c..7601dce 100644 --- a/ryu/lib/p

[Ryu-devel] [PATCH v5 2/3] packet lib to string: add __str__ to base

2013-08-04 Thread watanabe.fumitaka
Signed-off-by: WATANABE Fumitaka --- ryu/lib/packet/packet.py |4 1 file changed, 4 insertions(+) diff --git a/ryu/lib/packet/packet.py b/ryu/lib/packet/packet.py index f80948a..785a28b 100644 --- a/ryu/lib/packet/packet.py +++ b/ryu/lib/packet/packet.py @@ -127,3 +127,7 @@ class Packet

[Ryu-devel] [PATCH v5 3/3] packet lib to string: unit tests

2013-08-04 Thread watanabe.fumitaka
Signed-off-by: WATANABE Fumitaka --- ryu/tests/unit/packet/test_dhcp.py | 111 +++ ryu/tests/unit/packet/test_icmp.py | 67 + ryu/tests/unit/packet/test_icmpv6.py | 75 ++ ryu/tests/unit/packet/test_ipv6.py | 65 + ryu/tests/unit/packet/test_lldp.p

[Ryu-devel] [PATCH v5 0/3] packet lib to string

2013-08-04 Thread watanabe.fumitaka
Changes v4 -> v5 - Not adding individual string conversion process because it was solved by 'ryu.lib.addrconv' patch. Add conversion to string of all member variable of each packet library. --- ryu/lib/packet/dhcp.py |6 +- ryu/lib/packet/icmp.py |7 +- r

[Ryu-devel] [PATCH v5 1/3] packet lib to string: inherits StringifyMixin

2013-08-04 Thread watanabe.fumitaka
Some class inherits stringify.StringifyMixin and, remove class variable 'tlvs' (not used as class variable and interferes to string) from lldp.lldp Signed-off-by: WATANABE Fumitaka --- ryu/lib/packet/dhcp.py|6 -- ryu/lib/packet/icmp.py|7 --- ryu/lib/packet/icm

Re: [Ryu-devel] sflow

2013-07-24 Thread watanabe.fumitaka
Hi, This is a sample driver of sflow parser. Please use as follows. $ ryu-manager sFlow_collector.py sFlow_collector.py import gflags import socket from ryu.base import app_manager from ryu.lib import hub from ryu.lib.xflow import sflow FLAGS = gflags

[Ryu-devel] [PATCH v4 2/3] packet lib to string: add an individual conversion

2013-07-24 Thread watanabe.fumitaka
Add an individual conversion process. Some class inherits packet_base.StringifyMixin and, remove class variable 'tlvs' (not used as class variable and interferes to string) from lldp.lldp Signed-off-by: WATANABE Fumitaka --- ryu/lib/packet/arp.py |7 +++ ryu/lib/packet/dhcp.py

[Ryu-devel] [PATCH v4 3/3] packet lib to string: unit tests

2013-07-24 Thread watanabe.fumitaka
Signed-off-by: WATANABE Fumitaka --- ryu/tests/unit/packet/test_dhcp.py | 111 ++ ryu/tests/unit/packet/test_icmp.py | 67 +++ ryu/tests/unit/packet/test_icmpv6.py | 77 ryu/tests/unit/packet/test_ipv6.py | 65 +++ ryu/tests/unit/packet/te

[Ryu-devel] [PATCH v4 1/3] packet lib to string: add __str__ to base

2013-07-24 Thread watanabe.fumitaka
Signed-off-by: WATANABE Fumitaka --- ryu/lib/packet/packet.py |4 ryu/lib/packet/packet_base.py | 38 +- 2 files changed, 41 insertions(+), 1 deletion(-) diff --git a/ryu/lib/packet/packet.py b/ryu/lib/packet/packet.py index f80948a..785a28b 10

[Ryu-devel] [PATCH v4 0/3] packet library to string

2013-07-24 Thread watanabe.fumitaka
Changes v3 -> v4 - String conversion rule changes into the class attribute. - Improvement of unit tests (not be dependent on environment). Add conversion to string of all member variable of each packet library. It comes into effect by inheriting packet_base.StringifyMixin --- ryu/lib/packet/ar

[Ryu-devel] [PATCH 3/5] link to LLC sub layer

2013-07-22 Thread watanabe.fumitaka
Signed-off-by: WATANABE Fumitaka --- ryu/lib/packet/ethernet.py | 12 ryu/lib/packet/vlan.py | 16 ryu/ofproto/ether.py |1 + 3 files changed, 29 insertions(+) diff --git a/ryu/lib/packet/ethernet.py b/ryu/lib/packet/ethernet.py index 3db0e16..83cc

[Ryu-devel] [PATCH 5/5] add unit test

2013-07-22 Thread watanabe.fumitaka
Signed-off-by: WATANABE Fumitaka --- ryu/tests/unit/packet/test_packet.py | 94 ++ 1 file changed, 94 insertions(+) diff --git a/ryu/tests/unit/packet/test_packet.py b/ryu/tests/unit/packet/test_packet.py index 6ddb05d..516c1ee 100644 --- a/ryu/tests/unit/packe

[Ryu-devel] [PATCH 4/5] update library_packet_ref.rst

2013-07-22 Thread watanabe.fumitaka
Signed-off-by: WATANABE Fumitaka --- doc/source/library_packet_ref.rst | 18 ++ 1 file changed, 18 insertions(+) diff --git a/doc/source/library_packet_ref.rst b/doc/source/library_packet_ref.rst index 301bad4..7fb602e 100644 --- a/doc/source/library_packet_ref.rst +++ b/doc/s

[Ryu-devel] [PATCH 1/5] lib/packet/bpdu

2013-07-22 Thread watanabe.fumitaka
Signed-off-by: WATANABE Fumitaka --- ryu/lib/packet/bpdu.py | 473 1 file changed, 473 insertions(+) create mode 100644 ryu/lib/packet/bpdu.py diff --git a/ryu/lib/packet/bpdu.py b/ryu/lib/packet/bpdu.py new file mode 100644 index 000..8e317

[Ryu-devel] [PATCH 2/5] lib/packet/llc

2013-07-22 Thread watanabe.fumitaka
Signed-off-by: WATANABE Fumitaka --- ryu/lib/packet/llc.py | 315 + 1 file changed, 315 insertions(+) create mode 100644 ryu/lib/packet/llc.py diff --git a/ryu/lib/packet/llc.py b/ryu/lib/packet/llc.py new file mode 100644 index 000..5af62ea

[Ryu-devel] [PATCH 0/5] add STP packet library

2013-07-22 Thread watanabe.fumitaka
Add LLC and BPDU packet library for STP(spanning tree protocol). --- doc/source/library_packet_ref.rst| 18 ++ ryu/lib/packet/bpdu.py | 473 ++ ryu/lib/packet/ethernet.py | 12 + ryu/lib/packet/llc.py| 315 +

Re: [Ryu-devel] [PATCH v3 1/3] packet lib to string: add __str__ to base

2013-07-19 Thread watanabe.fumitaka
ring base class's convertion rules) But it is static I think too, so I grope for a good method. thanks. (2013年07月19日 16:09), yamah...@valinux.co.jp wrote: > On Fri, Jul 19, 2013 at 01:54:37PM +0900, watanabe.fumitaka wrote: >> Signed-off-by: WATANABE Fumitaka >> ---

[Ryu-devel] [PATCH v3 3/3] packet lib to string: unit tests

2013-07-18 Thread watanabe.fumitaka
Signed-off-by: WATANABE Fumitaka --- ryu/tests/unit/packet/test_dhcp.py | 107 ryu/tests/unit/packet/test_icmp.py | 63 ryu/tests/unit/packet/test_icmpv6.py | 64 ryu/tests/unit/packet/test_ipv6.py | 64 ryu/tests/unit/packe

[Ryu-devel] [PATCH v3 0/3] packet library to string

2013-07-18 Thread watanabe.fumitaka
Add conversion to string of all member variable of each packet library. It comes into effect by inheriting packet_base.StringifyMixin --- ryu/lib/packet/arp.py|8 ++ ryu/lib/packet/dhcp.py | 20 +++- ryu/lib/packet/ethernet.py |7 ++ ryu/lib/pack

[Ryu-devel] [PATCH v3 1/3] packet lib to string: add __str__ to base

2013-07-18 Thread watanabe.fumitaka
Signed-off-by: WATANABE Fumitaka --- ryu/lib/packet/packet.py |4 ryu/lib/packet/packet_base.py | 23 ++- 2 files changed, 26 insertions(+), 1 deletion(-) diff --git a/ryu/lib/packet/packet.py b/ryu/lib/packet/packet.py index f80948a..785a28b 100644 --- a/ryu/

[Ryu-devel] [PATCH v3 2/3] packet lib to string: add an individual conversion

2013-07-18 Thread watanabe.fumitaka
Add an individual conversion process. Some class inherits packet_base.StringifyMixin and, remove class variable 'tlvs' (not used as class variable and interferes to string) from lldp.lldp Signed-off-by: WATANABE Fumitaka --- ryu/lib/packet/arp.py |8 ryu/lib/packet/dhcp.py

[Ryu-devel] [PATCH v5 1/2] add ICMP sub encoder/decoder class

2013-06-24 Thread watanabe.fumitaka
Add ICMP sub encoder/decoder class for Destination Unreachable Message. and, add parser to Time Exceeded Message class. Signed-off-by: WATANABE Fumitaka --- ryu/lib/packet/icmp.py | 113 +--- 1 file changed, 107 insertions(+), 6 deletions(-) diff --

[Ryu-devel] [PATCH v5 0/2] add router Ryu application

2013-06-24 Thread watanabe.fumitaka
This update(v4->v5) contains the following changes. icmp.py: Improvement _PACK_STR for 'unused' variables. rest_router.py: Improvement of the log format configuring. Delete unnecessary exception raising. Dispatching packet type pushed down into VlanRouter class. This patch impleme

Re: [Ryu-devel] [PATCH 08/19] ofctl_v1_2.actions_to_str: ignore unknown instructions

2013-06-20 Thread watanabe.fumitaka
Hi, >> can someone familiar with rest_firewall.py take a look? I will send the following patch, when another patch of rest_firewall.py I sent before is applied. thanks. --- ryu/app/rest_firewall.py | 38 +++--- 1 file changed, 31 insertions(+), 7 deletion

[Ryu-devel] [PATCH v4 0/2] add router Ryu application

2013-06-19 Thread watanabe.fumitaka
This update(v3->v4) contains the following changes. icmp.py: Update document of some attributes. Drop unused attribute. rest_router.py: Improvement of a functional assignment about RouterController, Router and VlanRouter class. Improvement of the thread leak. Add sleep proces

[Ryu-devel] [PATCH v4 1/2] add ICMP sub encoder/decoder class

2013-06-19 Thread watanabe.fumitaka
Add ICMP sub encoder/decoder class for Destination Unreachable Message. and, add parser to TimeExceeded class. Signed-off-by: WATANABE Fumitaka --- ryu/lib/packet/icmp.py | 117 +--- 1 file changed, 111 insertions(+), 6 deletions(-) diff --git a/ryu

Re: [Ryu-devel] [PATCH v2 0/5] add conversion tostring to packet library

2013-06-13 Thread watanabe.fumitaka
hi, > i moved the code around for non-ofproto users in my tree. > https://github.com/yamt/ryu/blob/stringify6/ryu/lib/stringify.py I will use stringify.py Is there any schedule which contributeds patch to ryu-devel? thanks. (2013/06/13 17:45), YAMAMOTO Takashi wrote: > hi, > >> this upd

[Ryu-devel] [PATCH v2 3/5] lib/packet/packet: use of tostring function

2013-06-13 Thread watanabe.fumitaka
Signed-off-by: WATANABE Fumitaka --- ryu/lib/packet/packet.py |9 + 1 file changed, 9 insertions(+) diff --git a/ryu/lib/packet/packet.py b/ryu/lib/packet/packet.py index d6aeed7..fb69e7c 100644 --- a/ryu/lib/packet/packet.py +++ b/ryu/lib/packet/packet.py @@ -125,3 +125,12 @@ class

[Ryu-devel] [PATCH v2 4/5] ofproto/ofproto_parser: add string conversion

2013-06-13 Thread watanabe.fumitaka
Signed-off-by: WATANABE Fumitaka --- ryu/ofproto/ofproto_parser.py |5 + 1 file changed, 5 insertions(+) diff --git a/ryu/ofproto/ofproto_parser.py b/ryu/ofproto/ofproto_parser.py index 73a6d9e..86c00d0 100644 --- a/ryu/ofproto/ofproto_parser.py +++ b/ryu/ofproto/ofproto_parser.py @@ -62

[Ryu-devel] [PATCH v2 5/5] lib/packet/ethernet and ipv4: add an individual conversion

2013-06-13 Thread watanabe.fumitaka
Add an individual conversion process to ethernet.py and ipv4.py Individual conversion is needed to the variable it cannot be understood that does not conversion, like MAC address or IP address. and it is required for other packet libraries. Signed-off-by: WATANABE Fumitaka --- ryu/lib/packet/

[Ryu-devel] [PATCH v2 2/5] lib/packet/icmp: inherit StringifyMixin

2013-06-13 Thread watanabe.fumitaka
To inherit StringifyMixin is required for other packet libraries like icmpv6.echo which does not inherit PacketBase, too. Signed-off-by: WATANABE Fumitaka --- ryu/lib/packet/icmp.py |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ryu/lib/packet/icmp.py b/ryu/lib/pack

[Ryu-devel] [PATCH v2 1/5] lib/packet/packet_base: inherit StringifyMixin

2013-06-13 Thread watanabe.fumitaka
Signed-off-by: WATANABE Fumitaka --- ryu/lib/packet/packet_base.py |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/ryu/lib/packet/packet_base.py b/ryu/lib/packet/packet_base.py index b0aeca0..ee573da 100644 --- a/ryu/lib/packet/packet_base.py +++ b/ryu/lib/packet/pack

[Ryu-devel] [PATCH v2 0/5] add conversion tostring to packet library

2013-06-13 Thread watanabe.fumitaka
add conversion to string of all member variable of each packet library. this patch is Based heavily on commit 2ef1107: ryu/ofproto/ofproto_parser.py by YAMAMOTO Takashi. Sample of an output. ethernet(src='ff:ff:ff:ff:ff:ff',ethertype='0x0806',dst='ff:ff:ff:ff:ff:ff') ipv4(src='131.151.32.21'

[Ryu-devel] [PATCH v2] app/rest_firewall: add API for VLAN configuration

2013-06-12 Thread watanabe.fumitaka
add REST-API for VLAN configuration of rest_firewall application. it implements handling each vlan groups separately. This update(v1->v2) contains the following change. make function of conversion of cookie and ruleID for easily understanding. Signed-off-by: WATANABE Fumitaka --- ryu/app/re

Re: [Ryu-devel] [PATCH 3/3] lib/packet/ethernet and ipv4: add an individual conversion

2013-06-06 Thread watanabe.fumitaka
1:58:19PM +0900, watanabe.fumitaka wrote: >> Add an individual conversion process to ethernet.py and ipv4.py >> >> Individual conversion is needed to the variable it cannot be >> understood that does not conversion, like MAC address or IP address. >> >> and it is required

Re: [Ryu-devel] [PATCH 1/3] lib/packet/packet_base: add tostring function

2013-06-06 Thread watanabe.fumitaka
4PM +0900, watanabe.fumitaka wrote: >> >> Signed-off-by: WATANABE Fumitaka >> --- >> ryu/lib/packet/packet_base.py | 18 ++ >> 1 file changed, 18 insertions(+) >> >> diff --git a/ryu/lib/packet/packet_base.py b/ryu/lib/packet/packet_base.py >&

[Ryu-devel] [PATCH 3/3] lib/packet/ethernet and ipv4: add an individual conversion

2013-06-04 Thread watanabe.fumitaka
Add an individual conversion process to ethernet.py and ipv4.py Individual conversion is needed to the variable it cannot be understood that does not conversion, like MAC address or IP address. and it is required for other packet libraries. Signed-off-by: WATANABE Fumitaka --- ryu/lib/packet/

[Ryu-devel] [PATCH 0/3] add conversion tostring to packet library

2013-06-04 Thread watanabe.fumitaka
add conversion to string of all member variable of each packet library. It comes into effect by inheriting packet_base.PacketBase this patch is Based heavily on commit 2ef1107: ryu/ofproto/ofproto_parser.py by YAMAMOTO Takashi. The following is a sample of an output. ethernet(src='ff:ff:ff:ff

[Ryu-devel] [PATCH 2/3] lib/packet/packet: use of tostring function

2013-06-04 Thread watanabe.fumitaka
Signed-off-by: WATANABE Fumitaka --- ryu/lib/packet/packet.py |9 + 1 file changed, 9 insertions(+) diff --git a/ryu/lib/packet/packet.py b/ryu/lib/packet/packet.py index 84e5bf8..23b5ac5 100644 --- a/ryu/lib/packet/packet.py +++ b/ryu/lib/packet/packet.py @@ -95,3 +95,12 @@ class P

[Ryu-devel] [PATCH 1/3] lib/packet/packet_base: add tostring function

2013-06-04 Thread watanabe.fumitaka
Signed-off-by: WATANABE Fumitaka --- ryu/lib/packet/packet_base.py | 18 ++ 1 file changed, 18 insertions(+) diff --git a/ryu/lib/packet/packet_base.py b/ryu/lib/packet/packet_base.py index b0aeca0..07b5253 100644 --- a/ryu/lib/packet/packet_base.py +++ b/ryu/lib/packet/packet

[Ryu-devel] [PATCH] app/rest_firewall: add API for VLAN configuration

2013-06-03 Thread watanabe.fumitaka
add REST-API for VLAN configuration of rest_firewall application. it implements handling each vlan groups separately. Signed-off-by: WATANABE Fumitaka --- ryu/app/rest_firewall.py | 291 -- 1 file changed, 229 insertions(+), 62 deletions(-) diff --g

[Ryu-devel] [PATCH v3 0/2] add router Ryu application

2013-05-29 Thread watanabe.fumitaka
This update(v2->v3) contains the following changes. icmp.py: add super().__init__() at __init__. rest_router.py: edit for pylint. This patch implements router Ryu application. packet is forwarded on the static routing table. The routing table can be set up by the REST commands. and,

[Ryu-devel] [PATCH v3 1/2] add ICMP sub encoder/decoder class

2013-05-29 Thread watanabe.fumitaka
Add ICMP sub encoder/decoder class for Destination Unreachable Message and Time Exceeded Message. Signed-off-by: WATANABE Fumitaka --- ryu/lib/packet/icmp.py | 109 1 file changed, 109 insertions(+) diff --git a/ryu/lib/packet/icmp.py b/ryu/li

[Ryu-devel] [PATCH v2 0/2] add router Ryu application

2013-05-27 Thread watanabe.fumitaka
This update(v1->v2) contains the following changes for rest_router.py edit for pylint and some improvement of a form. use ryuException. This patch implements router Ryu application. packet is forwarded on the static routing table. The routing table can be set up by the REST commands. and, Rout

[Ryu-devel] [PATCH v2 1/2] add ICMP sub encoder/decoder class

2013-05-27 Thread watanabe.fumitaka
Add ICMP sub encoder/decoder class for Destination Unreachable Message and Time Exceeded Message. Signed-off-by: WATANABE Fumitaka --- ryu/lib/packet/icmp.py | 106 1 file changed, 106 insertions(+) diff --git a/ryu/lib/packet/icmp.py b/ryu/li

[Ryu-devel] [PATCH 0/2] add router Ryu application

2013-05-24 Thread watanabe.fumitaka
This patch implements router Ryu application. packet is forwarded on the static routing table. The routing table can be set up by the REST commands. and, Router can handle each vlan groups separately. * Example case: Set static route on vlanID=10

[Ryu-devel] [PATCH 2/2] add ICMP sub encoder/decoder class

2013-05-24 Thread watanabe.fumitaka
Add ICMP sub encoder/decoder class for Destination Unreachable Message and Time Exceeded Message. Signed-off-by: WATANABE Fumitaka --- ryu/lib/packet/icmp.py | 106 1 file changed, 106 insertions(+) diff --git a/ryu/lib/packet/icmp.py b/ryu/li

Re: [Ryu-devel] Getting Ryu REST Firewall Service to work with LINC

2013-04-15 Thread watanabe.fumitaka
<0.0.0.789>}, > 0, > {ofp_match,[{ofp_field,openflow_basic,eth_src,false, > <<18,52,86,120,154,188>>, > undefined}]}, > <<0,0,0,0,0,0,0,1>

Re: [Ryu-devel] Getting Ryu REST Firewall Service to work with LINC

2013-04-14 Thread watanabe.fumitaka
Hello Shivaram, > 1. I could not delete an installed rule Please send command as follows. curl -X DELETE -d '{"rule_id":"1"}' http://localhost:8080/firewall/rules/0001 curl -X DELETE -d '{"rule_id":"all"}' http://localhost:8080/firewall/rules/0001 > 2. When I try

Re: [Ryu-devel] [PATCH] ryu/app/rest_firewall.py: handling of no switch connection

2013-04-10 Thread watanabe.fumitaka
Switch > Features reply was sent, but, not shown on console when I use the REST > service. But, this is received when I just run Ryu without REST service. > > Can you suggest a couple of places where I can put a few debug messages so > that we can get a better trace? > > thanks

  1   2   >