Re: [Ryu-devel] [PATCH] controller: fix that sender thread is never terminated

2013-02-23 Thread FUJITA Tomonori
On Thu, 21 Feb 2013 17:17:20 +0900 YAMADA Hideki wrote: > hi, > > (2013/02/21 16:17), YAMAMOTO Takashi wrote: >> hi, >> >>> Empty send_q.get() is blocking send thread. >>> Because of this issue, datapath state never transit to DEAD. >> >> oops, sorry. >> probably it's better to just leave it for

Re: [Ryu-devel] [PATCH] controller: fix that sender thread is never terminated

2013-02-21 Thread YAMADA Hideki
There is some thing wrong. Perhaps line feed code problem. Please apply attached patch. (2013/02/21 17:17), YAMADA Hideki wrote: hi, (2013/02/21 16:17), YAMAMOTO Takashi wrote: hi, Empty send_q.get() is blocking send thread. Because of this issue, datapath state never transit to DEAD. oop

Re: [Ryu-devel] [PATCH] controller: fix that sender thread is never terminated

2013-02-21 Thread YAMAMOTO Takashi
hi, > hi, > > (2013/02/21 16:17), YAMAMOTO Takashi wrote: >> hi, >> >>> Empty send_q.get() is blocking send thread. >>> Because of this issue, datapath state never transit to DEAD. >> >> oops, sorry. >> probably it's better to just leave it for gc? >> > I think so, too. > How about following? lo

Re: [Ryu-devel] [PATCH] controller: fix that sender thread is never terminated

2013-02-21 Thread YAMADA Hideki
hi, (2013/02/21 16:17), YAMAMOTO Takashi wrote: > hi, > >> Empty send_q.get() is blocking send thread. >> Because of this issue, datapath state never transit to DEAD. > > oops, sorry. > probably it's better to just leave it for gc? > I think so, too. How about following? From 08126332a9d3d59af8

Re: [Ryu-devel] [PATCH] controller: fix that sender thread is never terminated

2013-02-20 Thread YAMAMOTO Takashi
hi, > Empty send_q.get() is blocking send thread. > Because of this issue, datapath state never transit to DEAD. oops, sorry. probably it's better to just leave it for gc? YAMAMOTO Takashi > > This fixes commit 83e3709a0d70f889e794d1c5f70c1c1eb73075f7. > - controller: fix send_q draining >

[Ryu-devel] [PATCH] controller: fix that sender thread is never terminated

2013-02-20 Thread YAMADA Hideki
Empty send_q.get() is blocking send thread. Because of this issue, datapath state never transit to DEAD. This fixes commit 83e3709a0d70f889e794d1c5f70c1c1eb73075f7. - controller: fix send_q draining https://github.com/osrg/ryu/commit/83e3709a0d70f889e794d1c5f70c1c1eb73075f7 Signed-off-by: Y