Re: [Ryu-devel] [PATCH 1/2] xflow: add netflow packet collector

2013-02-05 Thread OHMURA Kei
2013/2/5 OHMURA Kei : >>> + >>> +def close(self): >>> +self.is_active = False >>> +gevent.joinall([self.thread]) >> >> For what? > > I think that it's not necessary. I'll remove it. > >> >>> +def _recv_loop(self): >>> +while self.is_active: >>> +(data, ad

Re: [Ryu-devel] [PATCH 1/2] xflow: add netflow packet collector

2013-02-05 Thread OHMURA Kei
Thanks for your comments. 2013/2/5 FUJITA Tomonori : > On Tue, 5 Feb 2013 18:40:12 +0900 > OHMURA Kei wrote: > >> This gets a netflow packet and sends it to the other >> applications. Each application can use this to get netflow >> messages as an event. >> >> Signed-off-by: OHMURA Kei >> --- >>

Re: [Ryu-devel] [PATCH 1/2] xflow: add netflow packet collector

2013-02-05 Thread FUJITA Tomonori
On Tue, 5 Feb 2013 18:40:12 +0900 OHMURA Kei wrote: > This gets a netflow packet and sends it to the other > applications. Each application can use this to get netflow > messages as an event. > > Signed-off-by: OHMURA Kei > --- > bin/ryu-manager|1 + > ryu/lib/xflow/ne

[Ryu-devel] [PATCH 1/2] xflow: add netflow packet collector

2013-02-05 Thread OHMURA Kei
This gets a netflow packet and sends it to the other applications. Each application can use this to get netflow messages as an event. Signed-off-by: OHMURA Kei --- bin/ryu-manager|1 + ryu/lib/xflow/netflow_collector.py | 64 2 files

[Ryu-devel] [PATCH 1/2] xflow: add netflow packet collector

2013-02-05 Thread OHMURA Kei
This gets a netflow packet and sends it to the other applications. Each application can use this to get netflow messages as an event. Signed-off-by: OHMURA Kei --- bin/ryu-manager|1 + ryu/lib/xflow/netflow_collector.py | 64 2 files