Re: [Ryu-devel] [PATCH 1/3] Pass AppManager module name instead of class name

2012-06-09 Thread FUJITA Tomonori
On Sat, 9 Jun 2012 20:03:48 +0900 Isaku Yamahata wrote: > I commented about double underscore. Except '__', the patch series looks good. > Reviewed-by: Isaku Yamahata Thanks, I fixed the function name and applied the patchset. ---

Re: [Ryu-devel] [PATCH 1/3] Pass AppManager module name instead of class name

2012-06-09 Thread Isaku Yamahata
On Sat, Jun 09, 2012 at 07:53:20PM +0900, FUJITA Tomonori wrote: > On Sat, 9 Jun 2012 19:47:38 +0900 > Isaku Yamahata wrote: > > > On Sat, Jun 09, 2012 at 07:29:47PM +0900, FUJITA Tomonori wrote: > >> On Sat, 9 Jun 2012 19:27:12 +0900 > >> Isaku Yamahata wrote: > >> > >> > On Sat, Jun 09, 2012

Re: [Ryu-devel] [PATCH 1/3] Pass AppManager module name instead of class name

2012-06-09 Thread Isaku Yamahata
On Sat, Jun 09, 2012 at 07:47:17PM +0900, FUJITA Tomonori wrote: > On Sat, 9 Jun 2012 19:30:07 +0900 > Isaku Yamahata wrote: > > > On Sat, Jun 09, 2012 at 07:06:21PM +0900, FUJITA Tomonori wrote: > > > RyuApp class is used as a base class for Ryu network application. So > > > let's pass Ryu appli

Re: [Ryu-devel] [PATCH 1/3] Pass AppManager module name instead of class name

2012-06-09 Thread FUJITA Tomonori
On Sat, 9 Jun 2012 19:47:38 +0900 Isaku Yamahata wrote: > On Sat, Jun 09, 2012 at 07:29:47PM +0900, FUJITA Tomonori wrote: >> On Sat, 9 Jun 2012 19:27:12 +0900 >> Isaku Yamahata wrote: >> >> > On Sat, Jun 09, 2012 at 07:06:21PM +0900, FUJITA Tomonori wrote: >> >> RyuApp class is used as a base

Re: [Ryu-devel] [PATCH 1/3] Pass AppManager module name instead of class name

2012-06-09 Thread Isaku Yamahata
On Sat, Jun 09, 2012 at 07:29:47PM +0900, FUJITA Tomonori wrote: > On Sat, 9 Jun 2012 19:27:12 +0900 > Isaku Yamahata wrote: > > > On Sat, Jun 09, 2012 at 07:06:21PM +0900, FUJITA Tomonori wrote: > >> RyuApp class is used as a base class for Ryu network application. So > >> let's pass Ryu applica

Re: [Ryu-devel] [PATCH 1/3] Pass AppManager module name instead of class name

2012-06-09 Thread FUJITA Tomonori
On Sat, 9 Jun 2012 19:30:07 +0900 Isaku Yamahata wrote: > On Sat, Jun 09, 2012 at 07:06:21PM +0900, FUJITA Tomonori wrote: > > RyuApp class is used as a base class for Ryu network application. So > > let's pass Ryu application module name instead of class name. > > > > Signed-off-by: FUJITA Tomo

Re: [Ryu-devel] [PATCH 1/3] Pass AppManager module name instead of class name

2012-06-09 Thread Isaku Yamahata
On Sat, Jun 09, 2012 at 07:06:21PM +0900, FUJITA Tomonori wrote: > RyuApp class is used as a base class for Ryu network application. So > let's pass Ryu application module name instead of class name. > > Signed-off-by: FUJITA Tomonori > --- > bin/ryu-manager |5 ++--- > ryu/base/app_

Re: [Ryu-devel] [PATCH 1/3] Pass AppManager module name instead of class name

2012-06-09 Thread FUJITA Tomonori
On Sat, 9 Jun 2012 19:27:12 +0900 Isaku Yamahata wrote: > On Sat, Jun 09, 2012 at 07:06:21PM +0900, FUJITA Tomonori wrote: >> RyuApp class is used as a base class for Ryu network application. So >> let's pass Ryu application module name instead of class name. > > The patch assumes that the .py f

Re: [Ryu-devel] [PATCH 1/3] Pass AppManager module name instead of class name

2012-06-09 Thread Isaku Yamahata
On Sat, Jun 09, 2012 at 07:06:21PM +0900, FUJITA Tomonori wrote: > RyuApp class is used as a base class for Ryu network application. So > let's pass Ryu application module name instead of class name. The patch assumes that the .py file contains only single RyuApp class. What if more than one RyuAp

[Ryu-devel] [PATCH 1/3] Pass AppManager module name instead of class name

2012-06-09 Thread FUJITA Tomonori
RyuApp class is used as a base class for Ryu network application. So let's pass Ryu application module name instead of class name. Signed-off-by: FUJITA Tomonori --- bin/ryu-manager |5 ++--- ryu/base/app_manager.py | 17 +++-- 2 files changed, 17 insertions(+), 5 delet