> On Fri, May 10, 2013 at 10:17:28AM +0900, YAMAMOTO Takashi wrote:
>> > Hi. Basically tests looks good.
>> > nose.tools.assert_xxx should be used instead of assert.
>>
>> why?
>
> For consistency. It seems other tests use nose.tools.*.
then you prefer eq_ than assert_xxx?
> Since this test con
On Fri, May 10, 2013 at 10:17:28AM +0900, YAMAMOTO Takashi wrote:
> > Hi. Basically tests looks good.
> > nose.tools.assert_xxx should be used instead of assert.
>
> why?
For consistency. It seems other tests use nose.tools.*.
Since this test consistently uses assert, I don't claim so strongly.
> Hi. Basically tests looks good.
> nose.tools.assert_xxx should be used instead of assert.
why?
YAMAMOTO Takashi
>
> thanks,
--
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive n
Hi. Basically tests looks good.
nose.tools.assert_xxx should be used instead of assert.
thanks,
On Wed, May 08, 2013 at 03:32:37PM +0900, YAMAMOTO Takashi wrote:
>
> Signed-off-by: YAMAMOTO Takashi
> ---
> ryu/tests/unit/lib/test_rpc.py | 226
> +
> 1 f
Signed-off-by: YAMAMOTO Takashi
---
ryu/tests/unit/lib/test_rpc.py | 226 +
1 file changed, 226 insertions(+)
create mode 100644 ryu/tests/unit/lib/test_rpc.py
diff --git a/ryu/tests/unit/lib/test_rpc.py b/ryu/tests/unit/lib/test_rpc.py
new file mode 100
