Re: [Ryu-devel] Error parsing ICMPv4 fragments

2017-11-07 Thread Iwase Yusuke
Hi Bill, Thank you for your confirmation! I've just posted patches for this issue. The following fixes this issue and includes some improvements for ICMPv4/v6 packet libraries. [Ryu-devel] [PATCH 0/2] packet/icmp: Avoid TypeError when calculating length Thanks, Iwase On 2017年11月08日 15:39, W

Re: [Ryu-devel] Error parsing ICMPv4 fragments

2017-11-07 Thread William Fisher
Iwase, Yes, your patch works for me. Thanks, -Bill On Tue, Nov 7, 2017 at 8:59 PM, Iwase Yusuke wrote: > Hi Bill, > > Thank you for reporting issue, but sorry for the delay! > > Well, packet library for ICPMv6 seems to be fixed for the same issue. > I guess the same fix should be back-ported t

Re: [Ryu-devel] Error parsing ICMPv4 fragments

2017-11-07 Thread Iwase Yusuke
Hi Bill, Thank you for reporting issue, but sorry for the delay! Well, packet library for ICPMv6 seems to be fixed for the same issue. I guess the same fix should be back-ported to ICMPv4. https://github.com/osrg/ryu/blob/8185637767f870b5887a369dc569cc2933aeec34/ryu/lib/packet/icmpv6.py#L151-L1

[Ryu-devel] Error parsing ICMPv4 fragments

2017-11-03 Thread William Fisher
Hi, There is a TypeError exception with Ryu parsing fragmented ICMPv4 packets of a certain length. The attached program "ryu_icmpv4_test.py" demonstrates the failure. Note that the packet data is for the second fragment of a large ICMP echo. The file "ryu_icmpv4.patch" contains a superficial pat