Re: [Ryu-devel] IP addresses in BMP messages

2017-08-16 Thread Fujimoto Satoshi
Hi, Tsuboi-san Thank you for your confirmation! Hi, Henk You may need to reinstall Ryu after applying the patch. Please take the following steps: $ cd ryu $ pip uninstall Ryu $ pip install -r tools/pip-requires $ python setup.py install Thanks, Fujimoto On 2017年08月17日 08:42, Toshiki Tsuboi

Re: [Ryu-devel] IP addresses in BMP messages

2017-08-16 Thread Toshiki Tsuboi
Hi, Fujimoto-san I’ve confirmed this issue in Ryu BMP. After applying patches, local_address and peer_address can report properly. (0) applying patch content diff --git a/ryu/lib/packet/bmp.py b/ryu/lib/packet/bmp.py index 9d1cda3..bdf99e7 100644 --- a/ryu/lib/packet/bmp.py +++ b/ryu/lib/packet/

Re: [Ryu-devel] IP addresses in BMP messages

2017-08-16 Thread Henk Smit
No, that did not fix the problem. Both peer-address and local-address are still reported as 0.0.0.0. henk. Fujimoto Satoshi schreef op 2017-08-16 07:54: Hi, Henk Thank you for your report! As you said, now Ryu expects Peer address starts with IPv4 address, not 12 bytes of padding: https://g

Re: [Ryu-devel] IP addresses in BMP messages

2017-08-15 Thread Fujimoto Satoshi
Hi, Henk Thank you for your report! As you said, now Ryu expects Peer address starts with IPv4 address, not 12 bytes of padding: https://github.com/osrg/ryu/blob/master/ryu/lib/packet/bmp.py#L211 This quick fix should fix your problem. Could you try this? diff --git a/ryu/lib/packet/bmp.py

[Ryu-devel] IP addresses in BMP messages

2017-08-15 Thread Henk Smit
Hello, I noticed a bug in your BMP collector implementation. See RFC 7854: https://tools.ietf.org/html/rfc7854#section-4.2 o Peer Address: The remote IP address associated with the TCP session over which the encapsulated PDU was received. It is 4 bytes long if an IPv4 address