Re: [Ryu-devel] sw test tool: Meter tests send buggy packets

2014-07-28 Thread Minoru TAKAHASHI
Thank you for comments! I think also modify the ipv6.py as follows. Now, I will create a patch. diff --git a/ryu/lib/packet/ipv4.py b/ryu/lib/packet/ipv4.py index a252c70..4da0bcc 100644 --- a/ryu/lib/packet/ipv4.py +++ b/ryu/lib/packet/ipv4.py @@ -79,8 +79,8 @@ class ipv4(packet_base.PacketBase)

Re: [Ryu-devel] sw test tool: Meter tests send buggy packets

2014-07-28 Thread FUJITA Tomonori
On Tue, 29 Jul 2014 08:56:19 +0800 arne_goetje wrote: > src_port and dst_port cannot be empty either. Oops, how about this? diff --git a/ryu/lib/packet/ipv4.py b/ryu/lib/packet/ipv4.py index a252c70..4da0bcc 100644 --- a/ryu/lib/packet/ipv4.py +++ b/ryu/lib/packet/ipv4.py @@ -79,8 +79,8 @@ clas

Re: [Ryu-devel] sw test tool: Meter tests send buggy packets

2014-07-28 Thread arne_goetje
Fujita-san, src_port and dst_port cannot be empty either. Best Regards! Arne Goetje (???) From: FUJITA Tomonori To: takahashi.mino...@gmail.com, Cc: arne_goe...@accton.com, ryu-devel@lists.sourceforge.net Date: 07/28/2014 08:16 PM Subject:Re: [Ryu-devel] sw test tool

Re: [Ryu-devel] sw test tool: Meter tests send buggy packets

2014-07-28 Thread FUJITA Tomonori
On Thu, 17 Jul 2014 18:18:32 +0900 Minoru TAKAHASHI wrote: > (2014年07月17日 17:41), FUJITA Tomonori wrote: >> On Thu, 17 Jul 2014 17:32:17 +0900 >> Minoru TAKAHASHI wrote: >> >>> Hi,thank you for reporting again. >>> If possible, please send me a log of the test results. >> >> https://github.com

Re: [Ryu-devel] sw test tool: Meter tests send buggy packets

2014-07-17 Thread Minoru TAKAHASHI
> Best Regards! >> Arne Goetje (高盛華) >> >> >> >> From: Minoru TAKAHASHI >> To: arne_goetje , >> Cc: ryu-devel@lists.sourceforge.net >> Date: 07/17/2014 03:21 PM >> Subject:Re: [Ryu-devel] sw test tool: Meter tests send buggy &g

Re: [Ryu-devel] sw test tool: Meter tests send buggy packets

2014-07-17 Thread Minoru TAKAHASHI
(2014年07月17日 17:41), FUJITA Tomonori wrote: > On Thu, 17 Jul 2014 17:32:17 +0900 > Minoru TAKAHASHI wrote: > >> Hi,thank you for reporting again. >> If possible, please send me a log of the test results. > > https://github.com/osrg/ryu/blob/master/ryu/tests/switch/of13/meter/01_DROP_00_KBPS_00_1

Re: [Ryu-devel] sw test tool: Meter tests send buggy packets

2014-07-17 Thread FUJITA Tomonori
On Thu, 17 Jul 2014 17:32:17 +0900 Minoru TAKAHASHI wrote: > Hi,thank you for reporting again. > If possible, please send me a log of the test results. https://github.com/osrg/ryu/blob/master/ryu/tests/switch/of13/meter/01_DROP_00_KBPS_00_1M.json#L60 Meter test creates an ip packet only with 'p

Re: [Ryu-devel] sw test tool: Meter tests send buggy packets

2014-07-17 Thread Minoru TAKAHASHI
the switch to correctly > forward the packets. Invalid packets will not get forwarded by default. > > Best Regards! > Arne Goetje (高盛華) > > > > From: Minoru TAKAHASHI > To: arne_goetje , > Cc: ryu-devel@lists.sourceforge.net > Date: 07/17/2014 03:21 PM &g

Re: [Ryu-devel] sw test tool: Meter tests send buggy packets

2014-07-17 Thread arne_goetje
, Cc: ryu-devel@lists.sourceforge.net Date: 07/17/2014 03:21 PM Subject:Re: [Ryu-devel] sw test tool: Meter tests send buggy packets (2014年07月17日 14:51), arne_goetje wrote: > Hi list, > > I found that the Meter tests send buggy test packets to the DUT. The IPv4 &

Re: [Ryu-devel] sw test tool: Meter tests send buggy packets

2014-07-17 Thread Minoru TAKAHASHI
(2014年07月17日 14:51), arne_goetje wrote: > Hi list, > > I found that the Meter tests send buggy test packets to the DUT. The IPv4 > and IPv6 packets lack source/destination IP and port numbers, therefore > the switch drops them. Hi, thank you for reporting. Please tell me the situation of when y

[Ryu-devel] sw test tool: Meter tests send buggy packets

2014-07-16 Thread arne_goetje
Hi list, I found that the Meter tests send buggy test packets to the DUT. The IPv4 and IPv6 packets lack source/destination IP and port numbers, therefore the switch drops them. Please send proper IP packets in the tests. Thanks! Best Regards! Arne Goetje (高盛華)