Re: [Ryu-devel] [PATCH] packet lib: add icmp.py

2012-10-03 Thread FUJITA Tomonori
On Wed, 3 Oct 2012 16:40:28 +0900 OHMURA Kei wrote: > From: OHMURA Kei > Date: Wed, 3 Oct 2012 16:32:40 +0900 > Subject: [PATCH] packet lib: add icmp.py > > Signed-off-by: OHMURA Kei > --- > ryu/lib/packet/icmp.py | 112 > > ryu/lib/packet/ip

Re: [Ryu-devel] [PATCH] packet lib: add icmp.py

2012-10-03 Thread OHMURA Kei
2012/10/3 Kei Ohmura : > 2012/10/3 FUJITA Tomonori : > >> >> Do we need to duplicate the exact same code here? >> >> How about using echo class for both types? > > > How about the following code? I modified the previous patch. >From 9bfc35532c74aa1d75530bb0b3856962f3dd0ba6 Mon Sep 17 00:00:00 20

Re: [Ryu-devel] [PATCH] packet lib: add icmp.py

2012-10-02 Thread Kei Ohmura
2012/10/3 FUJITA Tomonori : > > Do we need to duplicate the exact same code here? > > How about using echo class for both types? How about the following code? >From a1e49a6848390ae69ca6463c28dec4c3d4bfbb03 Mon Sep 17 00:00:00 2001 From: OHMURA Kei Date: Wed, 3 Oct 2012 12:18:09 +0900 Subject:

Re: [Ryu-devel] [PATCH] packet lib: add icmp.py

2012-10-02 Thread FUJITA Tomonori
On Wed, 3 Oct 2012 08:09:36 +0900 OHMURA Kei wrote: > Signed-off-by: OHMURA Kei > --- > ryu/lib/packet/icmp.py | 141 > > ryu/lib/packet/ipv4.py |2 + > 2 files changed, 143 insertions(+) > create mode 100644 ryu/lib/packet/icmp.py > > d