[Ryu-devel] [PATCH] packet lib: add helper functions for ip address

2012-11-20 Thread OHMURA Kei
Signed-off-by: OHMURA Kei --- ryu/lib/packet/packet_utils.py | 15 +++ 1 file changed, 15 insertions(+) diff --git a/ryu/lib/packet/packet_utils.py b/ryu/lib/packet/packet_utils.py index d9714f0..70eeac9 100644 --- a/ryu/lib/packet/packet_utils.py +++ b/ryu/lib/packet/packet_utils.

Re: [Ryu-devel] [PATCH] packet lib: add helper functions for ip address

2012-11-20 Thread Isaku Yamahata
On Tue, Nov 20, 2012 at 10:49:35PM +0900, OHMURA Kei wrote: > Signed-off-by: OHMURA Kei > --- > ryu/lib/packet/packet_utils.py | 15 +++ > 1 file changed, 15 insertions(+) > > diff --git a/ryu/lib/packet/packet_utils.py b/ryu/lib/packet/packet_utils.py > index d9714f0..70eeac9 1006

Re: [Ryu-devel] [PATCH] packet lib: add helper functions for ip address

2012-11-20 Thread FUJITA Tomonori
On Tue, 20 Nov 2012 22:49:35 +0900 OHMURA Kei wrote: > Signed-off-by: OHMURA Kei > --- > ryu/lib/packet/packet_utils.py | 15 +++ > 1 file changed, 15 insertions(+) > > diff --git a/ryu/lib/packet/packet_utils.py b/ryu/lib/packet/packet_utils.py > index d9714f0..70eeac9 100644 >

Re: [Ryu-devel] [PATCH] packet lib: add helper functions for ip address

2012-11-20 Thread OHMURA Kei
2012/11/21 FUJITA Tomonori : > On Tue, 20 Nov 2012 22:49:35 +0900 > OHMURA Kei wrote: > >> Signed-off-by: OHMURA Kei >> --- >> ryu/lib/packet/packet_utils.py | 15 +++ >> 1 file changed, 15 insertions(+) >> >> diff --git a/ryu/lib/packet/packet_utils.py b/ryu/lib/packet/packet_util

Re: [Ryu-devel] [PATCH] packet lib: add helper functions for ip address

2012-11-20 Thread FUJITA Tomonori
On Wed, 21 Nov 2012 08:26:56 +0900 OHMURA Kei wrote: > 2012/11/21 FUJITA Tomonori : >> On Tue, 20 Nov 2012 22:49:35 +0900 >> OHMURA Kei wrote: >> >>> Signed-off-by: OHMURA Kei >>> --- >>> ryu/lib/packet/packet_utils.py | 15 +++ >>> 1 file changed, 15 insertions(+) >>> >>> diff -

Re: [Ryu-devel] [PATCH] packet lib: add helper functions for ip address

2012-11-20 Thread OHMURA Kei
2012/11/21 FUJITA Tomonori : > On Wed, 21 Nov 2012 08:26:56 +0900 > OHMURA Kei wrote: > >> 2012/11/21 FUJITA Tomonori : >>> On Tue, 20 Nov 2012 22:49:35 +0900 >>> OHMURA Kei wrote: >>> Signed-off-by: OHMURA Kei --- ryu/lib/packet/packet_utils.py | 15 +++ 1 fil

Re: [Ryu-devel] [PATCH] packet lib: add helper functions for ip address

2012-11-20 Thread FUJITA Tomonori
On Wed, 21 Nov 2012 09:22:47 +0900 OHMURA Kei wrote: >> My point is that why we want to create helper functions for one line? >> Applications can put one-line function. When you read socket.inet_* >> functions, you just know what they do. You can't about helper >> functions. > > I think various

[Ryu-devel] [PATCH] of1.2: fix some error constant typos

2012-11-20 Thread FUJITA Tomonori
From: Sriram Natarajan Signed-off-by: FUJITA Tomonori --- ryu/ofproto/ofproto_v1_2.py |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/ryu/ofproto/ofproto_v1_2.py b/ryu/ofproto/ofproto_v1_2.py index e9f789a..27fc6b3 100644 --- a/ryu/ofproto/ofproto_v1_2.py +++ b/r

Re: [Ryu-devel] [PATCH] of1.2: fix some error constant typos

2012-11-20 Thread FUJITA Tomonori
On Wed, 21 Nov 2012 10:03:01 +0900 FUJITA Tomonori wrote: > From: Sriram Natarajan > > Signed-off-by: FUJITA Tomonori > --- > ryu/ofproto/ofproto_v1_2.py |8 > 1 files changed, 4 insertions(+), 4 deletions(-) Thanks, applied.

Re: [Ryu-devel] [PATCH] packet lib: add helper functions for ip address

2012-11-20 Thread OHMURA Kei
On 2012/11/21 9:43, FUJITA Tomonori wrote: > On Wed, 21 Nov 2012 09:22:47 +0900 > OHMURA Kei wrote: > >>> My point is that why we want to create helper functions for one line? >>> Applications can put one-line function. When you read socket.inet_* >>> functions, you just know what they do. You can