[sage-combinat-devel] Is there a reason for CombinatorialFreeModule to violate the unique parent condition?

2013-02-25 Thread Simon King
Hi! sage: G = CombinatorialFreeModule(ZZ, [1,2,3,4], prefix=G) sage: y = CombinatorialFreeModule(ZZ, [1,2,3,4], prefix='y') sage: G is y False sage: G == y True This is inspite of the fact that CombinatorialFreeModule inherits from UniqueRepresentation. Namely, it overloads __eq__ and __ne__.

[sage-combinat-devel] Re: Is there a reason for CombinatorialFreeModule to violate the unique parent condition?

2013-02-25 Thread Simon King
Hi Nicolas, On 2013-02-25, Nicolas M. Thiery nicolas.thi...@u-psud.fr wrote: It was a design decision that the user could create his own free module by specifying a prefix, even if the base ring and index set is the same. So the result for ``G is y`` is as desired. On the other hand, I

[sage-combinat-devel] Re: Is there a reason for CombinatorialFreeModule to violate the unique parent condition?

2013-02-25 Thread Simon King
Hi Nicolas, On 2013-02-25, Nicolas M. Thiery nicolas.thi...@u-psud.fr wrote: On the other hand, I personally consider that ``G == y`` is buggy: it should return False; the user explicitly asked for G and y to be distinct even if they are trivially isomorphic. The problem that bites us here:

Re: [sage-combinat-devel] Re: Is there a reason for CombinatorialFreeModule to violate the unique parent condition?

2013-02-25 Thread Nicolas M. Thiery
On Mon, Feb 25, 2013 at 07:17:57PM +, Simon King wrote: - Make CombinatorialFreeModule a unique parent, i.e., different prefixes will result in distinct and unequal modules (as suggested by Nicolas). I mentioned in my previous post that this change will not be trivial, but perhaps it

[sage-combinat-devel] Re: Is there a reason for CombinatorialFreeModule to violate the unique parent condition?

2013-02-25 Thread Simon King
Hi Nicolas, On 2013-02-25, Nicolas M. Thiery nicolas.thi...@u-psud.fr wrote: On Mon, Feb 25, 2013 at 07:17:57PM +, Simon King wrote: - Make CombinatorialFreeModule a unique parent, i.e., different prefixes will result in distinct and unequal modules (as suggested by Nicolas). I

Re: [sage-combinat-devel] Re: Is there a reason for CombinatorialFreeModule to violate the unique parent condition?

2013-02-25 Thread Nicolas M. Thiery
On Tue, Feb 26, 2013 at 12:20:14AM +, Simon King wrote: When I made CombinatorialFreeModule inherit from UniqueRepresentation (not only from the new CachedRepresentation), then only very few tests failed (some of them in my coercion tutorial). All of it easy to fix. So, I had a wrong

[sage-combinat-devel] queue broken on 5.7

2013-02-25 Thread Franco Saliola
$ sage -v Sage Version 5.7, Release Date: 2013-02-19 $ sage -combinat update ... applying trac_13605-partition_options-ts.patch patching file sage/combinat/rigged_configurations/rigged_configurations.py Hunk #1 FAILED at 930 1 out of 1 hunks FAILED -- saving rejects to file

[sage-combinat-devel] Re: queue broken on 5.7

2013-02-25 Thread Franco Saliola
On Mon, Feb 25, 2013 at 9:01 PM, Franco Saliola sali...@gmail.com wrote: $ hg qpush -a applying trac_14000-doctests.patch applying trac_7886_conjugacy_classes_combined.patch transaction abort! rollback completed cleaning up working directory...done abort: decoding near 'Javier López Peñ':

Re: [sage-combinat-devel] queue broken on 5.7

2013-02-25 Thread Nicolas M. Thiery
On Mon, Feb 25, 2013 at 09:01:52PM -0500, Franco Saliola wrote: $ sage -v Sage Version 5.7, Release Date: 2013-02-19 $ sage -combinat update ... applying trac_13605-partition_options-ts.patch patching file sage/combinat/rigged_configurations/rigged_configurations.py

Re: [sage-combinat-devel] queue broken on 5.7

2013-02-25 Thread Franco Saliola
Hello Nicolas, Thank you for the quick fix! Take care, Franco -- On Mon, Feb 25, 2013 at 9:58 PM, Nicolas M. Thiery nicolas.thi...@u-psud.fr wrote: On Mon, Feb 25, 2013 at 09:01:52PM -0500, Franco Saliola wrote: $ sage -v Sage Version 5.7, Release Date: 2013-02-19 $ sage