Re: [sage-combinat-devel] Problem with pickle in CombinatorialFreeModule

2011-03-21 Thread Sébastien Labbé
> Back to positive review. Thanks too! -- You received this message because you are subscribed to the Google Groups "sage-combinat-devel" group. To post to this group, send email to sage-combinat-devel@googlegroups.com. To unsubscribe from this group, send email to sage-combinat-devel+unsubscr

Re: [sage-combinat-devel] Problem with pickle in CombinatorialFreeModule

2011-03-21 Thread Nicolas M. Thiery
On Mon, Mar 21, 2011 at 04:51:12PM -0400, Sébastien Labbé wrote: > It is done. The patch was having a positive review since some time. I > put it back to needs review status, but I really want this to get into > sage-4.7... Back to positive review. Thanks much! Nic

Re: [sage-combinat-devel] Problem with pickle in CombinatorialFreeModule

2011-03-21 Thread Sébastien Labbé
> Ah, thanks for the notice. Actually, would you mind updating your > patch to remove the #long time? That will reduce the trac/patch/review > overhead. I can reset a positive review as soon as done. It is done. The patch was having a positive review since some time. I put it back to needs review

Re: [sage-combinat-devel] Problem with pickle in CombinatorialFreeModule

2011-03-21 Thread Nicolas M. Thiery
On Mon, Mar 21, 2011 at 12:49:36PM -0400, Sébastien Labbé wrote: > > Unless someone expresses a strong counter-feeling by Monday, I'll > > post a patch to revert that. > > Expect some conflicts with #10354 where I remove the `` print "x"; `` > part (because the warnings do not appear anymore). >

Re: [sage-combinat-devel] Problem with pickle in CombinatorialFreeModule

2011-03-21 Thread Sébastien Labbé
> Unless someone expresses a strong counter-feeling by Monday, I'll > post a patch to revert that. Expect some conflicts with #10354 where I remove the `` print "x"; `` part (because the warnings do not appear anymore). http://trac.sagemath.org/sage_trac/ticket/10354 I will adapt if your patch g

Re: [sage-combinat-devel] Problem with pickle in CombinatorialFreeModule

2011-03-18 Thread Nicolas M. Thiery
On Fri, Mar 18, 2011 at 12:47:41PM -0700, Daniel Bump wrote: > On the subject of pickling I just found out the hard way that the pickle jar > is no longer tested by default, since trac_10712, which was merged in 4.6.2 > marks the following test in sage_object.pyx long time that tests the > pickle

Re: [sage-combinat-devel] Problem with pickle in CombinatorialFreeModule

2011-03-18 Thread Daniel Bump
On the subject of pickling I just found out the hard way that the pickle jar is no longer tested by default, since trac_10712, which was merged in 4.6.2 marks the following test in sage_object.pyx long time that tests the pickle jar. - sage: print "x"; sage.structure.sage_object.unpickle_all() +

Re: [sage-combinat-devel] Problem with pickle in CombinatorialFreeModule

2011-03-18 Thread Nicolas M. Thiery
On Fri, Mar 18, 2011 at 09:24:47AM -0700, Christian Stump wrote: > I opened a ticket concerning a problem with pickle for CFM with basis > being sage.structure.parent.Set_PythonType(tuple), see Ticket #10962. Thanks! I updated the ticket to only speak about sage.structure.parent.Set_PythonType, s

[sage-combinat-devel] Problem with pickle in CombinatorialFreeModule

2011-03-18 Thread Christian Stump
Hi, I opened a ticket concerning a problem with pickle for CFM with basis being sage.structure.parent.Set_PythonType(tuple), see Ticket #10962. Best, Christian -- You received this message because you are subscribed to the Google Groups "sage-combinat-devel" group. To post to this group, send