Hi Nicolas,
On 28 Jan., 08:53, "Nicolas M. Thiery"
wrote:
> Note: a pretty similar test is included in the TestSuite (see
> _test_eq).
You mean the "self!=None" test? Right, that's the same, and it would
fail in unpatched Sage.
> Do you think both are useful?
Not sure...
> If yes, I am happy
On Fri, Jan 27, 2012 at 03:11:23PM -0800, Simon King wrote:
> OK, that probably means that the original bug (namely __eq__ assuming
> that both arguments are poset elements) is indeed fixed by coercion
I will double check!
> If it is the case, then I suggest that you also add the
> "P(0)==int(0)"
Hi Nicolas,
On 27 Jan., 15:01, "Nicolas M. Thiery"
wrote:
> With the Sage-Combinat queue installed, I get:
>
> sage: P = Poset([[1,2],[4],[3],[4],[]])
> sage: P(0) == int(0)
> False
OK, that probably means that the original bug (namely __eq__ assuming
that both arguments are poset el
On Thu, Jan 26, 2012 at 11:48:55AM -0800, Simon King wrote:
> It may fix the "plot" problem, but it probably doesn't fix the bug
> that I was fixing at #12351. Namely, the patch from #10998 does not
> change the __eq__ method of poset elements. Hence, you would still
> have that comparing a poset e
Hi Nicolas,
On 26 Jan., 13:35, "Nicolas M. Thiery"
wrote:
> On Thu, Jan 26, 2012 at 01:33:31PM +0100, Nicolas M. Thiery wrote:
> > Has anyone tried first whether #10998 does not fix it already?
>
> Well, actually I just tried the example with the Sage-Combinat queue
> installed on 4.7.2, and it w
On Thu, Jan 26, 2012 at 01:33:31PM +0100, Nicolas M. Thiery wrote:
> Has anyone tried first whether #10998 does not fix it already?
Well, actually I just tried the example with the Sage-Combinat queue
installed on 4.7.2, and it worked smoothly. So my best bet is that
#10998 indeed fixes it.
Cheer
Hi Sébastien, Simon,
On Wed, Jan 25, 2012 at 11:51:31PM -0800, Simon King wrote:
> On 25 Jan., 01:08, slabbe wrote:
> > I get an attribute error when ploting a poset. I already created a
> > ticket for it :
> >
> > http://trac.sagemath.org/sage_trac/ticket/12351
>
> Patch's up and ready
Hi y'all!
On 25 Jan., 01:08, slabbe wrote:
> I get an attribute error when ploting a poset. I already created a
> ticket for it :
>
> http://trac.sagemath.org/sage_trac/ticket/12351
Patch's up and ready for review!
Cheers,
Simon
--
You received this message because you are subscribed to the G
Hi Sébastien,
On 25 Jan., 01:08, slabbe wrote:
> I know I should ask first but is this a duplicate ticket or known bug?
I don't know if it is a duplicate, but I am confident that I could fix
it.
H.plot() does the following:
# Set element_labels to default to the vertex set.
if e