[sage-combinat-devel] Re: Reviewing categories code: bimodules.py

2009-10-03 Thread javier
On Oct 2, 9:50 pm, "Nicolas M. Thiery" wrote: > By the way: David Kohel is visiting me on Sunday evening, and we will > try to finish the review of whichever categories remain at this point. > So please keep us updated on your progress! I have tried to do some more reviews yesterday and today, b

[sage-combinat-devel] Re: Reviewing categories code: bimodules.py

2009-10-02 Thread Nicolas M. Thiery
On Thu, Oct 01, 2009 at 10:10:54AM -0700, javier wrote: > I jst realized that the check is realized via Category_over_base_ring. > Sorry for the noise. > Positive review for bimodules.py For modules and friends, yes, but actually not for bimodules (which inherits directly from Category. I am fix

[sage-combinat-devel] Re: Reviewing categories code: bimodules.py

2009-10-01 Thread Nicolas M. Thiery
On Wed, Sep 30, 2009 at 10:07:09AM -0700, javier wrote: > > I think that > Bimodules(R,S) > should check that R and S are rings. Will do. Cheers, Nicolas -- Nicolas M. Thiéry "Isil" http://Nicolas.Thiery.name/ --~--~-~--~~~---~--~---

[sage-combinat-devel] Re: Reviewing categories code: bimodules.py

2009-10-01 Thread javier
I jst realized that the check is realized via Category_over_base_ring. Sorry for the noise. Positive review for bimodules.py On Sep 30, 6:07 pm, javier wrote: > I think that > Bimodules(R,S) > should check that R and S are rings. --~--~-~--~~~---~--~~ You received