[sage-devel] Re: Abelian group invariants

2011-06-17 Thread Dan Gordon
Hi Rob and Javier, Sorry I wasn't clear in my posting. I agree that the way things are done now isn't correct, and what I'm suggesting is to have elementary_divisors return the list of prime powers, and invariant_factors return the m_i's. Rob's suggestion of doing this within the finitely-genera

[sage-devel] Re: Abelian group invariants

2011-06-17 Thread javier
Hi Dan, On 17 jun, 17:53, Dan Gordon wrote: > Back in 2008 there was a discussion of the elementary_divisors > function for abelian groups.  While it's not universal, most group > theory and algebra books define the elementary divisors of a finite > abelian group G to be a list of prime powers su

[sage-devel] Re: Abelian group invariants

2011-06-17 Thread Rob Beezer
Hi Dan, On Jun 17, 9:53 am, Dan Gordon wrote: > I'd like to change the meaning of invariants and elementary_divisors > for AbelianGroup.  Are there objections to doing that? I might be a bit slow, but I can't figure out exactly what you want to change it *to*? In any event, a (needs-work) patch