[sage-devel] Re: Reviewing package version updates (in particular, gap)

2013-12-26 Thread Volker Braun
That reminds me of one thing that I wanted to mention... I'm of course assuming that the package comes from either the maintainer (see SPKG.txt) or somebody whom I trust to have the technical abilities. In any case I'll always have a quick look... On Thursday, December 26, 2013 4:39:56 AM UTC

[sage-devel] Re: Reviewing package version updates (in particular, gap)

2013-12-26 Thread Nathann Cohen
> > How about a slight twist on the first option: > > [X] Have a whitelist of developers who are allowed to post an updated > package and set them to positive review immediately (listing themselves as > reviewers) because they judge the update to be trivial and in no need of > discussion > > It

[sage-devel] Re: Reviewing package version updates (in particular, gap)

2013-12-25 Thread Andrey Novoseltsev
On Tuesday, 24 December 2013 16:01:00 UTC-7, Volker Braun wrote: > > The current process of updating third-party packages is broken: > > a) There isn't really anything to review beyond running it on the buildbot > b) Nobody dares to press the "positive review" button > c) Frustation to see your wor

[sage-devel] Re: Reviewing package version updates (in particular, gap)

2013-12-25 Thread Jean-Pierre Flori
On Wednesday, December 25, 2013 7:08:15 PM UTC+1, Volker Braun wrote: > > On Wednesday, December 25, 2013 5:52:39 PM UTC, Jean-Pierre Flori wrote: >> >> #12399 >> > > I just want to point out that this took you half a year... IMHO there is > no point to if if it takes longer than the upstream re

[sage-devel] Re: Reviewing package version updates (in particular, gap)

2013-12-25 Thread Volker Braun
On Wednesday, December 25, 2013 5:52:39 PM UTC, Jean-Pierre Flori wrote: > > #12399 > I just want to point out that this took you half a year... IMHO there is no point to if if it takes longer than the upstream release cycle ;-) -- You received this message because you are subscribed to the G

[sage-devel] Re: Reviewing package version updates (in particular, gap)

2013-12-25 Thread Jean-Pierre Flori
I'd prefer to have a quick review for everything. Just having someone else having a quick look at the diff is also a good idea, and I think the peer-reviewing system of Sage is a real plus value. By the way a bunch of more or less trivial updates, upstream patch inclusion: #12399, #14333, #14854

[sage-devel] Re: Reviewing package version updates (in particular, gap)

2013-12-25 Thread Volker Braun
Done On Wednesday, December 25, 2013 1:36:02 AM UTC, Volker Braun wrote: > > I forgot to push my branch > -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-dev

[sage-devel] Re: Reviewing package version updates (in particular, gap)

2013-12-24 Thread Volker Braun
I definitely removed the patch in question, looks like I forgot to push my branch. Will do that tomorrow... I didn't see anything in > http://sagemath.github.io/git-developer-guide/packaging.html that could > tell me what to do... > That page is outdated, the current developer manual in Sage i

[sage-devel] Re: Reviewing package version updates (in particular, gap)

2013-12-24 Thread Volker Braun
Also, the system for distributing tarballs is manual right now, we'll have to make that more automatic. For now you have to download the tarball manually to /upstream/ as long as it is not on the web page. On Wednesday, December 25, 2013 1:36:02 AM UTC, Volker Braun wrote: > > I definitely remo

[sage-devel] Re: Reviewing package version updates (in particular, gap)

2013-12-24 Thread Travis Scrimshaw
Question: how do I install the new tarballs? I tried changing the gap version number in package-version.txt and running "sage -sh sage-fix-pkg-checksums" and rebuilding gap, but it failed saying that the patches cannot be applied: travis@Kristine-Desktop:~/sage/upstream$ sage -i gap Found local

[sage-devel] Re: Reviewing package version updates (in particular, gap)

2013-12-24 Thread Travis Scrimshaw
On Tuesday, December 24, 2013 3:01:00 PM UTC-8, Volker Braun wrote: > > The current process of updating third-party packages is broken: > > a) There isn't really anything to review beyond running it on the buildbot > b) Nobody dares to press the "positive review" button > c) Frustation to see you