On Apr 30, 11:38 pm, David Roe <r...@math.harvard.edu> wrote:
> Hey all,
> There's a set of patches needing review. It brings doctest coverage of the
> p-adics folder from 28.3% to 100%, restructures the files so that the
> directory is less cluttered, deletes a number of files (some due to the
> restructuring, some getting rid of lazy p-adics which are currently not
> supported, and a couple other random ones), adds p-adics to the reference
> manual, ReSTifies the documentation (about half of it well, the other half
> good enough so that it builds), converts p-adics to the new coercion model
> and fixes some bugs that popped up in this whole process.
>
> I split it up into six mainly independent tickets: one for files outside the
> padics directory, one for files being deleted, and four for changes to files
> in the padics directory. You'll need to apply all six in order for Sage to
> build (due to the restructuring of files and thus changing imports), but the
> changes in the code in the six should be fairly independent.
>
> So... I could use some help reviewing this. Robert Bradshaw has volunteered
> to work on it, but he could use some assitance. People familiar with ReST
> would be useful, to see if I did anything particularly stupid. Much of the
> work doesn't require a lot of familiarity with p-adics, though some does.
> Perhaps getting a group together on IRC and having me, as well as William,
> Robert, Craig and others who are familiar with the p-adics code would be a
> good plan.
+1.
Three remarks:
* Note the dependency of this ticket on another one as mentioned on
the ticket. Otherwise it will not apply.
* This is a *large* patch at 1.1MB total for all six patches, but
essential to reach the 75% coverage goal for 4.0.
* Due to some minor white space issues it does not apply cleanly to
3.4.2.X, but it does apply to 3.4.1. Rebasing it should be simple,
otherwise we can revert part of the de-tabify patch and then clean out
the tabs post merge again.
> David
Cheers,
Michael
--~--~---------~--~----~------------~-------~--~----~
To post to this group, send email to sage-devel@googlegroups.com
To unsubscribe from this group, send email to
sage-devel-unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/sage-devel
URLs: http://www.sagemath.org
-~----------~----~----~----~------~----~------~--~---
