[sage-devel] Readline and Solaris: Testing strings with == is not portable.

[Dr. David Kirkby]

I tried building sage 3.0 on an x86 laptop running Solaris Express
Developer Edition snv_79b. At the time of writing this is the latest
developer edition, but there are later community editions of Solaris.
I was using gcc 4.0.2, but Sun's make program in /usr/bin/make.

bash-3.2$ /usr/sbin/psrinfo -v
Status of virtual processor 0 as of: 04/23/2008 13:52:18
  on-line since 04/23/2008 13:42:46.
  The i386 processor operates at 2000 MHz,
        and has an i387 compatible floating point processor.
Status of virtual processor 1 as of: 04/23/2008 13:52:18
  on-line since 04/23/2008 13:42:49.
  The i386 processor operates at 2000 MHz,
        and has an i387 compatible floating point processor.


bash-3.2$ cat /etc/release
               Solaris Express Developer Edition 1/08 snv_79b X86
          Copyright 2008 Sun Microsystems, Inc.  All Rights Reserved.
                       Use is subject to license terms.
                           Assembled 24 January 2008

bash-3.2$ uname -a
SunOS kingfisher 5.11 snv_79a i86pc i386 i86pc

 'spkg-install' uses '==' to check equality. That might be ok in bash,
but it is not ok in /bin/sh which is the shell that the script uses.

The following works ok - I replaced == by = whenever == was seen


#!/bin/sh
###########################################
## Readline 5.2
###########################################

cd src/

build()
{
    ./configure --prefix=$SAGE_LOCAL
    if [ `uname` = 'Darwin' ]; then
      if [ `uname -r | awk -F. '{ print $1; }'` = '9' ]; then
        echo "Fixing Makefile for OSX 10.5 compatibility"
        sed -e 's/-dynamic/-dynamiclib/' shlib/Makefile > shlib/
Makefile.ok
        mv shlib/Makefile.ok shlib/Makefile
      fi
    fi
    make install
}

build

if [ `uname` = 'Darwin' ]; then
  DYLIB_NAME=$SAGE_LOCAL/lib/libreadline.dylib
else
  DYLIB_NAME=$SAGE_LOCAL/lib/libreadline.so
fi

if [ -f $DYLIB_NAME -a -f $SAGE_LOCAL/lib/libreadline.a ]; then
  chmod 755 $SAGE_LOCAL/lib/libreadline.*
  chmod 755 $SAGE_LOCAL/lib/libhistory.*
  exit 0
else
  echo "Error building readline"
  exit 1
fi


--~--~---------~--~----~------------~-------~--~----~
To post to this group, send email to sage-devel@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at http://groups.google.com/group/sage-devel
URLs: http://www.sagemath.org
-~----------~----~----~----~------~----~------~--~---