Re: [sage-devel] Reworked configure

2018-01-31 Thread Erik Bray
On Wed, Jan 31, 2018 at 5:35 PM, William Stein wrote: > On Wed, Jan 31, 2018 at 8:31 AM, Erik Bray wrote: > [...] >> >> Anyways, speaking of comments, if you wanted to debug a specific >> package you could, as William suggested, copy the example and comment >> the package out from NORMAL_PACKAGES

Re: [sage-devel] Reworked configure

2018-01-31 Thread William Stein
On Wed, Jan 31, 2018 at 8:31 AM, Erik Bray wrote: [...] > > Anyways, speaking of comments, if you wanted to debug a specific > package you could, as William suggested, copy the example and comment > the package out from NORMAL_PACKAGES, thus excluding it from the macro > expansion. If you add a n

Re: [sage-devel] Reworked configure

2018-01-31 Thread Erik Bray
On Wed, Jan 31, 2018 at 5:27 PM, Erik Bray wrote: > On Wed, Jan 31, 2018 at 5:15 PM, William Stein wrote: >> On Wed, Jan 31, 2018 at 6:46 AM, Jeroen Demeyer wrote: >>> On 2018-01-31 14:37, Erik Bray wrote: All that's changed is how they're presented. >>> >>> >>> But that is a very imp

Re: [sage-devel] Reworked configure

2018-01-31 Thread Erik Bray
On Wed, Jan 31, 2018 at 5:15 PM, William Stein wrote: > On Wed, Jan 31, 2018 at 6:46 AM, Jeroen Demeyer wrote: >> On 2018-01-31 14:37, Erik Bray wrote: >>> >>> All that's changed is how they're presented. >> >> >> But that is a very important change! It's like "all I changed is replacing >> your

Re: [sage-devel] Reworked configure

2018-01-31 Thread Dima Pasechnik
On Wednesday, January 31, 2018 at 2:46:10 PM UTC, Jeroen Demeyer wrote: > > On 2018-01-31 14:37, Erik Bray wrote: > > All that's changed is how they're presented. > > But that is a very important change! It's like "all I changed is > replacing your car by instructions on how to build a car".

Re: [sage-devel] Reworked configure

2018-01-31 Thread William Stein
On Wed, Jan 31, 2018 at 6:46 AM, Jeroen Demeyer wrote: > On 2018-01-31 14:37, Erik Bray wrote: >> >> All that's changed is how they're presented. > > > But that is a very important change! It's like "all I changed is replacing > your car by instructions on how to build a car". > >> I'm replacing

Re: [sage-devel] Reworked configure

2018-01-31 Thread Erik Bray
Just one thing I want to respond to quickly: On Wed, Jan 31, 2018 at 3:46 PM, Jeroen Demeyer wrote: >> At the end of the day, I just feel that if we're going to use these >> tools at all it actually makes sense to use them closer to how they >> were intended. > > > I don't think that "make" is m

Re: [sage-devel] Reworked configure

2018-01-31 Thread Jeroen Demeyer
On 2018-01-31 14:37, Erik Bray wrote: All that's changed is how they're presented. But that is a very important change! It's like "all I changed is replacing your car by instructions on how to build a car". I'm replacing this: I don't see it that way. In my mind you are replacing readabl

Re: [sage-devel] Reworked configure

2018-01-31 Thread Erik Bray
On Wed, Jan 31, 2018 at 1:44 PM, Jeroen Demeyer wrote: > On 2018-01-31 12:21, Erik Bray wrote: >> >> I'm not going to say I didn't expect pushback from you on this, but I >> feel like this is not a real argument. > > > I assure you that it was meant as a serious argument. I'm not complaining > for

Re: [sage-devel] Reworked configure

2018-01-31 Thread Jeroen Demeyer
On 2018-01-31 12:21, Erik Bray wrote: I'm not going to say I didn't expect pushback from you on this, but I feel like this is not a real argument. I assure you that it was meant as a serious argument. I'm not complaining for the sake of complaining. In fact, the old code was still essential

Re: [sage-devel] Reworked configure

2018-01-31 Thread Dima Pasechnik
Nice bugs, very tasty and crunchy, in the build system come from /bin/sh not being bash on some systems. And different versions of Make are sometimes a lot of fun, too. Having said this, I much prefer short to verbose, and modular to "one huge file with everything there" design. On Wednesday,

Re: [sage-devel] Reworked configure

2018-01-31 Thread Erik Bray
On Tue, Jan 30, 2018 at 8:45 PM, Jeroen Demeyer wrote: > On 2018-01-30 13:19, Erik Bray wrote: >> >> I think the resulting Makefile, and its >> template, are easier to understand for one. > > > This is unfortunately the part where I disagree and it is also the reason > why I am against the current

Re: [sage-devel] Reworked configure

2018-01-30 Thread Jeroen Demeyer
On 2018-01-30 13:19, Erik Bray wrote: I think the resulting Makefile, and its template, are easier to understand for one. This is unfortunately the part where I disagree and it is also the reason why I am against the current patch. The resulting Makefile uses some macro constructions which ma

[sage-devel] Reworked configure

2018-01-30 Thread Erik Bray
Hi anyone interested in Sage (the distribution's) build system, I have a ticket that's been languishing for months now which makes some significant overhauls to how Sage's build/make/Makefile is generated and structured: https://trac.sagemath.org/ticket/21524 I know we're all very busy and that it