[sage-devel] the attack of the (really) long doctests

2009-12-12 Thread Alex Ghitza
Hi, The developer guide says that any single doctest shouldn't take more than around 30 seconds. This is of course highly machine-dependent, but I assume we can take sage.math as a reference point. There are a handful of files in the Sage library that account for a large amount of the time nec

Re: [sage-devel] the attack of the (really) long doctests

2009-12-13 Thread John Cremona
This all sounds very sensible. Another related point is that some individual files are very very long. For example, one of the 10 files in your list is sage/schemes/elliptic_curves/ell_rational_field.py which is 7514 lines long, more than double the next longest in that directory. (I have writte

Re: [sage-devel] the attack of the (really) long doctests

2009-12-13 Thread William Stein
On Sun, Dec 13, 2009 at 3:00 AM, John Cremona wrote: > This all sounds very sensible.  Another related point is that some > individual files are very very long.  For example, one of the 10 files > in your list is sage/schemes/elliptic_curves/ell_rational_field.py > which is 7514 lines long, more t

Re: [sage-devel] the attack of the (really) long doctests

2009-12-13 Thread John Cremona
2009/12/13 William Stein : >>   7514 schemes/elliptic_curves/ell_rational_field.py >> >> Some of these could (should?) probably be split up a bit. > > +1 to shortening/marking #long those doctests Alex mentioned. > > Also, trac 6616 splits up ell_rational_field.py by removing all the > Heegner poi

Re: [sage-devel] the attack of the (really) long doctests

2009-12-13 Thread Alex Ghitza
On Sun, Dec 13, 2009 at 11:01:14AM -0800, William Stein wrote: > > +1 to shortening/marking #long those doctests Alex mentioned. > OK, the first patch, dealing with the Bernoulli numbers tests in arith.py, is up at http://trac.sagemath.org/sage_trac/ticket/7678 I will do groups/perm_gps/partn_

Re: [sage-devel] the attack of the (really) long doctests

2009-12-13 Thread Robert Miller
> I will do groups/perm_gps/partn_ref/ next.  It's taking a bit longer > because I think I ran into some issues with refinement_matrices.pyx. What are the issues? I can take care of partn_ref if you want... -- Robert L. Miller http://www.rlmiller.org/ -- To post to this group, send an email t

Re: [sage-devel] the attack of the (really) long doctests

2009-12-14 Thread John Cremona
2009/12/14 Alex Ghitza : > > OK, the first patch, dealing with the Bernoulli numbers tests in > arith.py, is up at > > http://trac.sagemath.org/sage_trac/ticket/7678 I have made some comments there, and would welcome a second opinion! John -- To post to this group, send an email to sage-devel@

Re: [sage-devel] the attack of the (really) long doctests

2009-12-14 Thread Robert Bradshaw
On Dec 14, 2009, at 7:03 AM, John Cremona wrote: > 2009/12/14 Alex Ghitza : > >> >> OK, the first patch, dealing with the Bernoulli numbers tests in >> arith.py, is up at >> >> http://trac.sagemath.org/sage_trac/ticket/7678 > > I have made some comments there, and would welcome a second opinion!