Re: [sage-release] Re: Sage 10.1.beta3 released

2023-06-16 Thread Dave Morris
Maybe I'm being stupid, but I don't think the given list of generators is complete. The inverse of a generator is also a generator, so aren't there 8 generators, not 4? (Sorry I couldn't find the PR, to put this comment there.) On Friday, June 16, 2023 at 2:57:38 AM UTC-6 John Cremona wrote:

Re: [sage-release] Re: Sage 10.1.beta3 released

2023-06-16 Thread John Cremona
I'll review the new PR, though I probably should have seen this problem arising with the original one. John On Fri, 16 Jun 2023 at 09:30, Dima Pasechnik wrote: > You can't reopen PRs, I think, you can certainly reopen issues. > > No need to fill in the longish PR boilerplate, just remove it

Re: [sage-release] Re: Sage 10.1.beta3 released

2023-06-16 Thread Dima Pasechnik
You can't reopen PRs, I think, you can certainly reopen issues. No need to fill in the longish PR boilerplate, just remove it and write what it does, mentioning #35626 On Fri, 16 Jun 2023, 09:08 chris wuthrich, wrote: > I replaced old tests with "random" by new ones with "random" (and forgot

Re: [sage-release] Re: Sage 10.1.beta3 released

2023-06-16 Thread Samuel Lelièvre
The original pull request was merged, so open a new one. Trac tickets were occasionally reopened but not after they were merged in a development release. -- You received this message because you are subscribed to the Google Groups "sage-release" group. To unsubscribe from this group and stop

Re: [sage-release] Re: Sage 10.1.beta3 released

2023-06-16 Thread chris wuthrich
I replaced old tests with "random" by new ones with "random" (and forgot these two). Some other tests do check consistency. All that the function really does is converting a pari output back into a point on the elliptic curve. Therefore the test checks if pari runs without error and if the