Re: s3: Fix an infinite loop

2011-01-24 Thread Stefan (metze) Metzmacher
Hi Volker, > On Mon, Jan 24, 2011 at 09:14:23AM +0100, Stefan (metze) Metzmacher wrote: >> I think this change is wrong because, selret is a pointer and we already >> have this check (directly above): > > Gna. I have first done this in 3.5, where selrtn is not a > pointer. I have then just taken

Re: s3: Fix an infinite loop

2011-01-24 Thread Volker Lendecke
On Mon, Jan 24, 2011 at 09:14:23AM +0100, Stefan (metze) Metzmacher wrote: > I think this change is wrong because, selret is a pointer and we already > have this check (directly above): Gna. I have first done this in 3.5, where selrtn is not a pointer. I have then just taken the same patch and app

s3: Fix an infinite loop

2011-01-24 Thread Stefan (metze) Metzmacher
Hi Volker, I think this change is wrong because, selret is a pointer and we already have this check (directly above): if (*selrtn <= 0) { /* * No fd ready */ return false; } I've done some m