Author: jra
Date: 2005-09-26 21:41:58 +0000 (Mon, 26 Sep 2005)
New Revision: 10519

WebSVN: 
http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=10519

Log:
Fix logic bug found in code review. Don't release a share
mode lock before adding deferred record.
Jeremy.

Modified:
   trunk/source/smbd/open.c


Changeset:
Modified: trunk/source/smbd/open.c
===================================================================
--- trunk/source/smbd/open.c    2005-09-26 21:40:30 UTC (rev 10518)
+++ trunk/source/smbd/open.c    2005-09-26 21:41:58 UTC (rev 10519)
@@ -1568,7 +1568,6 @@
                if (!NT_STATUS_IS_OK(status)) {
                        struct deferred_open_record state;
 
-                       talloc_free(lck);
                        fd_close(conn, fsp);
                        file_free(fsp);
 
@@ -1585,6 +1584,7 @@
 
                        defer_open(lck, request_time, timeval_zero(),
                                   &state);
+                       talloc_free(lck);
                        return NULL;
                }
 

Reply via email to