Author: tpot Date: 2005-11-10 03:48:56 +0000 (Thu, 10 Nov 2005) New Revision: 11626
WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=11626 Log: Fix unhandled enum in case statement warnings by noting appropriately that some values aren't handled. The remaining warnings I think are actual bugs or required functionality that is missing (mostly lack of server side Unix extensions). Modified: branches/SAMBA_4_0/source/client/client.c branches/SAMBA_4_0/source/libcli/raw/rawsetfileinfo.c branches/SAMBA_4_0/source/torture/gentest.c branches/SAMBA_4_0/source/torture/rpc/samsync.c branches/SAMBA_4_0/source/winbind/wb_samba3_protocol.c Changeset: Modified: branches/SAMBA_4_0/source/client/client.c =================================================================== --- branches/SAMBA_4_0/source/client/client.c 2005-11-10 03:37:49 UTC (rev 11625) +++ branches/SAMBA_4_0/source/client/client.c 2005-11-10 03:48:56 UTC (rev 11626) @@ -1817,6 +1817,9 @@ (unsigned long long) fsinfo.objectid_information.out.unknown[5], (unsigned long long) fsinfo.objectid_information.out.unknown[6] ); break; + case RAW_QFS_GENERIC: + d_printf("\twrong level returned\n"); + break; } done: Modified: branches/SAMBA_4_0/source/libcli/raw/rawsetfileinfo.c =================================================================== --- branches/SAMBA_4_0/source/libcli/raw/rawsetfileinfo.c 2005-11-10 03:37:49 UTC (rev 11625) +++ branches/SAMBA_4_0/source/libcli/raw/rawsetfileinfo.c 2005-11-10 03:48:56 UTC (rev 11626) @@ -124,6 +124,18 @@ NEED_BLOB(4); SIVAL(blob->data, 0, parms->mode_information.in.mode); return True; + + /* Unhandled levels */ + + case RAW_SFILEINFO_UNIX_LINK: + case RAW_SFILEINFO_UNIX_HLINK: + case RAW_SFILEINFO_1023: + case RAW_SFILEINFO_1025: + case RAW_SFILEINFO_1029: + case RAW_SFILEINFO_1032: + case RAW_SFILEINFO_1039: + case RAW_SFILEINFO_1040: + break; } return False; Modified: branches/SAMBA_4_0/source/torture/gentest.c =================================================================== --- branches/SAMBA_4_0/source/torture/gentest.c 2005-11-10 03:37:49 UTC (rev 11625) +++ branches/SAMBA_4_0/source/torture/gentest.c 2005-11-10 03:48:56 UTC (rev 11626) @@ -1600,6 +1600,14 @@ CHECK_EQUAL(attribute_tag_information.out.attrib); CHECK_EQUAL(attribute_tag_information.out.reparse_tag); break; + + /* Unhandled levels */ + + case RAW_FILEINFO_SEC_DESC: + case RAW_FILEINFO_EA_LIST: + case RAW_FILEINFO_UNIX_BASIC: + case RAW_FILEINFO_UNIX_LINK: + break; } return True; Modified: branches/SAMBA_4_0/source/torture/rpc/samsync.c =================================================================== --- branches/SAMBA_4_0/source/torture/rpc/samsync.c 2005-11-10 03:37:49 UTC (rev 11625) +++ branches/SAMBA_4_0/source/torture/rpc/samsync.c 2005-11-10 03:48:56 UTC (rev 11626) @@ -1174,6 +1174,23 @@ ret = False; } break; + case NETR_DELTA_DELETE_GROUP: + case NETR_DELTA_RENAME_GROUP: + case NETR_DELTA_DELETE_USER: + case NETR_DELTA_RENAME_USER: + case NETR_DELTA_GROUP_MEMBER: + case NETR_DELTA_DELETE_ALIAS: + case NETR_DELTA_RENAME_ALIAS: + case NETR_DELTA_ALIAS_MEMBER: + case NETR_DELTA_DELETE_TRUST: + case NETR_DELTA_DELETE_ACCOUNT: + case NETR_DELTA_DELETE_SECRET: + case NETR_DELTA_DELETE_GROUP2: + case NETR_DELTA_DELETE_USER2: + case NETR_DELTA_MODIFY_COUNT: + printf("Unhandled delta type %d\n", r.out.delta_enum_array->delta_enum[d].delta_type); + ret = False; + break; } talloc_free(delta_ctx); } Modified: branches/SAMBA_4_0/source/winbind/wb_samba3_protocol.c =================================================================== --- branches/SAMBA_4_0/source/winbind/wb_samba3_protocol.c 2005-11-10 03:37:49 UTC (rev 11625) +++ branches/SAMBA_4_0/source/winbind/wb_samba3_protocol.c 2005-11-10 03:48:56 UTC (rev 11626) @@ -118,6 +118,49 @@ case WINBINDD_LIST_TRUSTDOM: return wbsrv_samba3_list_trustdom(s3call); + + /* Unimplemented commands */ + + case WINBINDD_GETPWNAM: + case WINBINDD_GETPWUID: + case WINBINDD_GETGRNAM: + case WINBINDD_GETGRGID: + case WINBINDD_GETGROUPS: + case WINBINDD_SETPWENT: + case WINBINDD_ENDPWENT: + case WINBINDD_GETPWENT: + case WINBINDD_SETGRENT: + case WINBINDD_ENDGRENT: + case WINBINDD_GETGRENT: + case WINBINDD_PAM_CHAUTHTOK: + case WINBINDD_LIST_USERS: + case WINBINDD_LIST_GROUPS: + case WINBINDD_SID_TO_UID: + case WINBINDD_SID_TO_GID: + case WINBINDD_UID_TO_SID: + case WINBINDD_GID_TO_SID: + case WINBINDD_ALLOCATE_RID: + case WINBINDD_ALLOCATE_RID_AND_GID: + case WINBINDD_CHECK_MACHACC: + case WINBINDD_DOMAIN_INFO: + case WINBINDD_SHOW_SEQUENCE: + case WINBINDD_WINS_BYIP: + case WINBINDD_WINS_BYNAME: + case WINBINDD_GETGRLST: + case WINBINDD_INIT_CONNECTION: + case WINBINDD_DUAL_SID2UID: + case WINBINDD_DUAL_SID2GID: + case WINBINDD_DUAL_IDMAPSET: + case WINBINDD_DUAL_UID2NAME: + case WINBINDD_DUAL_NAME2UID: + case WINBINDD_DUAL_GID2NAME: + case WINBINDD_DUAL_NAME2GID: + case WINBINDD_DUAL_USERINFO: + case WINBINDD_DUAL_GETSIDALIASES: + case WINBINDD_NUM_CMDS: + DEBUG(10, ("Unimplemented winbind samba3 request %d\n", + s3call->request.cmd)); + break; } s3call->response.result = WINBINDD_ERROR;
