Author: jra
Date: 2006-03-13 23:56:08 +0000 (Mon, 13 Mar 2006)
New Revision: 14358

WebSVN: 
http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=14358

Log:
Try and fix Coverity #169 by making the pointer
aliasing clearer. This isn't a bug but a code
clarification.
Jeremy.

Modified:
   trunk/source/smbd/posix_acls.c


Changeset:
Modified: trunk/source/smbd/posix_acls.c
===================================================================
--- trunk/source/smbd/posix_acls.c      2006-03-13 23:56:02 UTC (rev 14357)
+++ trunk/source/smbd/posix_acls.c      2006-03-13 23:56:08 UTC (rev 14358)
@@ -516,10 +516,12 @@
 
 static void free_canon_ace_list( canon_ace *list_head )
 {
-       while (list_head) {
-               canon_ace *old_head = list_head;
-               DLIST_REMOVE(list_head, list_head);
-               SAFE_FREE(old_head);
+       canon_ace *list, *next;
+
+       for (list = list_head; list; list = next) {
+               next = list->next;
+               DLIST_REMOVE(list_head, list);
+               SAFE_FREE(list);
        }
 }
 

Reply via email to