Author: jra Date: 2006-03-14 20:32:31 +0000 (Tue, 14 Mar 2006) New Revision: 14396
WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=14396 Log: Fix coverity bug #55. Ensure no unsigned/signed comparisons. Jeremy. Modified: trunk/source/rpc_server/srv_svcctl_nt.c Changeset: Modified: trunk/source/rpc_server/srv_svcctl_nt.c =================================================================== --- trunk/source/rpc_server/srv_svcctl_nt.c 2006-03-14 20:32:27 UTC (rev 14395) +++ trunk/source/rpc_server/srv_svcctl_nt.c 2006-03-14 20:32:31 UTC (rev 14396) @@ -404,7 +404,7 @@ WERROR _svcctl_enum_services_status(pipes_struct *p, SVCCTL_Q_ENUM_SERVICES_STATUS *q_u, SVCCTL_R_ENUM_SERVICES_STATUS *r_u) { ENUM_SERVICES_STATUS *services = NULL; - uint32 num_services; + int num_services; int i = 0; size_t buffer_size = 0; WERROR result = WERR_OK; @@ -421,7 +421,7 @@ } num_services = enumerate_status( p->mem_ctx, &services, token ); - if (num_services == (uint32)-1 ) { + if (num_services == -1 ) { return WERR_NOMEM; } @@ -444,7 +444,7 @@ } r_u->needed = (buffer_size > q_u->buffer_size) ? buffer_size : q_u->buffer_size; - r_u->returned = num_services; + r_u->returned = (uint32)num_services; if ( !(r_u->resume = TALLOC_P( p->mem_ctx, uint32 )) ) return WERR_NOMEM;