Author: jra
Date: 2006-06-28 00:05:53 +0000 (Wed, 28 Jun 2006)
New Revision: 16579

WebSVN: 
http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=16579

Log:
Fix Klocwork #2016. Possible null deref.
Jeremy.

Modified:
   branches/SAMBA_3_0/source/nmbd/nmbd_serverlistdb.c


Changeset:
Modified: branches/SAMBA_3_0/source/nmbd/nmbd_serverlistdb.c
===================================================================
--- branches/SAMBA_3_0/source/nmbd/nmbd_serverlistdb.c  2006-06-28 00:05:48 UTC 
(rev 16578)
+++ branches/SAMBA_3_0/source/nmbd/nmbd_serverlistdb.c  2006-06-28 00:05:53 UTC 
(rev 16579)
@@ -214,7 +214,7 @@
        struct work_record *iwork;
 
        /* Go through all the subnets we have already seen. */
-       for (ssub = FIRST_SUBNET; ssub != subrec; ssub = 
NEXT_SUBNET_INCLUDING_UNICAST(ssub)) {
+       for (ssub = FIRST_SUBNET; ssub && (ssub != subrec); ssub = 
NEXT_SUBNET_INCLUDING_UNICAST(ssub)) {
                for(iwork = ssub->workgrouplist; iwork; iwork = iwork->next) {
                        if(find_server_in_workgroup( iwork, servrec->serv.name) 
!= NULL) {
                                /*

Reply via email to