Author: jelmer Date: 2006-11-22 14:56:40 +0000 (Wed, 22 Nov 2006) New Revision: 19836
WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=19836 Log: Fix warnings in some IDL files. Modified: branches/SAMBA_4_0/source/gtk/tools/gwcrontab.c branches/SAMBA_4_0/source/librpc/idl/atsvc.idl branches/SAMBA_4_0/source/librpc/idl/dcom.idl branches/SAMBA_4_0/source/torture/rpc/atsvc.c Changeset: Modified: branches/SAMBA_4_0/source/gtk/tools/gwcrontab.c =================================================================== --- branches/SAMBA_4_0/source/gtk/tools/gwcrontab.c 2006-11-22 14:17:36 UTC (rev 19835) +++ branches/SAMBA_4_0/source/gtk/tools/gwcrontab.c 2006-11-22 14:56:40 UTC (rev 19836) @@ -134,7 +134,7 @@ talloc_free(mem_ctx); gtk_widget_destroy(d); - d = gtk_message_dialog_new (GTK_WINDOW(mainwin), GTK_DIALOG_DESTROY_WITH_PARENT, GTK_MESSAGE_INFO, GTK_BUTTONS_OK, "Job Id: %d", r.out.job_id); + d = gtk_message_dialog_new (GTK_WINDOW(mainwin), GTK_DIALOG_DESTROY_WITH_PARENT, GTK_MESSAGE_INFO, GTK_BUTTONS_OK, "Job Id: %d", *r.out.job_id); gtk_dialog_run(GTK_DIALOG(d)); gtk_widget_destroy(d); update_joblist(); Modified: branches/SAMBA_4_0/source/librpc/idl/atsvc.idl =================================================================== --- branches/SAMBA_4_0/source/librpc/idl/atsvc.idl 2006-11-22 14:17:36 UTC (rev 19835) +++ branches/SAMBA_4_0/source/librpc/idl/atsvc.idl 2006-11-22 14:56:40 UTC (rev 19836) @@ -74,7 +74,7 @@ NTSTATUS atsvc_JobAdd( [in,unique,string,charset(UTF16)] uint16 *servername, [in] atsvc_JobInfo *job_info, - [out] uint32 job_id + [out,ref] uint32 *job_id ); /******************/ @@ -105,7 +105,7 @@ [in,unique,string,charset(UTF16)] uint16 *servername, [in,out] atsvc_enum_ctr *ctr, [in] uint32 preferred_max_len, - [out] uint32 total_entries, + [out,ref] uint32 *total_entries, [in,out,unique] uint32 *resume_handle ); @@ -114,6 +114,6 @@ [public] NTSTATUS atsvc_JobGetInfo( [in,unique,string,charset(UTF16)] uint16 *servername, [in] uint32 job_id, - [out,unique] atsvc_JobInfo *job_info + [out] atsvc_JobInfo **job_info ); } Modified: branches/SAMBA_4_0/source/librpc/idl/dcom.idl =================================================================== --- branches/SAMBA_4_0/source/librpc/idl/dcom.idl 2006-11-22 14:17:36 UTC (rev 19835) +++ branches/SAMBA_4_0/source/librpc/idl/dcom.idl 2006-11-22 14:56:40 UTC (rev 19836) @@ -47,7 +47,7 @@ { [local] WERROR CreateInstance([in,unique] MInterfacePointer *pUnknown, [in,unique] GUID *iid, - [out, iid_is(riid),unique] MInterfacePointer *ppv); + [out, iid_is(riid)] MInterfacePointer **ppv); [call_as(CreateInstance)] WERROR RemoteCreateInstance(); @@ -85,7 +85,7 @@ [in] uint32 cRefs, /* count of AddRefs requested */ [in] uint16 cIids, /* count of IIDs that follow */ [in, unique, size_is(cIids)] GUID *iids, /* IIDs to QI for */ - [out, size_is(cIids), unique] MInterfacePointer *ip + [out, size_is(cIids)] MInterfacePointer **ip ); typedef struct @@ -98,7 +98,7 @@ [call_as(AddRef)] WERROR RemAddRef ( [in] uint16 cInterfaceRefs, [in, size_is(cInterfaceRefs)] REMINTERFACEREF InterfaceRefs[], - [out, size_is(cInterfaceRefs), unique] WERROR *pResults + [out, size_is(cInterfaceRefs)] WERROR **pResults ); [call_as(Release)] WERROR RemRelease ( @@ -177,9 +177,9 @@ [call_as(QueryInterface2)] WERROR RemQueryInterface2 ( [in, unique] GUID *ripid, [in] uint16 cIids, - [in, size_is(cIids), unique] GUID *iids, - [out, size_is(cIids), unique] WERROR *phr, - [out, size_is(cIids), unique] MInterfacePointer *ppMIF + [in, size_is(cIids)] GUID **iids, + [out, size_is(cIids)] WERROR **phr, + [out, size_is(cIids)] MInterfacePointer **ppMIF ); } @@ -191,8 +191,7 @@ { /*****************/ /* Function 0x03 */ - WERROR GetTypeInfoCount( - [out, unique] uint16 *pctinfo); + WERROR GetTypeInfoCount([out] uint16 *pctinfo); typedef struct { } REF_ITypeInfo; @@ -202,7 +201,7 @@ WERROR GetTypeInfo ( [in] uint16 iTInfo, [in] uint32 lcid, - [out, unique] REF_ITypeInfo *ppTInfo); + [out] REF_ITypeInfo **ppTInfo); /*****************/ /* Function 0x05 */ @@ -211,7 +210,7 @@ /*FIXME[in,size_is(cNames)] OLESTR *rgszNames[], */ [in] uint16 cNames, [in] uint32 lcid, - [out,size_is(cNames), unique] uint32 *rgDispId); + [out,size_is(cNames)] uint32 **rgDispId); typedef struct { uint16 vartype; @@ -235,9 +234,9 @@ [in] uint32 lcid, [in] uint16 wFlags, [out,in, unique] DISPPARAMS *pDispParams, - [out, unique] VARIANT *pVarResult, - [out, unique] EXCEPINFO *pExcepInfo, - [out, unique] uint16 *puArgErr); + [out] VARIANT **pVarResult, + [out] EXCEPINFO **pExcepInfo, + [out] uint16 **puArgErr); } [ Modified: branches/SAMBA_4_0/source/torture/rpc/atsvc.c =================================================================== --- branches/SAMBA_4_0/source/torture/rpc/atsvc.c 2006-11-22 14:17:36 UTC (rev 19835) +++ branches/SAMBA_4_0/source/torture/rpc/atsvc.c 2006-11-22 14:56:40 UTC (rev 19836) @@ -108,11 +108,11 @@ return false; } - if (!test_JobGetInfo(p, tctx, r.out.job_id)) { + if (!test_JobGetInfo(p, tctx, *r.out.job_id)) { return false; } - if (!test_JobDel(p, tctx, r.out.job_id, r.out.job_id)) { + if (!test_JobDel(p, tctx, *r.out.job_id, *r.out.job_id)) { return false; }
