Author: metze
Date: 2007-02-11 17:51:38 +0000 (Sun, 11 Feb 2007)
New Revision: 21282

WebSVN: 
http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=21282

Log:
we only need one for loop...

metze
Modified:
   branches/SAMBA_4_0/source/dsdb/repl/replicated_objects.c


Changeset:
Modified: branches/SAMBA_4_0/source/dsdb/repl/replicated_objects.c
===================================================================
--- branches/SAMBA_4_0/source/dsdb/repl/replicated_objects.c    2007-02-11 
17:36:33 UTC (rev 21281)
+++ branches/SAMBA_4_0/source/dsdb/repl/replicated_objects.c    2007-02-11 
17:51:38 UTC (rev 21282)
@@ -88,13 +88,6 @@
                                               msg->num_elements);
        W_ERROR_HAVE_NO_MEMORY(msg->elements);
 
-       for (i=0; i < msg->num_elements; i++) {
-               status = dsdb_attribute_drsuapi_to_ldb(schema,
-                                                      
&in->object.attribute_ctr.attributes[i],
-                                                      msg->elements, 
&msg->elements[i]);
-               W_ERROR_NOT_OK_RETURN(status);
-       }
-
        md = talloc(mem_ctx, struct replPropertyMetaDataBlob);
        W_ERROR_HAVE_NO_MEMORY(md);
 
@@ -111,11 +104,16 @@
                struct drsuapi_DsReplicaAttribute *a;
                struct drsuapi_DsReplicaMetaData *d;
                struct replPropertyMetaData1 *m;
+               struct ldb_message_element *e;
 
                a = &in->object.attribute_ctr.attributes[i];
                d = &in->meta_data_ctr->meta_data[i];
                m = &md->ctr.ctr1.array[i];
+               e = &msg->elements[i];
 
+               status = dsdb_attribute_drsuapi_to_ldb(schema, a, 
msg->elements, e);
+               W_ERROR_NOT_OK_RETURN(status);
+
                m->attid                        = a->attid;
                m->version                      = d->version;
                m->orginating_time              = d->orginating_time;

Reply via email to