Re: [PATCH] audit handling of waitpid() status codes

2003-01-09 Thread Martin Pool
On 9 Jan 2003, [EMAIL PROTECTED] wrote: Thanks for checking it. > Part of this (the smbd/chgpasswd.c patch) is incorrect I think. > > You have changed the line : > > if (WIFEXITED(wstat) == 0) { > ... > return False; > } > > to > > if (WIFEXITED(wstat)) { > ... > retu

Re: [PATCH] audit handling of waitpid() status codes

2003-01-09 Thread jra
On Thu, Jan 09, 2003 at 05:12:15PM +1100, Martin Pool wrote: > I found a data-corruption bug in ccache a few weeks ago relating to > incorrect handling of wait() status codes, so I thought I would do a > quick check for similar things in Samba. Part of this (the smbd/chgpasswd.c patch) is incorrec

[PATCH] audit handling of waitpid() status codes

2003-01-08 Thread Martin Pool
I found a data-corruption bug in ccache a few weeks ago relating to incorrect handling of wait() status codes, so I thought I would do a quick check for similar things in Samba. A patch is included: - several cases where child process failure is not detected - one inverted boolean - better m