Re: [scikit-learn] Google code reviews

2019-06-07 Thread Andreas Mueller
I think they might actually review the existing code base? But I'm not entirely sure. We can also nominate PRs, I think. On 6/7/19 10:50 AM, Adrin wrote: Would we need to nominate PRs for them to review, or would they find them on their own? Either case, could use a hand and extra eyes, why not

Re: [scikit-learn] Google code reviews

2019-06-07 Thread Adrin
Would we need to nominate PRs for them to review, or would they find them on their own? Either case, could use a hand and extra eyes, why not On Sat., May 25, 2019, 16:10 Joel Nothman, wrote: > For some of the larger PRs, this might be helpful. Not going to help where > the intricacies of Scikit

Re: [scikit-learn] Normalization in ridge regression when there is no intercept

2019-06-07 Thread Roman Yurchak via scikit-learn
On 06/06/2019 14:56, ahmetcik wrote: > I have just recognized that when using ridge regression without an > intercept no normalization is performed even if the argument "normalize" > is set to True. It's a known longstanding issue https://github.com/scikit-learn/scikit-learn/issues/3020 It would