Re: [scikit-learn] Experience with black formatting in scikit-learn for astropy

2022-05-19 Thread Tom Aldcroft
Thanks Guillaume and Olivier for the quick feedback. There are enough people on the fence in astropy that information like this is quite valuable. If anyone is interested, here is the monster thread. ;-) https://groups.google.com/g/astropy-dev/c/6cRJCMgaFyM Best, Tom On Thu, May 19, 2022 at 7:5

Re: [scikit-learn] Experience with black formatting in scikit-learn for astropy

2022-05-19 Thread Olivier Grisel
I agree with Guillaume's answers. I think it was a net benefit, even though it might be a bit annoying to get the tooling right for first time contributors. We can probably improve this by making the error messages on the CI more directive on how to fix formatting issues by given copy-pastable com

Re: [scikit-learn] Experience with black formatting in scikit-learn for astropy

2022-05-19 Thread Guillaume LemaƮtre
I just answer in the text below. This is my 2c. Hope this helps Cheers, On Wed, 18 May 2022 at 22:08, Tom Aldcroft wrote: > Hi - > > The astropy core is currently considering implementing code formatting > with black, much as scikit-learn did in 2020 ( > https://github.com/scikit-learn/scikit-

[scikit-learn] Experience with black formatting in scikit-learn for astropy

2022-05-18 Thread Tom Aldcroft
Hi - The astropy core is currently considering implementing code formatting with black, much as scikit-learn did in 2020 ( https://github.com/scikit-learn/scikit-learn/pull/18948). Not surprisingly there are a wide range of opinions and concerns. My goal in writing is to request feedback from the