Re: [scikit-learn] Inconsistencies in clustering documentations

2018-05-23 Thread Beaugnon Anael
Thanks for your answers. DBSCAN has the correct doc because the fit_predict method is not inherited, but it has its own implementation (because of the additional parameter sample_weight). I have forked the sklearn repo. I work in a virtualenv (virtualenv venv3 --no-site-packages --python python3.

Re: [scikit-learn] Inconsistencies in clustering documentations

2018-05-23 Thread Andreas Mueller
+1 for a PR on fit_predict docs. This is probably due to the inheritance structure. Though it's weird that DBSCAN has the correct docs. I'm not sure about renaming affinity, but we can discuss that. I agree it's misleading. On 5/23/18 8:01 AM, Tom DLT wrote: Hi Anaël, Thanks for spotting t

Re: [scikit-learn] Inconsistencies in clustering documentations

2018-05-23 Thread Tom DLT
Hi Anaël, Thanks for spotting these inconsistencies. You are very welcome to open pull-requests and/or issues on the GitHub tracker (cf. http://scikit-learn.org/stable/developers/contributing.html#contributing-code ) The documentation issue should be straightforward. The parameter renaming would n

[scikit-learn] Inconsistencies in clustering documentations

2018-05-23 Thread Beaugnon Anael
Dear all, Three clustering algorithms can take as input distance or similarity matrices instead of the observations (AgglomerativeClustering , AffinityPropagation