Re: [scikit-learn] Using a new random number generator in libsvm and liblinear

2020-01-04 Thread Gael Varoquaux
Me neither. The only drawback that I see is that we have a codebase that is drifting more and more from upstream. But I think that that ship has sailed. G On Sat, Jan 04, 2020 at 01:49:50PM +0100, Alexandre Gramfort wrote: > I don't foresee any issue with that. > Alex >

Re: [scikit-learn] Using a new random number generator in libsvm and liblinear

2020-01-04 Thread Alexandre Gramfort
I don't foresee any issue with that. Alex ___ scikit-learn mailing list scikit-learn@python.org https://mail.python.org/mailman/listinfo/scikit-learn

Re: [scikit-learn] Using a new random number generator in libsvm and liblinear

2020-01-02 Thread Ruchika Nayyar
OK On Thu, Jan 2, 2020, 10:42 AM Adrin wrote: > Hi, > > liblinear and libsvm use the C `rand()` function which returns number up to > 32767 on the windows platform. This PR > proposes the > following fix: > > *Fixed a convergence issue in

[scikit-learn] Using a new random number generator in libsvm and liblinear

2020-01-02 Thread Adrin
Hi, liblinear and libsvm use the C `rand()` function which returns number up to 32767 on the windows platform. This PR proposes the following fix: *Fixed a convergence issue in ``libsvm`` and ``liblinear`` on Windows platforms* *impacting