Re: [Scikit-learn-general] [scikit-learn] Weighted pls -- adding support for sample_weight option. (#4974)

2015-09-14 Thread Deepak Subburam
ormalesup.org> Content-Type: text/plain; charset=us-ascii On Mon, Jul 06, 2015 at 04:55:07PM -0400, Deepak Subburam wrote: I have some time to contribute, and would like to implement a sample_weight option to the

Re: [Scikit-learn-general] Planning on implementing sample_weight option for PLSRegression.fit()

2015-07-13 Thread Deepak Subburam
nd whether the NIPALS implementation is fast and stable enough, and the appropriate choice in all cases. On 07/07/2015 04:51 PM, Deepak Subburam wrote: > Cool. I spent some time inspecting the pls_.py source file. There are a > whole lot of if conditions prevalent in the code (on > deflation_mode=

Re: [Scikit-learn-general] Planning on implementing sample_weight option for PLSRegression.fit()

2015-07-07 Thread Deepak Subburam
Gael Varoquaux > Subject: Re: [Scikit-learn-general] Planning on implementing > sample_weight option for PLSRegression.fit() > To:scikit-learn-general@lists.sourceforge.net > Message-ID:<20150707000341.ga2996...@phare.normalesup.org> > Content-Type: text/plain; charset=us

[Scikit-learn-general] Planning on implementing sample_weight option for PLSRegression.fit()

2015-07-06 Thread Deepak Subburam
Hi, I have some time to contribute, and would like to implement a sample_weight option to the fit() method of sklearn.cross_decomposition.PLSRegression, handling any other knock-on effects. Let me know if you think this is not a good idea, or have any other thoughts to guide me. Thanks, Deepa