Hi Olivier,
The code looks very well written. I think it would fit well in
scikit-learn. The API would have to be modified to fit the scikit-learn
format. You can read more about that at the developers' page:
http://scikit-learn.org/stable/developers/index.html
It will also require some un
On 03/15/2012 06:41 PM, Olivier Grisel wrote:
Le 13 mars 2012 02:32, Olivier Mangin a écrit :
Hello,
Since I am currently using NMF for my robotics research, I have an
implementation of some algorithms from [1]_ that could extend
scikit-learn current implementation.
More precisely the current
Le 13 mars 2012 02:32, Olivier Mangin a écrit :
> Hello,
>
> Since I am currently using NMF for my robotics research, I have an
> implementation of some algorithms from [1]_ that could extend
> scikit-learn current implementation.
>
> More precisely the current implementation covers the Frobenius
Hi Olivier,
Just a quick answer (I am on holidays, skying :} ). Please forget me for
being a bit direct in this email: I don't have much time in front of the
computer.
My gut feeling is that the algorithms that you propose are in the scope
of the scikit. I do not think that they are a duplication
Hello,
Since I am currently using NMF for my robotics research, I have an
implementation of some algorithms from [1]_ that could extend
scikit-learn current implementation.
More precisely the current implementation covers the Frobenius norm case
(for measuring the reconstruction error), and th
