Re: [Scikit-learn-general] Putting SVC and NuSVC into the same class

2012-01-09 Thread Lars Buitinck
2012/1/9 Olivier Grisel : > That would work. Alternatively we could have: > > algorithm="csvm" or algorithm="nusvm" as already used elsewhere > (e.g. neighbors, pls, dict_learning and manifold). +1. -- Lars Buitinck Scientific programmer, ILPS University of Amsterdam ---

Re: [Scikit-learn-general] Putting SVC and NuSVC into the same class

2012-01-09 Thread Andreas
On 01/09/2012 12:19 PM, Mathieu Blondel wrote: > On Mon, Jan 9, 2012 at 7:40 PM, Gael Varoquaux > wrote: > > >> Can it be that if nu is None C is used, or do you thihnk that this is >> confusing? >> > That wouldn't work for NuSVR, which uses both C and nu (I know, it's > confusing). >

Re: [Scikit-learn-general] Putting SVC and NuSVC into the same class

2012-01-09 Thread Gael Varoquaux
On Mon, Jan 09, 2012 at 08:19:33PM +0900, Mathieu Blondel wrote: > > Can it be that if nu is None C is used, or do you thihnk that this is > > confusing? > That wouldn't work for NuSVR, which uses both C and nu (I know, it's > confusing). That's exactly what I had in mind: I was proposing nu to b

Re: [Scikit-learn-general] Putting SVC and NuSVC into the same class

2012-01-09 Thread Mathieu Blondel
On Mon, Jan 9, 2012 at 7:40 PM, Gael Varoquaux wrote: > Can it be that if nu is None C is used, or do you thihnk that this is > confusing? That wouldn't work for NuSVR, which uses both C and nu (I know, it's confusing). If we merge C-SVM and nu-SVM classes, users may think that they can obtain

Re: [Scikit-learn-general] Putting SVC and NuSVC into the same class

2012-01-09 Thread Olivier Grisel
2012/1/9 Gael Varoquaux : > On Mon, Jan 09, 2012 at 11:11:29AM +0100, Lars Buitinck wrote: >> 2012/1/9 Fabian Pedregosa : >> > I'm OK with the idea of having one class for classification and one >> > for regression. It's conceptually easier and simplifies the docs. +1 > >> What should the parameter

Re: [Scikit-learn-general] Putting SVC and NuSVC into the same class

2012-01-09 Thread Gael Varoquaux
On Mon, Jan 09, 2012 at 11:11:29AM +0100, Lars Buitinck wrote: > 2012/1/9 Fabian Pedregosa : > > I'm OK with the idea of having one class for classification and one > > for regression. It's conceptually easier and simplifies the docs. +1 > What should the parameter be called that chooses nu vs. C?

Re: [Scikit-learn-general] Putting SVC and NuSVC into the same class

2012-01-09 Thread Lars Buitinck
2012/1/9 Fabian Pedregosa : > I'm OK with the idea of having one class for classification and one > for regression. It's conceptually easier and simplifies the docs. +1 What should the parameter be called that chooses nu vs. C? -- Lars Buitinck Scientific programmer, ILPS University of Amsterdam

Re: [Scikit-learn-general] Putting SVC and NuSVC into the same class

2012-01-09 Thread Fabian Pedregosa
On Sun, Jan 8, 2012 at 11:06 PM, Andreas wrote: > Hey everybody. > @larsmans (my personal hero for the day) started refactoring the SVM > class structure here: > https://github.com/larsmans/scikit-learn/commits/refactor-svm > after some discussion here: > https://github.com/scikit-learn/scikit-lea

Re: [Scikit-learn-general] Putting SVC and NuSVC into the same class

2012-01-08 Thread Andreas
On 01/08/2012 11:29 PM, Olivier Grisel wrote: > 2012/1/8 Andreas: > >> Hey everybody. >> @larsmans (my personal hero for the day) started refactoring the SVM >> class structure here: >> https://github.com/larsmans/scikit-learn/commits/refactor-svm >> after some discussion here: >> https://githu

Re: [Scikit-learn-general] Putting SVC and NuSVC into the same class

2012-01-08 Thread Olivier Grisel
2012/1/8 Vlad Niculae : > A bit off topic but since we're talking about work on the SVM module, I > noticed something wrong with the docs. > > http://scikit-learn.org/dev/modules/svm.html#tips-on-practical-use > > The scaling part makes reference to some "Cookbook" (I don't know what this > is, i

Re: [Scikit-learn-general] Putting SVC and NuSVC into the same class

2012-01-08 Thread Vlad Niculae
A bit off topic but since we're talking about work on the SVM module, I noticed something wrong with the docs. http://scikit-learn.org/dev/modules/svm.html#tips-on-practical-use The scaling part makes reference to some "Cookbook" (I don't know what this is, it probably died before I joined you

Re: [Scikit-learn-general] Putting SVC and NuSVC into the same class

2012-01-08 Thread Olivier Grisel
2012/1/8 Andreas : > Hey everybody. > @larsmans (my personal hero for the day) started refactoring the SVM > class structure here: > https://github.com/larsmans/scikit-learn/commits/refactor-svm > after some discussion here: > https://github.com/scikit-learn/scikit-learn/issues/253 > and somewhat r

[Scikit-learn-general] Putting SVC and NuSVC into the same class

2012-01-08 Thread Andreas
Hey everybody. @larsmans (my personal hero for the day) started refactoring the SVM class structure here: https://github.com/larsmans/scikit-learn/commits/refactor-svm after some discussion here: https://github.com/scikit-learn/scikit-learn/issues/253 and somewhat related here: https://github.com