Re: [Scikit-learn-general] What caused the HMM test failure

2012-10-31 Thread Lars Buitinck
2012/10/31 Olivier Grisel : >>> Can we have a vote on this? +1 -- Lars Buitinck Scientific programmer, ILPS University of Amsterdam -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics D

Re: [Scikit-learn-general] What caused the HMM test failure

2012-10-31 Thread Olivier Grisel
2012/10/31 Andreas Mueller : > On 10/31/2012 10:09 AM, Gael Varoquaux wrote: >> On Tue, Oct 30, 2012 at 03:40:48PM +0100, Lars Buitinck wrote: >>> Agree with David, int->float conversion should be expected to produce >>> larger arrays. >> Can we have a vote on this? +1 too -- Olivier http://twit

Re: [Scikit-learn-general] What caused the HMM test failure

2012-10-31 Thread Andreas Mueller
On 10/31/2012 10:09 AM, Gael Varoquaux wrote: > On Tue, Oct 30, 2012 at 03:40:48PM +0100, Lars Buitinck wrote: >> Agree with David, int->float conversion should be expected to produce >> larger arrays. > Can we have a vote on this? > > I am +0 on int->float conversion always giving float64 (np.floa

Re: [Scikit-learn-general] What caused the HMM test failure

2012-10-31 Thread Gael Varoquaux
On Tue, Oct 30, 2012 at 03:40:48PM +0100, Lars Buitinck wrote: > Agree with David, int->float conversion should be expected to produce > larger arrays. Can we have a vote on this? I am +0 on int->float conversion always giving float64 (np.float). G --

Re: [Scikit-learn-general] What caused the HMM test failure

2012-10-30 Thread Lars Buitinck
2012/10/30 Gael Varoquaux : > On Mon, Oct 29, 2012 at 05:05:11PM -0400, David Warde-Farley wrote: >> Comment from the peanut gallery: this seems like a supremely odd >> function to have, since int32s cannot be safely represented in 32-bit >> floating point anyway (nor int64s in float64, but there's

Re: [Scikit-learn-general] What caused the HMM test failure

2012-10-30 Thread Gael Varoquaux
On Mon, Oct 29, 2012 at 05:05:11PM -0400, David Warde-Farley wrote: > Comment from the peanut gallery: this seems like a supremely odd > function to have, since int32s cannot be safely represented in 32-bit > floating point anyway (nor int64s in float64, but there's not much you > can do about it w

Re: [Scikit-learn-general] What caused the HMM test failure

2012-10-29 Thread David Warde-Farley
On Mon, Oct 29, 2012 at 2:03 PM, Andreas Mueller wrote: > Hi everybody. > Olivier asked me to explain my commit: > https://github.com/scikit-learn/scikit-learn/commit/00d1055bf9f00e7024f9c4757262ffb852a61267 > On the ML, so here goes: > The code used > > as_float_array(startprob, copy=False) > > w

[Scikit-learn-general] What caused the HMM test failure

2012-10-29 Thread Andreas Mueller
Hi everybody. Olivier asked me to explain my commit: https://github.com/scikit-learn/scikit-learn/commit/00d1055bf9f00e7024f9c4757262ffb852a61267 On the ML, so here goes: The code used as_float_array(startprob, copy=False) which I replaced with np.array(startprob, dtype=np.float) Basically as_