Re: [Scikit-learn-general] Problems with 'make'

2013-09-17 Thread Maheshakya Wijewardena
Setting a default value for base_estimator solves the problem. Thank you. Maheshakya On Tue, Sep 17, 2013 at 4:59 PM, Lars Buitinck wrote: > 2013/9/17 Maheshakya Wijewardena : > > def __init__(self, base_estimator, n_estimators=10, max_samples=1.0, > > You need a default value for base_estimat

Re: [Scikit-learn-general] Problems with 'make'

2013-09-17 Thread Lars Buitinck
2013/9/17 Maheshakya Wijewardena : > def __init__(self, base_estimator, n_estimators=10, max_samples=1.0, You need a default value for base_estimator. -- LIMITED TIME SALE - Full Year of Microsoft Training For Just $49.99

Re: [Scikit-learn-general] Problems with 'make'

2013-09-17 Thread Olivier Grisel
2013/9/17 Maheshakya Wijewardena : > this is the __init__ function. > > > def __init__(self, base_estimator, n_estimators=10, max_samples=1.0, > bootstrap=True, oob_score=False, n_jobs=1, > random_state=None, verbose=0): > if base_estimator == None: > base_estimator = DecisionTr

Re: [Scikit-learn-general] Problems with 'make'

2013-09-17 Thread Maheshakya Wijewardena
This is the __init__ function of the parent class. (Above class is inherited from this and RegressorMixin) @abstractmethod def __init__(self, base_estimator=None, n_estimators=10, max_samples=1.0, bootstrap=True, oob_score=False, n_jobs=1, random_st

Re: [Scikit-learn-general] Problems with 'make'

2013-09-17 Thread Maheshakya Wijewardena
this is the __init__ function. def __init__(self, base_estimator, n_estimators=10, max_samples=1.0, bootstrap=True, oob_score=False, n_jobs=1, random_state=None, verbose=0): if base_estimator == None: base_estimator = DecisionTreeRegressor super(Baggin

Re: [Scikit-learn-general] Problems with 'make'

2013-09-17 Thread Gael Varoquaux
On Tue, Sep 17, 2013 at 03:32:26PM +0530, Maheshakya Wijewardena wrote: > @Lars: I have followed the coding guidelines. In particular: http://scikit-learn.org/dev/developers/index.html#rolling-your-own-estimator ? > It doesn't seems that this problem is related to that. The test failure that yo

Re: [Scikit-learn-general] Problems with 'make'

2013-09-17 Thread Robert Layton
Email the code of the __init__ function of your classifier. On 17 September 2013 20:02, Maheshakya Wijewardena wrote: > @Lars: I have followed the coding guidelines. It doesn't seems that this > problem is related to that. > > @Robert: I didn't get what do you mean by copy paste. Can you elabora

Re: [Scikit-learn-general] Problems with 'make'

2013-09-17 Thread Maheshakya Wijewardena
@Lars: I have followed the coding guidelines. It doesn't seems that this problem is related to that. @Robert: I didn't get what do you mean by copy paste. Can you elaborate. On Tue, Sep 17, 2013 at 2:53 PM, Robert Layton wrote: > Also, are you able to copy paste your __init__ function? > > >

Re: [Scikit-learn-general] Problems with 'make'

2013-09-17 Thread Robert Layton
Also, are you able to copy paste your __init__ function? On 17 September 2013 19:14, Lars Buitinck wrote: > 2013/9/17 Maheshakya Wijewardena : > > I have initialized my estimator(those I created) with default classifiers > > and regressors. But still, I get the same error. > > Did you read and

Re: [Scikit-learn-general] Problems with 'make'

2013-09-17 Thread Lars Buitinck
2013/9/17 Maheshakya Wijewardena : > I have initialized my estimator(those I created) with default classifiers > and regressors. But still, I get the same error. Did you read and follow the coding guidelines? http://scikit-learn.org/stable/developers/index.html#coding-guidelines -

Re: [Scikit-learn-general] Problems with 'make'

2013-09-17 Thread Maheshakya Wijewardena
I have initialized my estimator(those I created) with default classifiers and regressors. But still, I get the same error. On Tue, Sep 17, 2013 at 10:26 AM, Robert Layton wrote: > scikit-learn classifiers should have default values for all __init__ > parameters (except, of course `self`). Set a

Re: [Scikit-learn-general] Problems with 'make'

2013-09-16 Thread Robert Layton
scikit-learn classifiers should have default values for all __init__ parameters (except, of course `self`). Set a default for each and the tests will pass this point. On 17 September 2013 14:53, Maheshakya Wijewardena wrote: > Yes. I have some classes inherited from ClassifierMixin and > Regress

Re: [Scikit-learn-general] Problems with 'make'

2013-09-16 Thread Maheshakya Wijewardena
Yes. I have some classes inherited from ClassifierMixin and RegressorMixin. So what can be done to resolve this? On Tue, Sep 17, 2013 at 10:09 AM, Robert Layton wrote: > If you used the Mixin classes to build a classifier, they will get tested > here automatically. > Is that what you did? > > >

Re: [Scikit-learn-general] Problems with 'make'

2013-09-16 Thread Robert Layton
If you used the Mixin classes to build a classifier, they will get tested here automatically. Is that what you did? On 17 September 2013 14:35, Maheshakya Wijewardena wrote: > I added my own features and tried to run make command. But while the > process I get the following error trace and the m