[scm-migration-dev] wx2hg and usr/closed

2008-07-30 Thread Gavin Maltby
Hi, Is wx2hg expected to handle migrating Teamware workspaces that include changes in both the usr/src and usr/closed trees? I just tried wx2hg on such a workspace and it failed as follows: (gavinm at hyper:/tank/scratch/gavinm/on-fx-hg )-> wx2hg -u -r onnv_95 /tank/scratch/gavinm/on-fx-merge

[scm-migration-dev] code review request for nightly.sh usability fixes

2008-07-30 Thread Mark J. Nelson
So after review comments, my changes look like this: http://cr.opensolaris.org/~mjnelson/webrev.nightly.2/ ...which is an incremental change like this from the first webrev: http://cr.opensolaris.org/~mjnelson/webrev.nightly.1-2/ > Mike> Maybe the references should all be changed to $CLOSEDSRC

[scm-migration-dev] quick review for followup putback for wx2hg changes

2008-07-30 Thread Mark J. Nelson
Thank you, Mike. I was kind of frustrated by exactly what you point out. With the "set +x," I worried that it would reset $?, but I didn't bother to check. --Mark On Wed, 30 Jul 2008, Mike Kupfer wrote: > Date: Wed, 30 Jul 2008 20:00:29 -0700 > From: Mike Kupfer > To: Mark J. Nelson > Cc:

[scm-migration-dev] whitespace got lost in mail cleanup. put it back.

2008-07-30 Thread david.mar...@sun.com
Author: dmarker Repository: /hg/scm-migration/onnv-gk-tools Latest revision: 787ff033ba9a267d38250c1b3e57a3604a5a3f2e Total changesets: 1 Log message: whitespace got lost in mail cleanup. put it back. Files: update: hook/gknotify.py update: hook/notify.py update: lib/utili

[scm-migration-dev] code review request for nightly.sh usability fixes

2008-07-30 Thread Mike Kupfer
> "Mark" == Mark J Nelson writes: Mike> Maybe the references should all be changed to $CLOSEDSRC (or some Mike> other appropriately named and initialized variable)? Mark> Seems reasonable, though it would probably be CLOSEDROOT or Mark> somesuch. Well, as Rich (?) pointed out, people are li

[scm-migration-dev] quick review for followup putback for wx2hg changes

2008-07-30 Thread Mike Kupfer
> set -x > hg init $ws/$dir > - ( cd $ws/$dir; hg pull -u "$primary_twin"/$dir ) > + ( cd $ws/$dir; hg pull -u -r $rev "$primary_twin"/$dir ) > + if (( $? != 0 )); then > + warn "Unable to clone $prima

[scm-migration-dev] code review request for nightly.sh usability fixes

2008-07-30 Thread Richard Lowe
"Mark J. Nelson" writes: >> First issue: you replaced "$SRC/../closed" with >> "$CODEMGR_WS/usr/closed", but not everywhere. Is there a particular >> reason for making that change? I'd like to see the rationale in the >> Bugster entry, so that people aren't left wondering in the future. > > Sty

[scm-migration-dev] Sponsor task SCM updates

2008-07-30 Thread Mark J. Nelson
>>> * As opposed to the Mercurial changeset comment, the commit message >>> should have an additional line, ... >>> >>> [note: is "commit message" the right lingo?] >> >> "changeset comment" > > I'm confused by this... It doesn't make sense to say "As opposed the > Mercurial changeset comment

[scm-migration-dev] 350 usr/src/tools contains user-visible SCCS keywords (missed files)

2008-07-30 Thread richl...@richlowe.net
Author: Richard Lowe Repository: /hg/scm-migration/onnv-transition Latest revision: 0f1f217fe07229171968a45e2af7a5c6853ebc5f Total changesets: 1 Log message: 350 usr/src/tools contains user-visible SCCS keywords (missed files) Files: update: usr/src/tools/abi/audit/abi_audit.c upd

[scm-migration-dev] quick review for followup putback for wx2hg changes

2008-07-30 Thread Mark J. Nelson
I broke remote repo clone, 'cause I contrived all-local test cases. Here's the intended followup putback comment: 6731044 wx2hg should deal better with nested repositories (fix remote clones) ...and here's the unified diff for the fix, as validated by pwernau, who discovered the break

[scm-migration-dev] RTI Nits changes for hg transition

2008-07-30 Thread Valerie Bubb Fenwick
On Tue, 29 Jul 2008, Mark J. Nelson wrote: > >>> SCM folks: Do you have any advice on this section? >>> >>> Advocates >>> ... >>> * Workspace checking is highly recommended, as it is easy and quick and >>> has >>> prevented many problems; also, many problems which could have easily >>> been

[scm-migration-dev] RTI Nits changes for hg transition

2008-07-30 Thread Valerie Bubb Fenwick
On Tue, 29 Jul 2008, Richard Lowe wrote: > Valerie Bubb Fenwick writes: > >> Thanks Mark & Rich, here are the proposed changes to the RTI nits >> (much of the content is from Mark :) I've included complete >> changed sections, elipses indicate areas I don't think need >> updating - please let me

[scm-migration-dev] code review request for nightly.sh usability fixes

2008-07-30 Thread Mark J. Nelson
> I have a couple minor concerns, and I gather the logic for when to pull > the closed tree is not quite right...? Right, it works with current developer.sh environments, but not with the improved ones we're about to putback (like first thing on Tuesday). > First issue: you replaced "$SRC/../

[scm-migration-dev] Sponsor task SCM updates

2008-07-30 Thread Valerie Bubb Fenwick
On Tue, 29 Jul 2008, Mark J. Nelson wrote: > >> Based on Mark & Rich's guidance on the RTI nits, I'm suggesting >> the following edits for the Sponsor Tasks page. This page will not >> go live until August 5. >> >> Original: >> http://opensolaris.org/os/community/on/crt/sponsor-tasks/ >> >> Dev

[scm-migration-dev] code review request for nightly.sh usability fixes

2008-07-30 Thread Tim Haley
Mark J. Nelson wrote: > > http://cr.opensolaris.org/~mjnelson/webrev.nightly/ > > I have tested both portions of this fix as follows: > > - for the bringover of usr/closed, I instrumented nightly to fail after > the repository initialization and before the bringover, and tested with > no exi

[scm-migration-dev] code review request for nightly.sh usability fixes

2008-07-30 Thread Mike Kupfer
I have a couple minor concerns, and I gather the logic for when to pull the closed tree is not quite right...? First issue: you replaced "$SRC/../closed" with "$CODEMGR_WS/usr/closed", but not everywhere. Is there a particular reason for making that change? I'd like to see the rationale in the B

[scm-migration-dev] code review request for nightly.sh usability fixes

2008-07-30 Thread Mark J. Nelson
http://cr.opensolaris.org/~mjnelson/webrev.nightly/ I have tested both portions of this fix as follows: - for the bringover of usr/closed, I instrumented nightly to fail after the repository initialization and before the bringover, and tested with no existing repos, only open, and both, al

[scm-migration-dev] simplify tag check and fix backout check

2008-07-30 Thread david.mar...@sun.com
Author: dmarker Repository: /hg/scm-migration/onnv-gk-tools Latest revision: 8f918d2197a502b2a81801e69e77507d8318d41b Total changesets: 1 Log message: simplify tag check and fix backout check Files: update: gate-closed-hgrc update: gate-hgrc update: hook/sanity.py

[scm-migration-dev] wx2hg and usr/closed

2008-07-30 Thread James Carlson
Gavin Maltby writes: > Is wx2hg expected to handle migrating Teamware workspaces that include changes > in both the usr/src and usr/closed trees? I just tried wx2hg on such a > workspace > and it failed as follows: Funny you should ask ... Mark Nelson just fixed a bunch of nested respository pro

[scm-migration-dev] [Bug 563] New: Prototypes should not contain SCCS keywords

2008-07-30 Thread bugzilla-dae...@np.grommit.com
http://bugs.grommit.com/show_bug.cgi?id=563 Summary: Prototypes should not contain SCCS keywords Product: SCM Migration Version: unspecified Platform: All OS/Version: Solaris 11/Nevada Status: NEW Severity: normal P

[scm-migration-dev] wx2hg and usr/closed

2008-07-30 Thread Mark J. Nelson
I have an RTI approved for the fix to make wx2hg do this correctly. --Mark On Wed, 30 Jul 2008, Gavin Maltby wrote: > Date: Wed, 30 Jul 2008 21:44:33 +1000 > From: Gavin Maltby > To: scm-migration-dev at opensolaris.org > Subject: [scm-migration-dev] wx2hg and usr/closed > > Hi, > > Is wx2hg